Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1902373pxp; Mon, 7 Mar 2022 04:59:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLEcZv/nSmP+XHU1xIV2o5QGnaRflYJv5xQuJwiyl928yaE/n+PSiQ8LnC8MGnHC+04eKG X-Received: by 2002:a05:6402:440b:b0:415:c50d:853b with SMTP id y11-20020a056402440b00b00415c50d853bmr10915774eda.346.1646657998377; Mon, 07 Mar 2022 04:59:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646657998; cv=none; d=google.com; s=arc-20160816; b=Au2DbIzN/YewZJsz1RF1ifeTY7gYNA3IuNxZkMCsXxBccoLxIPSs9tpDWL1Wg801X4 gPk9qe5f5ab/v6o1VQE4nPP6Rhs9xam0iNeHetJ5z4Z1VddY0A04t5wJcMJNdMiESTSj a1dDYKyIUYjdi8gISxyU+CwkZRZjcgJjH65s2f7TXsokw+2j4dZEjnxaCnzwek95z8ca IaWQF3KFljc7ITteKlIN0fHTWaLzRZISFByXr6t2vEwNXffuXkyMmdvQrRlNWclfD4kU C+x/+fSyWrMlrlPfnC5pWAsRm3KJmQ2G7O8sBieh26DJdCtlYqOEZGOo2VFNyvWE+UJD K8vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A0K49IH90GyBR4TWsmvEUjJBiH/MFOUraBEoNjqrqZ4=; b=mDcQXBfZMDa+c8/JWAnOYIy9uk/nBQujOksA7fJ8ukSR1tEGHAOiWF2FhV84YNnVuv wGuVwOrXDdYjZtFES8kWWyDYOOaY3TgphBbQgCxrXrWsr5AZFRegIub6+PEdbitt8VFJ dGLqkRAEj1B+1IDLTHq7tAjuOYZsFmWL5MHF1MnanYxgPA+NJk9m8aFTVm4ZvO1+EczP UURmBE5uBp/MnU8Njei34vAbs+8gHennBgyDnLS5efVf4R8P4A2qrzqlh0n8w+yyGvA3 4SceR8Ug26/vnmvPhwdL1gyJtZYpwq/UeQBb+oLx6K5E4dxDDoNESQL739aoRB79zhta 8ANQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VBmHT9+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c16-20020a05640227d000b0041650688dd7si1396537ede.324.2022.03.07.04.59.34; Mon, 07 Mar 2022 04:59:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VBmHT9+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241829AbiCGKVT (ORCPT + 99 others); Mon, 7 Mar 2022 05:21:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240470AbiCGKBD (ORCPT ); Mon, 7 Mar 2022 05:01:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4B2D7663; Mon, 7 Mar 2022 01:48:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E5FF60010; Mon, 7 Mar 2022 09:48:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91CF7C340F5; Mon, 7 Mar 2022 09:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646518; bh=iFwxgd4D3nV04ruy4pLo/XsfpWUFmnSQgq18Byp2Xp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VBmHT9+2gm0rA4MZWjlLXzjsGtCA6dwVrKO+1RtQdfaX/LnkanaCaYYlV805NKym8 YjF1wwVXZ9PpqrBbPOKh/naHLNYZSnpG0D6NtrXaFoQV+ZoNlk8aNB5lr5/4bczOPr aA5gP1Co7ClKIDI4pYsomB02MjWZOoATodZ0kkUw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Like Xu , Sean Christopherson , Paolo Bonzini Subject: [PATCH 5.15 262/262] KVM: x86/mmu: Passing up the error state of mmu_alloc_shadow_roots() Date: Mon, 7 Mar 2022 10:20:06 +0100 Message-Id: <20220307091711.225991898@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091702.378509770@linuxfoundation.org> References: <20220307091702.378509770@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Like Xu commit c6c937d673aaa1d603f62f134e1ca9c173eeeed3 upstream. Just like on the optional mmu_alloc_direct_roots() path, once shadow path reaches "r = -EIO" somewhere, the caller needs to know the actual state in order to enter error handling and avoid something worse. Fixes: 4a38162ee9f1 ("KVM: MMU: load PDPTRs outside mmu_lock") Signed-off-by: Like Xu Reviewed-by: Sean Christopherson Message-Id: <20220301124941.48412-1-likexu@tencent.com> Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/kvm/mmu/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -3579,7 +3579,7 @@ set_root_pgd: out_unlock: write_unlock(&vcpu->kvm->mmu_lock); - return 0; + return r; } static int mmu_alloc_special_roots(struct kvm_vcpu *vcpu)