Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 13:14:31 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        tangmeng@uniontech.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v2] ASoC: amd: Fix an ignored error return from
 platform_get_irq_byname()
Message-ID: <YiYFN7TL8ZpnAM2d@sirena.org.uk>
References: <20220304004543.11797-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vKS5jss5k13JvKxY"
Content-Disposition: inline
In-Reply-To: <20220304004543.11797-1-yang.lee@linux.alibaba.com>
Precedence: bulk


--vKS5jss5k13JvKxY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Mar 04, 2022 at 08:45:43AM +0800, Yang Li wrote:
> The return from the call to platform_get_irq_byname() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'adata->i2s_irq', so assign the value to 'ret' concurrently
> to solve this problem without affecting other functions.

This doesn't apply against current code, please check and resend.

--vKS5jss5k13JvKxY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmImBTYACgkQJNaLcl1U
h9Ayawf/UAHZ/XEOH8Ig5XxzKsT6C8R6T0FSBLGJg3y7QBXcXluvNaQQs8kogFjZ
N4MyL9viPZ9zoWVptKZB3wgcJpFfzviuXKemILq0HqY2Vd0LL/79YxvLek/CJFS3
drf/lRSIafH0ZUBIkyhg+y6vf2YWDEJvIh2u/4DLhYGcMaPtq002I1iXg4ok9FMU
WlLWlT4k5y9n/Qhddm2Sq5d4zVCD9SgPf4Rmvi2wJH7xJOHrG6jwZ/dF61ok5SUQ
aqrcd1vDhpHLTAtPRSEIL0Zt0Q5WDdGgW2bBOyJANMeqwz7w93t8BJKrrRSNSpbL
3B1auFFO2XquDL01ePZWTm8Xtk351Q==
=dJZZ
-----END PGP SIGNATURE-----

--vKS5jss5k13JvKxY--