Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1937763pxp; Mon, 7 Mar 2022 05:31:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxWGf0zb8DHJIq+3X/Z1bDO2ljsbZKLkv38TS6pkXHnCBk66qk2dw26plZsvr+/ykA05ICK X-Received: by 2002:a17:907:60d5:b0:6da:a62d:1845 with SMTP id hv21-20020a17090760d500b006daa62d1845mr9365979ejc.154.1646659915460; Mon, 07 Mar 2022 05:31:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646659915; cv=none; d=google.com; s=arc-20160816; b=CPwwZjHLVpKYt6NvmUvoe1YXaCE3OQq+hwBh0Yu9HRKVJ4DNNUxW6Zr74NqR94t8x1 0I79hMZorelN32DDhW9yrBOWRLQxDl2KUqR2KkvAeeRHHwbPAkAY9hlC/NBH+ixXTbZP 3+87Rt6NgsaeJEzQS+NDjFTf+wIrlf5tR9lUZiByMXpeMItERKcGXyjE5HHGJ1O50lqA 3pjUD3qLlIJPvPbcYgqXVN8dl0AUxf0SVaSWUNpznZAAMxugqDcqrx03aldTAtz/nlCA 7NHoLlyqLCmRp49lTlkkn4qWXWD1URY/1mULsSdPKR7+aL098aoSRHR9yBk6gJKItb/9 eIsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6sN0on+TklJLiMkk+8nKplqKWkNGHVbTBnp3A9FH6r0=; b=UiKRWfHp0ySzW8+c6mzDgk/wL9fYPk4tMkccj+hOKJgwrm/FnHu4YK0rXj5xdyn8l0 9zjR5GQai98ik8ghAQ+go9MRbOVmNxGzxsF+bW+a0mZR4yTSFbZkxAW51/O+lZ2NJAOq tob+pbTuqsB7qfcQ+6OHx7AN/MU1PqVboYioicyU1eK2zVpC9SpXJR7KQk3eat4ykfe7 wERlDj+OR3OK8FT/5thrUc2tfYQiR/mcIJG68qwIGSLQp3csHC0JtcbCPOrn7SmzeK86 iuYMZ3bjYqQ4pbI0AaS/dUMfVqBrQeOt/0WZ1nGPtnTGEPFUn6eyfVQSb6zKdfKA1P/O uahA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=V9GNDxz5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j10-20020aa7c40a000000b00415f5c7700csi6220770edq.471.2022.03.07.05.31.28; Mon, 07 Mar 2022 05:31:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=V9GNDxz5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242488AbiCGMqF (ORCPT + 99 others); Mon, 7 Mar 2022 07:46:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242483AbiCGMqD (ORCPT ); Mon, 7 Mar 2022 07:46:03 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E56E44249E; Mon, 7 Mar 2022 04:45:08 -0800 (PST) Received: from mwalle01.kontron.local. (unknown [213.135.10.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id C308A2223A; Mon, 7 Mar 2022 13:45:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1646657107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6sN0on+TklJLiMkk+8nKplqKWkNGHVbTBnp3A9FH6r0=; b=V9GNDxz53Qy/kbVDQrLya7ZyUsj8qit4bW/2dpZNhwhl8ThqfQvk5HeErfeqB5zwl9H9L7 Zn3QGEnOIA2H9B8aVBU3hTcebp75B6aNj6t/9dZLT2wzvPjA/TtD0ub//nKM85mwglNL0z mxvmUcNoSRbye3XnKid8Tx7ITD6lWdU= From: Michael Walle To: horatiu.vultur@microchip.com Cc: andriy.shevchenko@linux.intel.com, colin.foster@in-advantage.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Walle Subject: Re: [PATCH v2 1/2] pinctrl: ocelot: Fix the pincfg resource. Date: Mon, 7 Mar 2022 13:45:01 +0100 Message-Id: <20220307124501.3487932-1-michael@walle.cc> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220304144432.3397621-2-horatiu.vultur@microchip.com> References: <20220304144432.3397621-2-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The pincfg resources are in the second memory resource. But the driver > still tries to access the first memory resource to get the pincfg. This > is wrong therefore fix to access the second memory resource. > > Reviewed-by: Colin Foster > Fixes: ad96111e658a95 ("pinctrl: ocelot: combine get resource and ioremap into single call") > Signed-off-by: Horatiu Vultur There is already this patch pending, which does exactly the same: https://lore.kernel.org/linux-gpio/20220216082020.981797-1-michael@walle.cc/ FWIW, there is also this one: https://lore.kernel.org/linux-gpio/20220216122727.1005041-1-michael@walle.cc/ -michael