Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1991979pxp; Mon, 7 Mar 2022 06:28:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQEgdXB6sKBxwroGU8aWZ6p3b9sJSHGC1F1DWNhAeCOpR5Qebs8fc0pgGJpyeSswB6Hn0l X-Received: by 2002:a17:906:c0c8:b0:6d0:562c:2894 with SMTP id bn8-20020a170906c0c800b006d0562c2894mr9357696ejb.625.1646663299662; Mon, 07 Mar 2022 06:28:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646663299; cv=none; d=google.com; s=arc-20160816; b=Vhrw1B5cyDPRe1h0Ra85vTslrEWtVQlMDrnjfFm1JBx2KVCLZjvVy1DMCd34ZK7eZU AapmLnrk1CTx4bT9fTIwrt3SipAA5MO21J6iu4WMtl2uWHWgO2M5VSvBCJ9ueoGKWbVc U5+8GRey7GteClvJMZVaV73UfAIzd9v4WN8p35OveZJDBX6TL3NvTwvOS6g8POFIQXmN lVeIDbNcd2XFx/NZPTSIP447uz2/d7kiX94ZVB9jn9AXyw42fsTH99fkLZJCBZm2vJDO gRjNF8NUjLfrtpLjoI0pUureKBeNwH7i/z55YtQRK8MO6LeYzXVHSM4uGRsjANHZ5N0n 89JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+XmXyDdzXTmYSkLqHU9R3AoYt+Mv+MfQmKLG3KLVNn4=; b=Qvn3pWSfVd5B+5tJPC4EZytdvcWhLXDXEbqifEOZq2RDOItxTFZXntx+Vo4kfO2q06 BKnJssxnlTlFwU1NSuRN0KeVAzGjWBnQCeH+OVfLfKw3yaWizaR+NBoOaDXFq29rThkH 7g/2Ts/Orje60LgArq7b6Md3t4J+Tnkh2c1eEBwpzK9nwIchrjMsm2vrD92muwrh8Tmw sqlut8khihTt08o/mxUfrrwUg6B7DMD2puhMqVaNnqCcRDAShRSELrFTOXkcnzwON3t1 bXK7K26sdBS/cqcfMC5DHoZP7QTvi7p5ii0lynZUqeZygzVnVF8fwLbGG3124n2QCJ8m HwIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=fhuR359c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw18-20020a170906479200b006da7d823fbcsi9346314ejc.558.2022.03.07.06.27.51; Mon, 07 Mar 2022 06:28:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=fhuR359c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240026AbiCGMGg (ORCPT + 99 others); Mon, 7 Mar 2022 07:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240802AbiCGMGb (ORCPT ); Mon, 7 Mar 2022 07:06:31 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 190187463E; Mon, 7 Mar 2022 04:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646654729; x=1678190729; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Iu9Y9l00LK8qD2HMPVyxqsR2snkJn5NMx606dNlvBmQ=; b=fhuR359caljnDEHR5jNl4GDieeiMGYDq03yWou/LEWEmHnIfSFffpSDL cUXkafczqzfoBrtlJmMtUhafNt5KQSaZJYVMIcckRSAudnpBQM3RGD6o1 OYLJlvMC2Bk4iFCk7HdxwrLtN6/+WZ3wL7jJgjQP0WebBOQmrQQE1ce2S HD/eO6IEbaWk8jzyXG0j42aMHNa2LWnmG/kBdkAadjvNQN8Ds5nRItI9W MvN6RrdNixnrIBoZwbkxebOhhri4z7H9pPofZDRkIKOrz8QtLxMWnKZDW NCvZ55CUHA8Txij0kMe1BsHgOOskVB5IXoPt6sPT0rOGkr31u0UaZTaaf g==; X-IronPort-AV: E=Sophos;i="5.90,162,1643698800"; d="scan'208";a="155940815" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 07 Mar 2022 05:05:29 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 7 Mar 2022 05:05:29 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Mon, 7 Mar 2022 05:05:26 -0700 From: Eugen Hristev To: , CC: , , , , , , Eugen Hristev Subject: [PATCH v7 05/13] media: atmel: atmel-sama5d2-isc: fix wrong mask in YUYV format check Date: Mon, 7 Mar 2022 14:04:15 +0200 Message-ID: <20220307120423.2427631-6-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220307120423.2427631-1-eugen.hristev@microchip.com> References: <20220307120423.2427631-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While this does not happen in production, this check should be done versus the mask, as checking with the YCYC value may not include some bits that may be set. Is it correct and safe to check the whole mask. Fixes: 123aaf816b95 ("media: atmel: atmel-sama5d2-isc: fix YUYV format") Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index c244682ea22f..025c3e8a7e95 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -291,7 +291,7 @@ static void isc_sama5d2_config_rlp(struct isc_device *isc) * Thus, if the YCYC mode is selected, replace it with the * sama5d2-compliant mode which is YYCC . */ - if ((rlp_mode & ISC_RLP_CFG_MODE_YCYC) == ISC_RLP_CFG_MODE_YCYC) { + if ((rlp_mode & ISC_RLP_CFG_MODE_MASK) == ISC_RLP_CFG_MODE_YCYC) { rlp_mode &= ~ISC_RLP_CFG_MODE_MASK; rlp_mode |= ISC_RLP_CFG_MODE_YYCC; } -- 2.25.1