Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220305123116.26828-1-yuehaibing@huawei.com> <860002a4-4e52-c399-fda6-054fa64df3ce@csgroup.eu>
In-Reply-To: <860002a4-4e52-c399-fda6-054fa64df3ce@csgroup.eu>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 7 Mar 2022 14:10:39 +0100
Message-ID: <CAK8P3a2p+Yryg1y5h=kTLP72WGYc2d4qctFuW+opR6F=1uYJPw@mail.gmail.com>
Subject: Re: [PATCH -next] powerpc/spufs: Fix build warning when CONFIG_PROC_FS=n
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     YueHaibing <yuehaibing@huawei.com>,
        "jk@ozlabs.org" <jk@ozlabs.org>, "arnd@arndb.de" <arnd@arndb.de>,
        "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        "paulus@samba.org" <paulus@samba.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Sun, Mar 6, 2022 at 9:04 PM Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
> Le 05/03/2022 à 13:31, YueHaibing a écrit :
> > arch/powerpc/platforms/cell/spufs/sched.c:1055:12: warning: ‘show_spu_loadavg’ defined but not used [-Wunused-function]
> >   static int show_spu_loadavg(struct seq_file *s, void *private)
> >              ^~~~~~~~~~~~~~~~
> >
> > Mark this as __maybe_unused to fix this.
>
> Marking it as __maybe_unused doesn't fix it. It just pushes the dust
> under the carpet.
>
> proc_create_single macro should be fix to avoid that warning.

We discussed that when proc_create_single() was introduced, but ended up
not doing it that way because there were already a lot of files using an #ifdef
around the function definitions. To change it back, one would have to audit
every user of proc_create_single() and remove the #ifdefs.

        Arnd