Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 19:26:11 +0900
From:   Jung Daehwan <dh10.jung@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        "open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Howard Yen <howardyen@google.com>,
        Jack Pham <jackp@codeaurora.org>,
        Puma Hsu <pumahsu@google.com>,
        "J . Avila" <elavila@google.com>,
        "chihhao . chen" <chihhao.chen@mediatek.com>, sc.suh@samsung.com,
        cpgs@samsung.com, cpgsproxy5@samsung.com
Subject: Re: [PATCH v1 4/4] usb: host: add xhci-exynos module
Message-ID: <1983025922.01646649181793.JavaMail.epsvc@epcpadp4>
MIME-Version: 1.0
In-Reply-To: <32e72657-a43d-0ae1-1bf2-d15b7426765f@kernel.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----CUqsqxLmMDErsaokmqc0SEMtAD8UUZAtQ-YfwGBggeHIq32N=_19fca8_"
References: <1646375038-72082-1-git-send-email-dh10.jung@samsung.com>
        <CGME20220304062618epcas2p2e3c73b5c4ed0c9bc0ca0c02aa658d3fb@epcas2p2.samsung.com>
        <1027007693.21646375582736.JavaMail.epsvc@epcpadp4>
        <32e72657-a43d-0ae1-1bf2-d15b7426765f@kernel.org>
Precedence: bulk

------CUqsqxLmMDErsaokmqc0SEMtAD8UUZAtQ-YfwGBggeHIq32N=_19fca8_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Mon, Mar 07, 2022 at 11:07:04AM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2022 07:23, Daehwan Jung wrote:
> > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> 
> +Cc Randy,
> I guess here is the rest of the patches.
> 
> > ---
> >  drivers/usb/host/xhci-exynos.c | 2025 ++++++++++++++++++++++++++++++++
> >  drivers/usb/host/xhci-exynos.h |  150 +++
> >  2 files changed, 2175 insertions(+)
> >  create mode 100644 drivers/usb/host/xhci-exynos.c
> >  create mode 100644 drivers/usb/host/xhci-exynos.h
> > 
> > diff --git a/drivers/usb/host/xhci-exynos.c b/drivers/usb/host/xhci-exynos.c
> > new file mode 100644
> > index 000000000000..3913c48d4b20
> > --- /dev/null
> > +++ b/drivers/usb/host/xhci-exynos.c
> > @@ -0,0 +1,2025 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * xhci-exynos.c - xHCI host controller driver platform Bus Glue for Exynos.
> > + *
> > + * Copyright (C) 2022 Samsung Electronics Incorporated - http://www.samsung.com
> > + * Author: Daehwan Jung <dh10.jung@samsung.com>
> > + *
> > + * A lot of code borrowed from the Linux xHCI driver.
> 
> > + */
> > +
> > +#include <linux/clk.h>
> > +#include <linux/dma-mapping.h>
> > +#include <linux/module.h>
> > +#include <linux/pci.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/usb/phy.h>
> > +#include <linux/slab.h>
> > +#include <linux/phy/phy.h>
> > +#include <linux/acpi.h>
> > +#include <linux/usb/of.h>
> > +#ifdef CONFIG_SND_EXYNOS_USB_AUDIO
> 
> This does not exist.
> 
> Please do not add dead code to Linux kernel.
> 
> > +#include "../../../sound/usb/exynos_usb_audio.h"
> > +#include <linux/types.h>
> > +#include "xhci-trace.h"
> > +#endif
> > +
> > +#include "../core/hub.h"
> > +#include "../core/phy.h"
> > +#include "xhci.h"
> > +#include "xhci-plat.h"
> > +#include "xhci-mvebu.h"
> > +#include "xhci-rcar.h"
> > +#include "../dwc3/dwc3-exynos.h"
> > +#include "../dwc3/exynos-otg.h"
> 
> No, how XHCI is related to dwc3? What if different block provides XHCI,
> not DWC3?
> 
> > +#include "xhci-exynos.h"
> > +#include <soc/samsung/exynos-cpupm.h>
> 
> This does not exist and does not even compile.
> 
> Please do not send code which does not compile... Also, just in case -
> do not send code which compiles but does not work. :)
> 

Hi Krzysztof

I'm sorry to confuse you. But, it's just for reference module to introduce
new feature. That's why I just submitted source code and header without
makefile. It's not going to compiled at all now.

Best Regards,
Jung Deahwan

> 
> Best regards,
> Krzysztof
> 

------CUqsqxLmMDErsaokmqc0SEMtAD8UUZAtQ-YfwGBggeHIq32N=_19fca8_
Content-Type: text/plain; charset="utf-8"


------CUqsqxLmMDErsaokmqc0SEMtAD8UUZAtQ-YfwGBggeHIq32N=_19fca8_--