Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030452AbXBTVph (ORCPT ); Tue, 20 Feb 2007 16:45:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030455AbXBTVph (ORCPT ); Tue, 20 Feb 2007 16:45:37 -0500 Received: from an-out-0708.google.com ([209.85.132.251]:37842 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030452AbXBTVpg (ORCPT ); Tue, 20 Feb 2007 16:45:36 -0500 Message-ID: <5640c7e00702201345n409d5c4btf978610541f866c2@mail.gmail.com> Date: Wed, 21 Feb 2007 10:45:35 +1300 From: "Ian McDonald" To: "Tejun Heo" Subject: Re: [PATCH] pci: allow multiple calls to pcim_pin_device() Cc: "Bartlomiej Zolnierkiewicz" , gregkh@suse.de, "Linux Kernel Mailing List" , "Jeff Garzik" In-Reply-To: <20070220082839.GN1625@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <5640c7e00702181153q44678861q9963e7e2de00be8@mail.gmail.com> <200702182158.13429.bzolnier@gmail.com> <5640c7e00702182000p26f1ca8n15c1edcd8b3134a1@mail.gmail.com> <200702191247.03274.bzolnier@gmail.com> <20070220082839.GN1625@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 27 On 2/20/07, Tejun Heo wrote: > Sanity check in pcim_pin_device() was too restrictive in that it > didn't allow multiple calls to the function, which is against the > devres philosohpy of fire-and-forget. Track pinned status separately > and allow pinning multiple times. > > Signed-off-by: Tejun Heo > --- > It was an actual bug in pcim_pin_device() implementation. Thanks for > spotting this. :-) > > Ian McDonald, please verify your warning goes away with this patch. Yes it does. Thanks for sorting. > > Greg, please forward this patch upstream once Ian acks it. > Acked-by: Ian McDonald -- Web: http://wand.net.nz/~iam4 Blog: http://iansblog.jandi.co.nz WAND Network Research Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/