Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2206290pxp; Mon, 7 Mar 2022 10:22:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWFghu1Hd1Z86lqbqxMgKhxCJfUyAa3oK4Ec9P48EMy8pvyh0654RuvUPT7SHsWRdDy9Hd X-Received: by 2002:a17:907:7e9c:b0:6db:4788:66ab with SMTP id qb28-20020a1709077e9c00b006db478866abmr159807ejc.112.1646677328786; Mon, 07 Mar 2022 10:22:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646677328; cv=none; d=google.com; s=arc-20160816; b=xLfIlAyguWRWNYVprWxK59nzh6/1Fbg6tcOOdiZYrEfuk3XmOvAeQ4BGS4qRnid1FM 0TgNlCoGU4JmQcM6H+WXpI8xBn7wTMTosNg6DFbDdix8xNR3fMSvxDen6owXy5sIlJST d9siMIZWseeX32NubX8qMPpscL7TX8CYroUYGNDPyI1QHwMQlCegbHTR7+eMfmSiepBY +xvnf22Knnv59JsBGxwyeCrZ9INBgwiK7KYHGcJ48+alOH2t8n7750sILJwUvF1kErDr F6RkYikb5VcOgK9U7w6D2u2m9ZDtvvuSnkkGuq405w1CP4cEf79VNjguqeqX8LapCu5A eoUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=mymk5npP1Kz876/T9++fWFjLoWMlML7Y9nz0ahfHwss=; b=j4+1x8NbiVaX3LtFiRcM/LyslRuS+SrbVDf5z+itd2RyDomFhpnBSCuQp2XZVNs4KE EY4UY9WfB3S1beivNkm22vwhrxFipk16b+z3SYetuyw+9UTFKLexuJE8Z9NE+yJcexcf JWFR2jJ64ltbyC8BFHNBWJfwYZU1IkkPyzk+YuF4wzgJKRLBciybbEQcRzBDytYwIOtm brn/mLHC0Tqhyl63x9V8D3JsF+rnCI5VVZrwCf3BLgs/nENkVkNrsa+ynkT65U5zbb3S XOH25RUOsvAbT2+22JGi/pRjdxKpvhK+kBin/7XsN1/rWMF8cLDQorRtjTfTa9+zEp6E sveA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kz2-20020a17090777c200b006d0adc95b44si8368009ejc.525.2022.03.07.10.21.45; Mon, 07 Mar 2022 10:22:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242505AbiCGMsR (ORCPT + 99 others); Mon, 7 Mar 2022 07:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242507AbiCGMrx (ORCPT ); Mon, 7 Mar 2022 07:47:53 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09A4288793; Mon, 7 Mar 2022 04:46:58 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nRClI-0006ca-29; Mon, 07 Mar 2022 13:46:52 +0100 Date: Mon, 7 Mar 2022 13:46:52 +0100 From: Florian Westphal To: trix@redhat.com Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conditionally use ct and ctinfo Message-ID: <20220307124652.GB21350@breakpoint.cc> References: <20220305180853.696640-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220305180853.696640-1-trix@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org trix@redhat.com wrote: > From: Tom Rix > > The setting ct and ctinfo are controlled by > CONF_NF_CONNTRACK. So their use should also > be controlled. Any reason for this change? We try to avoid ifdef where possible, unless it avoids a compiler warning/build/linker issue. This doesn't change generated code for me (NF_CONNTRACK=n) either.