Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5192817a-ed77-50c9-7bca-86d85b4b91dd@suse.cz>
Date:   Mon, 7 Mar 2022 18:11:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] mm/slub: helper macro __ATTR_XX to make code more clear
Content-Language: en-US
To:     David Rientjes <rientjes@google.com>,
        Lianjie Zhang <zhanglianjie@uniontech.com>
Cc:     Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Roman Gushchin <roman.gushchin@linux.dev>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20220306073818.15089-1-zhanglianjie@uniontech.com>
 <88c427-faec-ba5f-4ed4-bc2dd0873ec0@google.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <88c427-faec-ba5f-4ed4-bc2dd0873ec0@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/6/22 23:11, David Rientjes wrote:
> On Sun, 6 Mar 2022, Lianjie Zhang wrote:
> 
>> Signed-off-by: Lianjie Zhang <zhanglianjie@uniontech.com>
> 
> And VERIFY_OCTAL_PERMISSIONS() can help validate any future change.
> 
> Acked-by: David Rientjes <rientjes@google.com>

Ok, adding with adjusted subject and non-empty message:

    mm/slub: use helper macro __ATTR_XX_MODE for SLAB_ATTR(_RO)
    
    This allows more concise code, and VERIFY_OCTAL_PERMISSIONS() can help
    validate any future change.