Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ea285d28-1b96-984a-b033-4c539c653d11@gmx.de>
Date:   Mon, 7 Mar 2022 14:25:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] omapfb: Add missing of_node_put() in dvic_probe_of
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>, Rob Clark <robdclark@gmail.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Dave Airlie <airlied@gmail.com>, linux-omap@vger.kernel.org,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220307123816.31888-1-linmq006@gmail.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20220307123816.31888-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 3/7/22 13:38, Miaoqian Lin wrote:
> The device_node pointer is returned by of_parse_phandle()  with refcount
> incremented. We should use of_node_put() on it when done.
>
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

applied to the fbdev for-next tree.
Thanks!
Helge

> ---
>  drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c b=
/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> index 2fa436475b40..c8ad3ef42bd3 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
> @@ -246,6 +246,7 @@ static int dvic_probe_of(struct platform_device *pde=
v)
>  	adapter_node =3D of_parse_phandle(node, "ddc-i2c-bus", 0);
>  	if (adapter_node) {
>  		adapter =3D of_get_i2c_adapter_by_node(adapter_node);
> +		of_node_put(adapter_node);
>  		if (adapter =3D=3D NULL) {
>  			dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n");
>  			omap_dss_put_device(ddata->in);