Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eff85326-9c0b-f470-3741-803018aa2619@amd.com>
Date:   Mon, 7 Mar 2022 17:14:32 +0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [RFC PATCH 10/13] KVM: SVM: Adding support for configuring x2APIC
 MSRs interception
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org,
        jon.grimm@amd.com, wei.huang2@amd.com, terry.bowman@amd.com
References: <20220221021922.733373-1-suravee.suthikulpanit@amd.com>
 <20220221021922.733373-11-suravee.suthikulpanit@amd.com>
 <70922149247cfe2bfd59d27d45bbf5d0966c2dcd.camel@redhat.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <70922149247cfe2bfd59d27d45bbf5d0966c2dcd.camel@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnovRjRxZ3RtZURNUnZOdFBxdVNsbG9SZUxwR2RDMXhMWjh3cC9vcW4wMklt?=
 =?utf-8?B?MUlSaVRTdUt5VnV4b04rVFZlVzN4eFNDMHNJMHlOdjFmRE9OQUIxa0d5QlRK?=
 =?utf-8?B?RWo1dGZZMjF4d0dadUpPSFlLTXVHLzh0bnRQS2cyVmY3R3UwS2twOHFlWlh5?=
 =?utf-8?B?VnArR3NRZmNCQklEQ3RFc2NjOGR3YUs3MWI3TnZWRHl2eEl6K3UzYlVRb1ds?=
 =?utf-8?B?M1o0RjJESitsWmp0SnNlS3BNOXo5ZXN3OHVXQTducnNpZS9ldFRTcU0zRGkw?=
 =?utf-8?B?SmgrUVRrS2FJNjdGZWw4anNVT05EcU8rZXVIVWp6Y0REL0E0ZnNnd09NZVN4?=
 =?utf-8?B?cGFXcWlXTUF0YkJ0RXBKM1k0QmtOZWt4Vi9la1FteCtTUVEzN2ZLUk5wVUNH?=
 =?utf-8?B?a1lqY2ROOXc0d3NUZTZURFZkY3FiUFVTV0Q2clM2NHQ0aVJkKzh1VHo3MFpt?=
 =?utf-8?B?STBUc3dSditjYzc4ZUR5WkdpTjJjQWYvUWw5U1pmZzdLRXg0OWJDeXpjWEd4?=
 =?utf-8?B?Qzl2cXpwM1NHNWsydXlGc092b0xObklLWjQ4L1NKTm0vRmd0VE80YjlFUHVL?=
 =?utf-8?B?eDFsRWxjYzBESGF5eFl4SGdVRFVJc0hyaWZQVzFRYlJiZ3lxUFJvT0pVekdx?=
 =?utf-8?B?ODRhaEZCQnJvTnc5WmNXT3BKVFo3SmpkN2kyanNzTmg0dGNIcnZxOHNLVUha?=
 =?utf-8?B?em5NSDZQajdXRndFTmd2TEtRYkdOalNsNFUwcXZieDVnam1QSnFicWVSa0hX?=
 =?utf-8?B?ZG04Vjd5UjRLc3l4T1diOEdSRVd4blVPQzNWVEZMSm1wMEpEMjFxLzZZd2x4?=
 =?utf-8?B?N3dOK0JTYndkdGNFbkUwbGNaMWVnS09aNS9rOEVxMmJxUVdLWEh4VkpMWDJj?=
 =?utf-8?B?MjZWNit0NFBNV3RCekdnZG4waE9YSHZwVlhuWC96eXVsRm82Z0I0cmZSNUo2?=
 =?utf-8?B?ejF4N2o1amFmYnJ4SU81Zm1pV21TdXdORkpJbDh2WktyTUtka2hoYm5HQ0Jt?=
 =?utf-8?B?RDRMbG9FQWpsVXR5RUtaNGFKN3M3TmFlaXAwdmwrK2d0MmpxY0o0bFFQa202?=
 =?utf-8?B?ZmhIa1RLRG5MYVJqYzVRLy83SHQycU9Sb0lPazZ6Qjh0bUpzZ2pSSjl2a3Z4?=
 =?utf-8?B?U0QyL01kRnFyR2ZjRWVyeEdReFlFYVVHVmpnTjlDekFpVk5aMUdqK2lmOEtN?=
 =?utf-8?B?Z2p2MHhQS3J0akVISVVVRGFyNnYrS2wxYlFSN1ZUYmhXZi92MURpdkUwanBF?=
 =?utf-8?B?aUFORzk2dzR0SE1jQlBNcXRYMkdEeDBMZ0V4U0NyNS9tTUNqZkpYcXdYeTNa?=
 =?utf-8?B?dWhCOTJmS21LTWZWVHRDQ1FYSFgzNTBNMzBVVjRyY3RjNk81Zk9IZ1ZRUHZ2?=
 =?utf-8?B?NU4zRWpYSytiYndhaGFiQjZmTmlpY2ljUWlXMi8rQmFiVTZldzVKeWYvcTVQ?=
 =?utf-8?B?MWNGNlFYWVJ3Y3k0eEhaaFFmRllKZW83cEtSMmQrOTJySmdTY1Z5TFBaZWRa?=
 =?utf-8?B?M0FzRFdrdlp6R2lqZStsZXlPUW1FWWJGTFhXN0l4MkJtMEc0VFRSS0Q3Wm9h?=
 =?utf-8?B?aGtZZUNLRGZCMmpLbURpM0dqL2Jjeml4dXFad0ZaUDZFRHgyTFFtVHNxTC9k?=
 =?utf-8?B?NXN1NjdNVnNFTDhERlA0MGtUeGVHakpuanBBbVR0RURFQWpZQS9QeVpEZlJS?=
 =?utf-8?B?ZjB5U1E0bFlNZTJsTWFMOVc0clFJNWU0TllFTVlIYjNxdVpaL2p1aG0rakFm?=
 =?utf-8?B?STJPcyt1ZmFqaVp4MjVTbzRRYXdHdzFPSjZ0aHk1R2hvQU9vZ1FkN2FLMFVr?=
 =?utf-8?B?S1hEYzF0L2hIbC9MNUN0dHVmVGx1S1ZLUDhsYzVxeHl2TVBQd3ZibkpIWVMr?=
 =?utf-8?B?eHB4Q3ovbnZXYW1jOE9HcGRLcDJ3aTVWK2hrS2dqK3EzNkdxVlFiaG1NWTNX?=
 =?utf-8?B?R3pwRnlZSlZodURQeFI5alVpbjY2YlJUTVV0QkRKdU1XVFVZdGV6U2pWdHor?=
 =?utf-8?B?cFpOM1B1S1BYVVpra3dhaVcxZlE1WC9KR0dENWFKMVdJRGhJdE5XaGsrNnJS?=
 =?utf-8?B?LzQ3eVRVb0tJZWhZdEVRdjZuaHRQVGVBakYyUnhKMkVOeDJkVEd0MUEyTGJJ?=
 =?utf-8?B?ZjNINGZMa1NVTHR3SGFINC9pOUlMMlRlTnNxelhPcUVXaGRuVEtKUW5wRnR1?=
 =?utf-8?Q?p9RlxbZ5aqm4uJMnt8F3cW0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46c84534-2326-4b86-751c-08da00234bb1
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 10:14:42.6541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b1cUTsBU3gwteT/iH7XFWdqf6Mtp4eV5y+eQqWt7MMVFmmhx88tze/qp3M0ee6woMPG2Gyk3WihSVzUTRFITIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4633
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Maxim,

On 2/25/2022 2:51 AM, Maxim Levitsky wrote:
> On Sun, 2022-02-20 at 20:19 -0600, Suravee Suthikulpanit wrote:
> 
> I only gave this a cursory look, the whole thing is a bit ugly (not your fault),
> I feel like it should be refactored a bit.

I agree. I am not sure how to make it more friendly. Any suggestions on the refactoring?

Regards,
Suravee