Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alifer Moraes <alifer.m@variscite.com>
To:     linux-kernel@vger.kernel.org
Cc:     brgl@bgdev.pl, eran.m@variscite.com, linus.walleij@linaro.org,
        linux-gpio@vger.kernel.org, pierluigi.p@variscite.com,
        FrancescoFerraro <francesco.f@variscite.com>,
        Alifer Moraes <alifer.m@variscite.com>
Subject: [PATCH] driver: pca953x: avoid error message when resuming
Date:   Mon,  7 Mar 2022 11:19:55 -0300
Message-Id: <20220307141955.28040-1-alifer.m@variscite.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7pO0uLBSmA2D+fYeBV4xtZgBnc+MqD2rz0CQz3/C/Pz2G+CSJzt61mJ08Zo/?=
 =?us-ascii?Q?RXpvxE0E4qu53cQwI+mJmjdnjVH/rpMDuscoNdJgwlku5HJcAYZTmjAcFh44?=
 =?us-ascii?Q?JL7VYgWeDKO5sD5Y0cDq1MMGnsyulJTh86eftD9ftLmK4slACcQ8KZ/18MpG?=
 =?us-ascii?Q?YDfB1efI6uBNF9cOIzVBiqxZGJLm9s2215NZTGnCkDvOsv07ciHRarZrfGMZ?=
 =?us-ascii?Q?d5tmcIGl/l3QiYqF78ndbCDDjeJlMSFRzs0ZQV/qsqiRzGJWSJCxpyeS6sxw?=
 =?us-ascii?Q?9IfPJlgzYIxvvBZKM0TNHx6dWqjc3XWCjDPPTQ25S8v2ocyrFyTO3sA3wHS4?=
 =?us-ascii?Q?MVWFPbKUcswNq1OcV7g2CJtfWNgvLga7Myd8C//DuEGU3SW/R6guuJivG2Kb?=
 =?us-ascii?Q?4PUvcsmFq2GTshBuRAKwhE+9YTF3f7HQmTOIKPfmFR2f+N0uAr7y4k1sD8Ng?=
 =?us-ascii?Q?inri3Yh4ZeZ2LCsi4f2JMCwKpanOgbpqCTd/50KgMpN6/UglylW+ketWoiy+?=
 =?us-ascii?Q?ftw5dxZwuX0PjJlI0ZyMmQk3m4AB4C87BSt2N8H2VMxSengOVFf/rXdHB0uV?=
 =?us-ascii?Q?T8qQuBLt94qUPACIRBRZ6bXHMGLg9L537ifLQa51CUNWIbv5TuInQDxYaiIF?=
 =?us-ascii?Q?XU2Hu3p50QHSMBB057Dr8//4C3+YlVtkCbUwkEmxhDbUE6Cq1/EEqOjT1Whc?=
 =?us-ascii?Q?h4+pHkzyVTi4WfQ8CzKhk3poCAI76UnOxvk88d1t0HPT3rRKqQoklS2WJWfL?=
 =?us-ascii?Q?vI/CwRc6ao/U//3JWRRQ5A6y434+ynMM+Ma9ywC8JT/46FsIyjmBxJBiHThM?=
 =?us-ascii?Q?6pjIWfbAzPQfXtyDlVT0Mm7EMJknSYjff4sUWEcL01SPPN+EPtu6CRufSB2M?=
 =?us-ascii?Q?cH01eqdD76NhxBpm6W8RK6DNWJZ7fUQOpoFkZ3mAHvRtMPj2zB9Xkn6GFckH?=
 =?us-ascii?Q?OxchYux/CLrhLyIj32YqdaVGXiTrNyLZQddvcZYSvefQOZf1ukrE6Id3UPf/?=
 =?us-ascii?Q?uojhjjZ9y0WHVi/tTg9q3kDf/FgNCZNu+/HI/oXAJnWP9lByLUMCWoN4lTGU?=
 =?us-ascii?Q?VlPtkmBDQsBGIjAR8mO79s8zn31tcTlAmiXO+rb3AAPHpt4gghU05yvU7klb?=
 =?us-ascii?Q?osksNJZOyIknFz/84TgyRdrlZDN3AcFXVu6+cwwseZHfZICVX641Vto8JYrA?=
 =?us-ascii?Q?gNoz8c6fH1FiFU5g7Kj3bpebiviEB67IzjeN0WHfGaH8B3XrDOj1D0LJ7Fe4?=
 =?us-ascii?Q?rgnNPGbHakSeW//kyw43kOOI+sNcjhVmOffZ6uhX8JaU6U9oZlPOoo2ybA3T?=
 =?us-ascii?Q?yaivC+1osoKntFSm0IQUcgSCXnr6sxRH7QnrZp/LsPjlBuMlyPc7zV3ozBl2?=
 =?us-ascii?Q?R7KJK16jrAJANRHLzTYhTIaKsFdFyVQ2976vnmbDHQBcNymaervvI3vKtHLN?=
 =?us-ascii?Q?bXQcvLQqaKu/QHNflO24a1kwGryE2lbp2Z5K3RTxEoE6+zv8mzPnZwbKlZHh?=
 =?us-ascii?Q?cqdxhO7fDTQjhDJNuuQblVCZjDtSKqHwzF+o4X3dFKlAHertGLjEZCcgmPU2?=
 =?us-ascii?Q?Ydnmdy+qg/QH9TomCw+skx0N5tZIrzMNFSQlJeHrCOc/qGcCe3wIhIrv5lUV?=
 =?us-ascii?Q?+BDJyeNs4e/iKanvNW/i4pM=3D?=
X-OriginatorOrg: variscite.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 268d47db-3ba7-44a3-a526-08da00459898
X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB6999.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 14:20:14.0167
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 399ae6ac-38f4-4ef0-94a8-440b0ad581de
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w34X+bV9dDlY9EP1zM76esqvWSygmgTc5tHww9YF3pe9mLjBclVJsbchbO4Q1aGFCZ+5K+OwwGM9QZEYZYcpsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2638
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: FrancescoFerraro <francesco.f@variscite.com>

Avoids the error messages "pca953x 1-0020: failed reading register"
when resuming from suspend using gpio-key attached to pca9534.

Signed-off-by: Francesco Ferraro <francesco.f@variscite.com>
Signed-off-by: Alifer Moraes <alifer.m@variscite.com>
---
 drivers/gpio/gpio-pca953x.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index d2fe76f3f34f..4f35b75dcbb1 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -211,6 +211,7 @@ struct pca953x_chip {
 	struct regulator *regulator;
 
 	const struct pca953x_reg_config *regs;
+	int is_in_suspend;
 };
 
 static int pca953x_bank_shift(struct pca953x_chip *chip)
@@ -412,7 +413,8 @@ static int pca953x_read_regs(struct pca953x_chip *chip, int reg, unsigned long *
 
 	ret = regmap_bulk_read(chip->regmap, regaddr, value, NBANK(chip));
 	if (ret < 0) {
-		dev_err(&chip->client->dev, "failed reading register\n");
+		if (!chip->is_in_suspend)
+			dev_err(&chip->client->dev, "failed reading register\n");
 		return ret;
 	}
 
@@ -954,6 +956,7 @@ static int pca953x_probe(struct i2c_client *client,
 	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
 	if (chip == NULL)
 		return -ENOMEM;
+	chip->is_in_suspend = 0;
 
 	pdata = dev_get_platdata(&client->dev);
 	if (pdata) {
@@ -1161,6 +1164,8 @@ static int pca953x_suspend(struct device *dev)
 	else
 		regulator_disable(chip->regulator);
 
+	chip->is_in_suspend = 1;
+
 	return 0;
 }
 
@@ -1189,6 +1194,8 @@ static int pca953x_resume(struct device *dev)
 		return ret;
 	}
 
+	chip->is_in_suspend = 0;
+
 	return 0;
 }
 #endif
-- 
2.25.1