Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2313430pxp; Mon, 7 Mar 2022 12:39:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7j8QcaIS8sfHaUWFABLiUesCOErhq8O0spN3SrGWtQXWayL05qj0AqISNEZFBzVotLhOm X-Received: by 2002:a17:906:544d:b0:6db:3816:c513 with SMTP id d13-20020a170906544d00b006db3816c513mr3526460ejp.664.1646685592078; Mon, 07 Mar 2022 12:39:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646685592; cv=none; d=google.com; s=arc-20160816; b=AFnmAdOCvJAJcaKbe8djvIkzaqNj+V87MWZh4frkbFqV/62iiJqFuu3D28Dr741UFl h9Kou+8PTHwKNIWS8ruCnBTtPsDRXE/dv5u+lKLF6gnzj1FY6kvBMo1LI1SJ2laJSzcD h0muiyfc6J1qrfU14LbX+izrx5jYr7Eibd28oVlAr18MoFx2Y4B5xeCAIoIfcry2gbCW 5v8x5uBYMQfqtviJV49cd9kOJjlDx8fAixk8wkjJycvEsxSOeeOCcARfqN6nD3lXYQK1 b/19yWzgtdkDX5phDY5F3SLGfwzYBNSWRVexUWtiPmPwFkLyrGtCaW5287cW+CNUmTg+ A2Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TI07Pl1HeICc5q5e6k4VbQ9XbzeOE7TWGWnH+wJ3TaQ=; b=CeRa1j1d9YubTrTTma83csjlivJx7T7ll3wI2lVAQqZgilASY6KUGrtXuPGA/1h4u0 +oxuoGqYUihxa80sE6xDUbWS5bdXBw8ltbiQjHrkuivLN+mIlr7cx6XSm2K6qLg5KPKe ZcP+UuyVESm/LwsGb2a2BYrkeGHDUUkQxumb/JQDCJCxH4WrhBFGqEe3FXjdUV9P5fDB Ugd+ssWSvFUfD5SxA0+KK3mCrnsR05pFTH2RVdUwcZm9uUiMNUmpFlXAub4yj7qGJn+t y8bnrWL3Ok+zM6qf2h11nNtr9JEtrdGEa2D2QCH+EYv0bGSZ0ffkbLoRjJ5X+ezJ1W8o NPTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Tz4t20gW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w16-20020a170906185000b006d1395b71d0si8176461eje.114.2022.03.07.12.39.29; Mon, 07 Mar 2022 12:39:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Tz4t20gW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236713AbiCGKRk (ORCPT + 99 others); Mon, 7 Mar 2022 05:17:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240453AbiCGKBC (ORCPT ); Mon, 7 Mar 2022 05:01:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57F23100F; Mon, 7 Mar 2022 01:48:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0C759B8102B; Mon, 7 Mar 2022 09:48:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53089C340E9; Mon, 7 Mar 2022 09:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646492; bh=UFQkcjIuOWuMxxAzs6ek4vVO/KWNVmlBh8B5nOfECCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tz4t20gW12v+t7I6NhFnEV8DMvyr3UJ124II4xP/3nnVegdhVf6BppvNtADyB/WJ5 3R+L0hrRi9tmzFqEY7H1IljbgJYLafgbWE0a17wirzmT8z/1Ksq4mKtv8GyP+ySUh9 1ijx+nhb8ntokMhfThTIEUQtWCeG6A+ED5tJhcdk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sukadev Bhattiprolu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.15 220/262] ibmvnic: complete init_done on transport events Date: Mon, 7 Mar 2022 10:19:24 +0100 Message-Id: <20220307091709.246203199@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091702.378509770@linuxfoundation.org> References: <20220307091702.378509770@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sukadev Bhattiprolu [ Upstream commit 36491f2df9ad2501e5a4ec25d3d95d72bafd2781 ] If we get a transport event, set the error and mark the init as complete so the attempt to send crq-init or login fail sooner rather than wait for the timeout. Fixes: bbd669a868bb ("ibmvnic: Fix completion structure initialization") Signed-off-by: Sukadev Bhattiprolu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 088c764fe3cd..404921418f42 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -5178,6 +5178,13 @@ static void ibmvnic_handle_crq(union ibmvnic_crq *crq, adapter->fw_done_rc = -EIO; complete(&adapter->fw_done); } + + /* if we got here during crq-init, retry crq-init */ + if (!completion_done(&adapter->init_done)) { + adapter->init_done_rc = -EAGAIN; + complete(&adapter->init_done); + } + if (!completion_done(&adapter->stats_done)) complete(&adapter->stats_done); if (test_bit(0, &adapter->resetting)) -- 2.34.1