Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2322968pxp; Mon, 7 Mar 2022 12:53:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwU+PLeAId/IyUGgnTod4N7cYXD9ElchColMWi13x5qe6VeC0J8GKns9wEl+nkXUbidppFa X-Received: by 2002:a17:90a:7147:b0:1bd:24ac:13bd with SMTP id g7-20020a17090a714700b001bd24ac13bdmr928257pjs.70.1646686422540; Mon, 07 Mar 2022 12:53:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646686422; cv=none; d=google.com; s=arc-20160816; b=d7bC30X94dKzawMeiqcHLGfY8eBlZmur6vZLL+pUaHqFGn4bBtAtUn0ObAy8foyhuz a8wleu0TY7wnddr0FLpvXFxZNMV5vF0CDJL8i3iIzCGpSK+FizkJY7RIiUY2jmplEGqJ 9AiSr9hhd99wSbe/WIq/hsfIbksABilrFxJaR92USz7aFYzGKscZ2X/s7E2igZ7nE9nU 6kdzyJX1wi8oxn9oCZ8wUKsAE2Cu1IbCKFJXZurqvLwb/VkiJCVfgCyysjhP2sNnv4Oa UZ+2HVaGLVgkU73J37J11bn5YrsBWFSQYdR5k9NUAW+cHiBrVK5w2tdGCAWnlF3rMgUD Fe8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HgPkTeQlQ9yBWzpmMdXBiILEKVRh8IBH8tmWr1tLglY=; b=Br/jDJFjP0YQkkbABRl+61tJOu37XfDPMhe6H7ei7apZkoJvJLo+GlnWrTIvmwE7L8 lrTZfwuUNZclJjSbknxuTEWck3f3KiHszar5/FBooqRVdwwtbHE6LMhc4GIFo/BPJnqQ JGZ8CmXvgbz7DiK0jMPAHQeXIhdTVHXgZYRskbhhWednyBPf3OLIKu7Kvy55dYfGvaGv BjrCSUR5l6qLyJtlhyumbH6p0UA0Em2fm7KO3dB2h9g/E9LyQEhIncmqIfTg3HKhbM1Z OvJPXz8ZT7I8Hgh1Qc0TnwU38YJvAmVV07gI6SgIY0RBuw2RqzoMZEGbMybjGtbhyFjV KsqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u15-20020a17090341cf00b00151bf44ba93si11505708ple.126.2022.03.07.12.53.25; Mon, 07 Mar 2022 12:53:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235805AbiCGUm0 (ORCPT + 99 others); Mon, 7 Mar 2022 15:42:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbiCGUmZ (ORCPT ); Mon, 7 Mar 2022 15:42:25 -0500 Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EFF87CDE5 for ; Mon, 7 Mar 2022 12:41:30 -0800 (PST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 3186C20021F; Mon, 7 Mar 2022 21:41:29 +0100 (CET) Received: from smtp.na-rdc02.nxp.com (usphx01srsp001v.us-phx01.nxp.com [134.27.49.11]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id EE2ED202391; Mon, 7 Mar 2022 21:41:28 +0100 (CET) Received: from right.am.freescale.net (right.am.freescale.net [10.81.116.142]) by usphx01srsp001v.us-phx01.nxp.com (Postfix) with ESMTP id 599E540591; Mon, 7 Mar 2022 13:41:28 -0700 (MST) From: Li Yang To: Krzysztof Kozlowski Cc: Li Yang , linux-kernel@vger.kernel.org Subject: [PATCH] memory: fsl_ifc: populate child nodes of buses and mfd devices Date: Mon, 7 Mar 2022 14:41:18 -0600 Message-Id: <20220307204118.19093-1-leoyang.li@nxp.com> X-Mailer: git-send-email 2.25.1.377.g2d2118b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 98f1323959b8 was trying to replace the "simple-bus" compatible with explicit bus populate in the driver. But of_platform_populate() only populates child nodes of ifc without populating child buses and child mfd devices residing under ifc. Change it to of_platform_default_populate() to fix the problem. Fixes: 98f1323959b8 ("memory: fsl_ifc: populate child devices without relying on simple-bus") Signed-off-by: Li Yang --- drivers/memory/fsl_ifc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c index 6e6de52bb82d..1604de863d41 100644 --- a/drivers/memory/fsl_ifc.c +++ b/drivers/memory/fsl_ifc.c @@ -290,8 +290,7 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev) } /* legacy dts may still use "simple-bus" compatible */ - ret = of_platform_populate(dev->dev.of_node, NULL, NULL, - &dev->dev); + ret = of_platform_default_populate(dev->dev.of_node, NULL, &dev->dev); if (ret) goto err_free_nandirq; -- 2.25.1