Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alifer Moraes <alifer.m@variscite.com>
To:     linux-kernel@vger.kernel.org
Cc:     devicetree@vger.kernel.org, dmitry.torokhov@gmail.com,
        eran.m@variscite.com, festevam@gmail.com, kernel@pengutronix.de,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-input@vger.kernel.org, pierluigi.p@variscite.com,
        robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org,
        u.kleine-koenig@pengutronix.de, mcontenti <marco.c@variscite.com>,
        Alifer Moraes <alifer.m@variscite.com>
Subject: [PATCH] input: keyboard: snvs_pwrkey: Add key-release-only
Date:   Mon,  7 Mar 2022 11:24:42 -0300
Message-Id: <20220307142442.28206-1-alifer.m@variscite.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n6z0C2nfG0Yub2BOKuxh8zsETglXjVNTaU6a83r+XzriMJwS7RmSyjvSWHh2?=
 =?us-ascii?Q?FD6nM9M/Uge6TmBZT4Tl4GqOnXhAgl9I8ddjCG5/fRIxxYpY/MF3fgQv/nk9?=
 =?us-ascii?Q?lpOcPFPesIDTspTzhCGyhh27yCEY6HVsQcTnXGyL/87BUTqV8p5n6zUfBfPv?=
 =?us-ascii?Q?xXaUSxEEmyqR+SjGCuC86yexd2NfADi3mxdMCJu5RiV8npLx3WuLr/pOTMTK?=
 =?us-ascii?Q?qEXBFaLr0tOL6oXWiXFuj+fzujmGVyTZmySptS9HLnd2HpEE8TK84t1vvK3T?=
 =?us-ascii?Q?9W0ggcdmE+WI2M3wzJ9fpAJjT5UzCDWGU5vLKsmwGoc34D5A5hgA1HshOBNY?=
 =?us-ascii?Q?dRi1+oouuGJ+Vk5mDrPmJier/NlAILCXRtvs3OHZNAbqf2Pu2EatgT2xELoX?=
 =?us-ascii?Q?7glhrAzaVC+H9dXxYqyfZlaB21R54wTea87p9oj3apMc2m22tR7fPs8FnWCf?=
 =?us-ascii?Q?lbMLKi34/e9MPqdWZH1xOZvhEsDe9EyPUuR51/+2zkhIlTLfEoKLO7ncIXpH?=
 =?us-ascii?Q?4PyhSO3qsxB2bswETibjsGQ1DELXnbLUQNBluih4aiD8GjpenPXEX4lpxygo?=
 =?us-ascii?Q?fmrUUy0Pxj9LMf9ikOW4fTDU+DSb3HIQ6yuA8+sND6kIH2Eq2bHgvGbl3OyR?=
 =?us-ascii?Q?BLoX34IfQeppe9l6w9BlCoHBFXLhd7cfc2ExWVNp3DYrGppxhEzPThHk/cRQ?=
 =?us-ascii?Q?6QyqoiZIHpkEW61oAltVfXjeRlihW7mgaBj1o2AuXs2+NuXgI61Ra5CygvOx?=
 =?us-ascii?Q?M4OXVfg9Kpw09B32d1za5JfuSr6qRDXVieJnU7zCB71MV3zqeP6lkfZM67XK?=
 =?us-ascii?Q?JWQx2HbE/RWTgJn3sCdr3sRSzKLAme+d6D1Hai7hGJxnf/4ev7hDpt0jdXjv?=
 =?us-ascii?Q?xam/aknkvN1cxp64hHYlfjGtCCMzi5xf31w8c6Sxg39OJd7XBjrb8NTy8dAz?=
 =?us-ascii?Q?+TP5ONzGR5cRICem3TDBS6jII8n0luKfNFFRRn4HdVp5mci8scpJ/lY3K2GD?=
 =?us-ascii?Q?yE+4Z7nuZqx8cxYsWalZPIlaEggLXqW7aIXrbjqMe2MPGDQv3EkUn4c5pEZ1?=
 =?us-ascii?Q?ZQWOJHoTj9bUg8iOlJC8GElLSDJyk9f4nvxgLX36bFNrWPjt4msNMbCfbYXK?=
 =?us-ascii?Q?zPpFrvxlc7IycYs8cZPiec+Wqnt/kMRajYoqrdZFrR1rgniSZ7EbZUq8FHeu?=
 =?us-ascii?Q?RUquym9WkFMTcIY8lleRqbTpzCzzTp7NeXFaHm/TtD/ieEWRrEMe+AkkzaWJ?=
 =?us-ascii?Q?aoaoiaU7sH4yLwtS/vJQ6qvIROdCIYyFqfVqqJHXmx3FVEiZ/PwgnhsLB4xP?=
 =?us-ascii?Q?ZdJ2zngYgvJx0mE81JHeUuZsyBvWFfVtclx/0jgj8c4Dao+1jsLryZPwgnB7?=
 =?us-ascii?Q?Px5ZgbU952nkjZE4IMdQzyFp/N2ntqEn3BVMi+FfV7EX3socurEHwyfyCqtC?=
 =?us-ascii?Q?zfbUpS1OHuG0rTJBvXxu+hRmow2GhL0ubgKoZ/WZN3s+/4xNUDW0+oI8DbYx?=
 =?us-ascii?Q?wfvoF0Lb6UM2hvOSz2eBe4iPdACWJAXHakT9BBeWrNMp2hqq4bEGp6ejcpUo?=
 =?us-ascii?Q?lIKEK9XjqgF3qSlqPGDUFyYXl22luxymniZFwZewXVjJTBMu6Tr4nPdbLnKA?=
 =?us-ascii?Q?hUEKHPptfobJDwKjFosirbo=3D?=
X-OriginatorOrg: variscite.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1455f8a-ddc6-4953-85c8-08da004643e5
X-MS-Exchange-CrossTenant-AuthSource: AM9PR08MB6999.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 14:25:01.4266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 399ae6ac-38f4-4ef0-94a8-440b0ad581de
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cRuEbOC/3UDulbzQnUfSKL/Od9OA4B+Byh5kLYpPo5p5RxrMWRujgMBzQjEqddXb6/ZYd6mzGUFkDBXJz7ayBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6065
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Eran Matityahu <eran.m@variscite.com>

On imx6qdl the interrupt only triggers on the release of the key.
Normally, the driver is looking for a change in the state of the key,
but since the interrupt triggers on release the key value is always 0,
so there was no event.

Add "key-release-only" boolean dts property to address this issue,
and create both key press and key release events when the key
is actually released.

Signed-off-by: Eran Matityahu <eran.m@variscite.com>
Signed-off-by: mcontenti <marco.c@variscite.com>
Signed-off-by: Alifer Moraes <alifer.m@variscite.com>
---
 arch/arm/boot/dts/imx6qdl.dtsi       |  1 +
 drivers/input/keyboard/snvs_pwrkey.c | 21 ++++++++++++++++++++-
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index d27beb47f9a3..9811e6bfd8e5 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -845,6 +845,7 @@ snvs_pwrkey: snvs-powerkey {
 					regmap = <&snvs>;
 					interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
 					linux,keycode = <KEY_POWER>;
+					key-release-only;
 					wakeup-source;
 					status = "disabled";
 				};
diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
index 65286762b02a..b558e6f898fa 100644
--- a/drivers/input/keyboard/snvs_pwrkey.c
+++ b/drivers/input/keyboard/snvs_pwrkey.c
@@ -66,6 +66,22 @@ static void imx_imx_snvs_check_for_events(struct timer_list *t)
 	}
 }
 
+static void imx_imx_snvs_check_for_release_events(struct timer_list *t)
+{
+	struct pwrkey_drv_data *pdata = from_timer(pdata, t, check_timer);
+	struct input_dev *input = pdata->input;
+	u32 state;
+
+	/* interrupt only reports release of key so do not wait for state change */
+	state = 1;
+	input_event(input, EV_KEY, pdata->keycode, state);
+	input_sync(input);
+
+	state = 0;
+	input_event(input, EV_KEY, pdata->keycode, state);
+	input_sync(input);
+}
+
 static irqreturn_t imx_snvs_pwrkey_interrupt(int irq, void *dev_id)
 {
 	struct platform_device *pdev = dev_id;
@@ -177,7 +193,10 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
 	/* clear the unexpected interrupt before driver ready */
 	regmap_write(pdata->snvs, SNVS_LPSR_REG, SNVS_LPSR_SPO);
 
-	timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events, 0);
+	if (of_property_read_bool(np, "key-release-only"))
+		timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_release_events, 0);
+	else
+		timer_setup(&pdata->check_timer, imx_imx_snvs_check_for_events, 0);
 
 	input = devm_input_allocate_device(&pdev->dev);
 	if (!input) {
-- 
2.25.1