Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 14:02:07 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: mc13xxx: Add check for mc13xxx_irq_request
Message-ID: <YiYQX/kxPHHSEDyx@google.com>
References: <20220224022331.3208275-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220224022331.3208275-1-jiasheng@iscas.ac.cn>
Precedence: bulk

On Thu, 24 Feb 2022, Jiasheng Jiang wrote:

> As the potential failure of the devm_request_threaded_irq(),
> it should be better to check the return value of the
> mc13xxx_irq_request() and return error if fails.
> 
> Fixes: 8e00593557c3 ("mfd: Add mc13892 support to mc13xxx")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
>  drivers/mfd/mc13xxx-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog