Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 16:36:27 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Alvin =?utf-8?Q?=C5=A0ipraga?= <alvin@pqrs.dk>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        =?utf-8?B?77+9aXByYWdh?= <alsi@bang-olufsen.dk>,
        linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] usb: typec: add TUSB320xA driver
Message-ID: <YiYYa7GkknJ+CAuL@kuha.fi.intel.com>
References: <20220301132010.115258-1-alvin@pqrs.dk>
 <20220301132010.115258-4-alvin@pqrs.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220301132010.115258-4-alvin@pqrs.dk>
Precedence: bulk

Hi,

On Tue, Mar 01, 2022 at 02:20:07PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> The TUSB320LA and TUSB320HA (or LAI, HAI) chips are I2C controlled
> non-PD Type-C port controllers. They support detection of cable
> orientation, port attachment state, and role, including Audio Accessory
> and Debug Accessory modes. Add a typec class driver for this family.
> 
> Note that there already exists an extcon driver for the TUSB320 (a
> slightly older revision that does not support setting role preference or
> disabling the CC state machine). This driver is loosely based on that
> one.

This looked mostly OK to me. There is one question below.

<snip>

> +static int tusb320xa_check_signature(struct tusb320xa *tusb)
> +{
> +	static const char sig[] = { '\0', 'T', 'U', 'S', 'B', '3', '2', '0' };
> +	unsigned int val;
> +	int i, ret;
> +
> +	mutex_lock(&tusb->lock);
> +
> +	for (i = 0; i < sizeof(sig); i++) {
> +		ret = regmap_read(tusb->regmap, sizeof(sig) - 1 - i, &val);
> +		if (ret)
> +			goto done;
> +
> +		if (val != sig[i]) {
> +			dev_err(tusb->dev, "signature mismatch!\n");
> +			ret = -ENODEV;
> +			goto done;
> +		}
> +	}
> +
> +done:
> +	mutex_unlock(&tusb->lock);
> +
> +	return ret;
> +}

Couldn't that be done with a single read?

        char sig[8];
        u64 val;

        strcpy(sig, "TUSB320")

        mutex_lock(&tusb->lock);

        ret = regmap_raw_read(tusb->regmap, 0, &val, sizeof(val));
        ...
        if (val != cpu_to_le64(*(u64 *)sig)) {
        ...

Something like that?

thanks,

-- 
heikki