Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2523504pxp; Mon, 7 Mar 2022 17:52:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJypGMgjSH8atO2mCwUnyTSCizvYlXD6ODOr4FhVuh5yCeXVc0Zmu4lFiSqnAkiQAnDkmfcV X-Received: by 2002:a05:6a00:890:b0:4f6:686e:a8a9 with SMTP id q16-20020a056a00089000b004f6686ea8a9mr15612262pfj.83.1646704329279; Mon, 07 Mar 2022 17:52:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646704329; cv=none; d=google.com; s=arc-20160816; b=O5nAzMMQ9PREDqNv+HbFAjyl7XdeWvNpD6/2wrxR/hxFykwE6jwOi7PrO/dmbD46Q3 3s/vSR4EWtmspigxPxi9Jv1lqrR87Bz75BfyZ9chEmELnjSiL6rVxfAwwwDyHP9Dw5jA TtDAEOMhET3pPvPM2lul7JORKPpwdd9H0OIJlEXMmwXZAXP4M/JGtH4BMzKeWozk3BKp RKWQpd+SQjy/hCxPXJQ0B8+RF2Y3qpX7sZKirQB5UcIH8KceAct+87HF9KFwFJ0PfaNw 2toERwPFdfOnM6okt8DxQXWIvv1583opjoAz0jvCovCGaCqzRAAyOzMYAyjgRFUMVeye iHZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3jq9BVcSqOjT5eJ7YaXlXy7xNo6YrnVDWpCoBS5wCL8=; b=C0evU1qf14620f6iig+sF88X2fognreEdz5oLa2tvESAp7JY6RW07+jPljk9CEAnS9 bw4RpA4d7TrVT9O0H0A5RqvJQ5AvISWwV3W65b/tLMw43wvWhto+F4YjWyCNIRGuIWl6 duiuiLZZnNNme8KM34J0fh4LP3d1vEII6yTz2Dx0nhJi1JpJXTsOswFNWPLHcb2JPgRg 3xZDY2kASnF3rJya7Jliv7u6Jy/VSO405KStXm2ngmqblU7+IGVftbeQpCREHEq5yLaW zVMM+3CFaijkBf1+JBzFcvJvWz4ZpbgeJddrU12drLZGBssJxid3GondrRjUW+R5eH/X 7faA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2BWEtnMr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u17-20020a634711000000b00373337d31c1si14210969pga.673.2022.03.07.17.51.50; Mon, 07 Mar 2022 17:52:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2BWEtnMr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241350AbiCGKjJ (ORCPT + 99 others); Mon, 7 Mar 2022 05:39:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239336AbiCGKPD (ORCPT ); Mon, 7 Mar 2022 05:15:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F067A9AE; Mon, 7 Mar 2022 01:57:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 78EEB60E8F; Mon, 7 Mar 2022 09:56:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80236C340F3; Mon, 7 Mar 2022 09:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646646986; bh=ZdNObHiYHnzSCAvNC2nWvjr0DzK6YzERh5u9K+IXs9U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2BWEtnMrptFPF/m3XbbPHcA3PdTDUBp6JVZVcYcLQV3iFkfhJUjOlpyuQV+CKw8k2 EiRralQeREDcdbKS/eAQ4q5sYL2FzIg2r3AXuVOqCp7VbECbL8bsTAMtglufZMdHhR 7gbAdPxAzovduPaaBAuWKTtqV9DHuUvqZl4/xt/g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Thierry Reding , Joerg Roedel Subject: [PATCH 5.16 105/186] iommu/tegra-smmu: Fix missing put_device() call in tegra_smmu_find Date: Mon, 7 Mar 2022 10:19:03 +0100 Message-Id: <20220307091657.015501227@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091654.092878898@linuxfoundation.org> References: <20220307091654.092878898@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin commit 9826e393e4a8c3df474e7f9eacd3087266f74005 upstream. The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: 765a9d1d02b2 ("iommu/tegra-smmu: Fix mc errors on tegra124-nyan") Signed-off-by: Miaoqian Lin Acked-by: Thierry Reding Link: https://lore.kernel.org/r/20220107080915.12686-1-linmq006@gmail.com Signed-off-by: Joerg Roedel Signed-off-by: Greg Kroah-Hartman --- drivers/iommu/tegra-smmu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -808,8 +808,10 @@ static struct tegra_smmu *tegra_smmu_fin return NULL; mc = platform_get_drvdata(pdev); - if (!mc) + if (!mc) { + put_device(&pdev->dev); return NULL; + } return mc->smmu; }