Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 16:25:47 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Alifer Moraes <alifer.m@variscite.com>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, eran.m@variscite.com,
        festevam@gmail.com, lgirdwood@gmail.com,
        linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com,
        patches@opensource.cirrus.com, perex@perex.cz,
        pierluigi.p@variscite.com, robh+dt@kernel.org,
        shengjiu.wang@gmail.com, tiwai@suse.com, Xiubo.Lee@gmail.com
Subject: Re: [PATCH 4/4] ASoC: wm8904: add DMIC support
Message-ID: <YiYyC1MVd+oCMU4x@sirena.org.uk>
References: <20220307141041.27538-1-alifer.m@variscite.com>
 <20220307141041.27538-4-alifer.m@variscite.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1iwP804p5/iDUb1W"
Content-Disposition: inline
In-Reply-To: <20220307141041.27538-4-alifer.m@variscite.com>
Precedence: bulk


--1iwP804p5/iDUb1W
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 07, 2022 at 11:10:41AM -0300, Alifer Moraes wrote:

> +static const char *cin_text[] = {
> +	"ADC", "DMIC"
> +};
> +
> +static SOC_ENUM_SINGLE_DECL(cin_enum,
> +			    WM8904_DIGITAL_MICROPHONE_0, 12, cin_text);

Why would this be runtime selectable?  I'd expect the decision to use
an analogue or digital microphone to be made in the hardware design.

--1iwP804p5/iDUb1W
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmImMgoACgkQJNaLcl1U
h9CVtwf+Nl6A9aOjLebqzdwWyr4hAKLag1cq9s4w8/dqa2QzayNcPU+m11c7Pc+v
LCTqp1AlwYRMPznHYVXQbIP6Vy3rK6XHJpfU5vlib/7VUfOCE3Od3rmsD+1OtvDX
QYgjz3RZz1TgeQaKHk5O77GUIhmw1xRSQI+kxuUu2I6JKmETEkOkcvgbF6NyR1oN
NBtwQe7cJhJ1QHhB0PoNrB5cK6LIPlNgrxB6rqFsXyz1tOYN+/ObjvgJHsC9kCUc
vr3cIPI1Hy5lw3vEyFJuqnP0FKcO/CZjb4Wbk0ZFqTBDkBiqFLJTaFWLsRzngEk+
Nnu6Iq3gFIdDvBfmoAUHTBmB7dsKhw==
=Rd11
-----END PGP SIGNATURE-----

--1iwP804p5/iDUb1W--