Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2731964pxp; Tue, 8 Mar 2022 00:10:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyP17KscsYALBErtj8nFxuPYfzHIAWXZlNveravu6AGwZJmP9FAyf/WuGMDraVwdONWLE77 X-Received: by 2002:a63:8648:0:b0:37c:b29f:9c33 with SMTP id x69-20020a638648000000b0037cb29f9c33mr13250070pgd.590.1646727001428; Tue, 08 Mar 2022 00:10:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646727001; cv=none; d=google.com; s=arc-20160816; b=GAHDixLkOZtJUzAhAsk7VSuQ4AYhzCuXEC4nNK8AXz/PbW6ovYVbkhvCkVjRx0OUp/ wa8EdiyaMrJuxpNTUOD9BdDxjL/46ihe/YQztChEWlttLynhSYKg/8Fn7Y0xxurQBr/3 fEeqZyDoy/f+auKudrC41eV/a+adJEoE7wRZyHDfTTdtE2EWfa2LPpcYBrGNCRCgfqpl JW/A0At/gKXkRqH+dXJMDrg4SIqIZvldYF1qiV6a2SxlMw9r6RwfRKlN598JPdIKA8iv 2desJs7yRZrDKscNhoTXpKcz1NbWjDzDn0uJc2uyXfrG+V1w9gfzuDag96tcmt8IbnLE Y9hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=VMEKwBiD/5CmwbAtof2z8GMwXPO9FueLZUgikJXVEAk=; b=FCHCcl98AHoejCaXvinNPyPzyZoprGHns9TahChrMcxZJrfCERnnxMD50GV7pVb146 KOpuM3XzPLnWVPsc5bonXXIT1M0oKJ86SjnqjEwyG//FgwcCiG4k+WvWnxN1HfsoLHzS kJdHicW+eIZ9xRykLkLsZMEsqY/AcR7lTfI2b1QGldMDLSOZaMDq/CVhDAL8Wgmu8IhG J7MCQvb1gGhYc2h2ewtHELQBIpXEB7IF9EAH5MpQpAZwfI49rRx0WoTooxcwDgjz053w +esuRFi55zm6VCfAtw0V+SLz2BZ+pKlURFtbD3/QaZaC7cCjdvBsJL+BjX389XsGq8ft K3/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mxs5OdtH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g3-20020a633743000000b00372f2b931b7si14163002pgn.475.2022.03.08.00.09.46; Tue, 08 Mar 2022 00:10:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=mxs5OdtH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344692AbiCHHnv (ORCPT + 99 others); Tue, 8 Mar 2022 02:43:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344678AbiCHHnt (ORCPT ); Tue, 8 Mar 2022 02:43:49 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 380363878D; Mon, 7 Mar 2022 23:42:53 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id k92so7282673pjh.5; Mon, 07 Mar 2022 23:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=VMEKwBiD/5CmwbAtof2z8GMwXPO9FueLZUgikJXVEAk=; b=mxs5OdtHR3i8lji4+csXfWtvPd+Ajo3T2V05avIkmU6rDqFNnOiOkK3M3y11qlmZL0 bDEdDKOHvihmcW0iN0A7L2RT6fTgRNxrGN2Mjc0rXIUGPoXRb4ZrgJm02EFy7mxdKbE7 tL11ddv1JI1kBccAlq4+2P0AVhiEzFYsFRobQjogMRC9UdbvsQTxaIXRQ5AbKTJQyWjk FLtw8bso0FgAcjAEt531gugQxIH5jc13K3DZlHsbCpZBNZuibmyhQUyj96SMUc0dDdZT T0WKxdpqoze0O/LIFW95RF7p+IQNSAB7naPqMbqOKL+h9wqDUVGiV2kLWN44nZsPzD47 nOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VMEKwBiD/5CmwbAtof2z8GMwXPO9FueLZUgikJXVEAk=; b=aDM2ABACy7CTfB7hvSIvqh8AlbM5fmpK4COkwjxio9zCjSF8Olj9Lzsz4MFUQQVRrv ZH9qGHI5RuHOvefCRKWRC/JE1aD9waMf8WxU2CTzmzswfAWhKnPNpt2Ng4WoGzFs/0py 22h35h+xUVBRK4HaTuIt9+FLOHBRuqRqWyydw9X7xN6AMcpsLVedW1L5x/uuso6bOyhT mZP74j9nhlUt25MkyecIVcdqXGz7NAEHk/bqjZCdWvmmdhbjID7dD0/jIAgFUZZ+/UGA AWAkLaCbO1cBqFRh7ebRrsCs0pVWeFSEwpWE9DaocdMxGU4ndf3qCXiGspVBNpWJfKLg 06kw== X-Gm-Message-State: AOAM530sHqT3US4tBcxDg3Mf7R5Yc7Y7splRrsr3gxjlEqEpNQVOAEJK 0b7lbW9ygLLOgGDBRDSqtyw= X-Received: by 2002:a17:902:d2c9:b0:151:e08b:1442 with SMTP id n9-20020a170902d2c900b00151e08b1442mr11277025plc.5.1646725372737; Mon, 07 Mar 2022 23:42:52 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id h16-20020a17090a055000b001bf5ad0e45esm1709772pjf.43.2022.03.07.23.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 23:42:52 -0800 (PST) From: Miaoqian Lin To: Taras Chornyi , "David S. Miller" , Jakub Kicinski , Serhiy Pshyk , Andrii Savka , Oleksandr Mazur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] net: marvell: prestera: Add missing of_node_put() in prestera_switch_set_base_mac_addr Date: Tue, 8 Mar 2022 07:42:47 +0000 Message-Id: <20220308074247.26332-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This node pointer is returned by of_find_compatible_node() with refcount incremented. Calling of_node_put() to aovid the refcount leak. Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices") Signed-off-by: Miaoqian Lin --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index cad93f747d0c..73cd0a4b7291 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -554,6 +554,7 @@ static int prestera_switch_set_base_mac_addr(struct prestera_switch *sw) dev_info(prestera_dev(sw), "using random base mac address\n"); } of_node_put(base_mac_np); + of_node_put(np); return prestera_hw_switch_mac_set(sw, sw->base_mac); } -- 2.17.1