Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2732621pxp; Tue, 8 Mar 2022 00:11:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnBwsJCnGYoOEwsZ7M7K5WR3SGNZVJjFExXBywvdqYX2hfd2nY/d3Q+zsfR2olOvB5m2yw X-Received: by 2002:a17:90a:c302:b0:1bd:14ff:15 with SMTP id g2-20020a17090ac30200b001bd14ff0015mr3303315pjt.19.1646727065584; Tue, 08 Mar 2022 00:11:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646727065; cv=none; d=google.com; s=arc-20160816; b=Ygl2qKCVdnc7gy7TDmAJ3S9H/96SLrIb3igGIVKiP+Phw2IwNg9qjXxOtC+aVSEifm lCCFVfWWsgqBvIY/iXaNp1S1mV9pU77rxS5riJ56wbF8EqsbpQCur79cWFZliwzuPSfn 6gP9iHEVCEytD9iiJc23peHV23qVQIUBskOfN9pLIM2B/uuj+Wi7T7PR0GBrg4lJoIrm OgxhWnCbq0CwD3n0djf3eopqTdWI2CO1KGXGFWte3AZIHHsqOcASZ857hde0AwF4/mtk qe13WrqXkXexceOq1mBk2Clpq/zo5we8bRIsW4BBLvAE8gSxoKkjXPFBZX9u/OH8EYRv 1kzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=PZbjWyK++Wv0zJvBmkskzWbTkPsN2RPZCxoXtbLMWqE=; b=TDAXob9y3KXgRTRB9LQaTMtb7LdmmMnCh0RIZWL1yaVbD6pNmuqijxGbd7/D/VXsQm IeiURhMj1MOvUw6ZCsN9KnEwkpqzn5Ken4XZuBH0b/7IJmdvCkkCJaoN+YYkBOdivvjm oRnZ9OfflfmwgKOwI041Wbknre2PKhldT+H09Qn4NNNAki3q1oZxwK0kR0F4RW+mB0a2 NLfH8rYQpd2PNOB+ize33+8sEPqPI5bMRXNuZcgEbN0J+2B9qhtlis3b7OHZRhr4E5S0 HtIXS+mu4SZrbXXxvAtBcMBRd/YC52Feel44F0gZ3AHymD01J7qrvSye8ubanCl9GFEs MzGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i1-20020a1709026ac100b0014fc5ec9f25si13501433plt.524.2022.03.08.00.10.50; Tue, 08 Mar 2022 00:11:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344678AbiCHH62 (ORCPT + 99 others); Tue, 8 Mar 2022 02:58:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237428AbiCHH6Y (ORCPT ); Tue, 8 Mar 2022 02:58:24 -0500 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8776BBF3; Mon, 7 Mar 2022 23:57:27 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R381e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0V6dZ1Bq_1646726239; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0V6dZ1Bq_1646726239) by smtp.aliyun-inc.com(127.0.0.1); Tue, 08 Mar 2022 15:57:25 +0800 From: Jiapeng Chong To: axboe@kernel.dk Cc: asml.silence@gmail.com, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] io_uring: Fix an unsigned subtraction which can never be negative. Date: Tue, 8 Mar 2022 15:57:17 +0800 Message-Id: <20220308075717.37734-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the follow smatch warnings: fs/io_uring.c:10358 __do_sys_io_uring_enter() warn: unsigned 'fd' is never less than zero. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 23e7f93d3956..d970c94804db 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -10355,7 +10355,7 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, fd, u32, to_submit, if (!tctx) return -EINVAL; if (fd != tctx->last_reg_fd) { - if (fd < 0 || fd >= IO_RINGFD_REG_MAX || !tctx) + if (fd >= IO_RINGFD_REG_MAX || !tctx) return -EINVAL; tctx->last_reg_fd = array_index_nospec(fd, IO_RINGFD_REG_MAX); -- 2.20.1.7.g153144c