Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220305161013.361646-1-ytcoode@gmail.com> <56b9dab5-6a3d-58ff-69c9-7abaabf41d05@isovalent.com>
In-Reply-To: <56b9dab5-6a3d-58ff-69c9-7abaabf41d05@isovalent.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 7 Mar 2022 22:20:18 -0800
Message-ID: <CAEf4Bzb0_Tgmpu2c1a1WXZ8vcwu9OuXttWKZyFpNsnCEqkXygg@mail.gmail.com>
Subject: Re: [PATCH bpf-next] bpf: Remove redundant slash
To:     Quentin Monnet <quentin@isovalent.com>
Cc:     Yuntao Wang <ytcoode@gmail.com>, bpf <bpf@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Mar 7, 2022 at 9:06 AM Quentin Monnet <quentin@isovalent.com> wrote:
>
> 2022-03-06 00:10 UTC+0800 ~ Yuntao Wang <ytcoode@gmail.com>
> > The trailing slash of LIBBPF_SRCS is redundant, remove it.
> >
> > Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
> > ---
> >  kernel/bpf/preload/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/bpf/preload/Makefile b/kernel/bpf/preload/Makefile
> > index 167534e3b0b4..7b62b3e2bf6d 100644
> > --- a/kernel/bpf/preload/Makefile
> > +++ b/kernel/bpf/preload/Makefile
> > @@ -1,6 +1,6 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >
> > -LIBBPF_SRCS = $(srctree)/tools/lib/bpf/
> > +LIBBPF_SRCS = $(srctree)/tools/lib/bpf
> >  LIBBPF_INCLUDE = $(LIBBPF_SRCS)/..
> >
> >  obj-$(CONFIG_BPF_PRELOAD_UMD) += bpf_preload.o
>
> Looks good to me, but we could maybe just as well get rid of LIBBPF_SRCS
> in this file?:
>
>         LIBBPF_INCLUDE = $(srctree)/tools/lib

yep, I inlined this and ended up with just

LIBBPF_INCLUDE = $(srctree)/tools/lib

Applied to bpf-next, thanks.

>
> Quentin