Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751083AbXBUBkB (ORCPT ); Tue, 20 Feb 2007 20:40:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751054AbXBUBjf (ORCPT ); Tue, 20 Feb 2007 20:39:35 -0500 Received: from ns2.suse.de ([195.135.220.15]:34568 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbXBUBjD (ORCPT ); Tue, 20 Feb 2007 20:39:03 -0500 Date: Tue, 20 Feb 2007 17:37:41 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, Alan Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-ide@vger.kernel.org, bzolnier@gmail.com, Tejun Heo Subject: [patch 10/21] ide: fix drive side 80c cable check Message-ID: <20070221013741.GK30227@kroah.com> References: <20070221012758.925122216@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="ide-fix-drive-side-80c-cable-check.patch" In-Reply-To: <20070221013619.GA30227@kroah.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 36 -stable review patch. If anyone has any objections, please let us know. ------------------ eighty_ninty_three() had word 93 validitity check but not the 80c bit test itself (bit 12). This increases the chance of incorrect wire detection especially because host side cable detection is often unreliable and we sometimes soley depend on drive side cable detection. Fix it. Signed-off-by: Tejun Heo Acked-by: Alan Signed-off-by: Greg Kroah-Hartman --- drivers/ide/ide-iops.c | 2 ++ 1 file changed, 2 insertions(+) --- linux-2.6.19.4.orig/drivers/ide/ide-iops.c +++ linux-2.6.19.4/drivers/ide/ide-iops.c @@ -607,6 +607,8 @@ u8 eighty_ninty_three (ide_drive_t *driv if(!(drive->id->hw_config & 0x4000)) return 0; #endif /* CONFIG_IDEDMA_IVB */ + if (!(drive->id->hw_config & 0x2000)) + return 0; return 1; } -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/