Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Mar 2022 11:01:51 +0530
From:   Kuldeep Singh <singh.kuldeep87k@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] arm: dts: integrator: Update spi node properties
Message-ID: <20220308053151.GA67373@9a2d8922b8f1>
References: <20220307205357.66322-1-singh.kuldeep87k@gmail.com>
 <20220307205357.66322-3-singh.kuldeep87k@gmail.com>
 <f686aeeb-e033-927f-89bf-fad239ad70df@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f686aeeb-e033-927f-89bf-fad239ad70df@canonical.com>
Precedence: bulk

On Mon, Mar 07, 2022 at 10:57:40PM +0100, Krzysztof Kozlowski wrote:
> On 07/03/2022 21:53, Kuldeep Singh wrote:
> > SPI clock name for pl022 is "sspclk" and not "spiclk".
> > Fix below dtc warning:
> > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
> > 
> > Also, update node name to spi instead of ssp to enable spi bindings
> > check.
> > 
> > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> > ---
> >  arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts
> > index d47bfb66d069..ebe938556645 100644
> > --- a/arch/arm/boot/dts/integratorap-im-pd1.dts
> > +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts
> > @@ -178,12 +178,12 @@ uart@200000 {
> >  		clock-names = "uartclk", "apb_pclk";
> >  	};
> >  
> > -	ssp@300000 {
> > +	ssp0: spi@300000 {
> 
> Is the alias used anywhere? Why adding it?

I added an alias so as not to lose originality. At other places, ssp is
used more specifically for spi controller node and since here I need to
enable bindings check, so I mentioned both.

There are other platforms too which are using the same notation and
personally, I couldn't find any harm in this.

Regards
Kuldeep