Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3188984pxp; Tue, 8 Mar 2022 09:16:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+cXdsEh9v8j4MLQ1/L/2DV4KbmO7AX9TFXnB4Jy8c3P+QSecSpaI2AHWxKA/Nx0q0QFZL X-Received: by 2002:a63:3708:0:b0:364:db19:1365 with SMTP id e8-20020a633708000000b00364db191365mr14673884pga.113.1646759772393; Tue, 08 Mar 2022 09:16:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646759772; cv=none; d=google.com; s=arc-20160816; b=cDNyG2hrQ2HYU3GOPZtkV5+MNFMQhJAPJFGBsCMfD9qdsscZNYJ+5BfHZslCjCnmGX oeyIMSC0y543+ScCN17SLIAk55MHLRjbvGyzGNTGoiqewR70mKZP+T9BXMsBJbO+oIZs EHa8Vm6qIX+ac7Up85rzPkjFvS6dxbSimsAgmOpFM9RCLwqwcQ5QYgNxJmolOa8gzulx JsgXxpgzS0L919sQi5NYz0rccwEQdn59wxpx6jwATqfKXhqLSs4y/2b+TlXzhurcwvt0 81OiyMqKYiV6+4DuN73xp0WospV2XOFpyupjLdjZTk99ELEsZvZIISg5LsebHEKtv8o6 9RPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=T4Ldh9wP6NrK55uA0+WDFo63kUJzzU3JlOSL2h2P1mk=; b=kDNERpsS8Zlm6kUjXGv8gzBdU4zURo/S4TaKMQe4UcexUI0UcAut+FjYi3dJbO5dEx WNQMQFK0JHCX7mm97fb7zW90vQRSXqD6K1xZ7ZtKHPfwDDWypNVOk81eE4Us0cnfF+cU uYMKarW6Gfo/yHc+eG8BcvtVZoSnw5U4VN0E4QilJmsoOHKJXipGv3TgItIEls7S4W8E mooiGU8p1GJLYcM4VkWOC97xIfceOATMcOV6OlcS0v9nXfkHr4e65Sl5Tds7+fHGXOJK Ik0MUCiFHKLzx+3hcGjjxHEXvsebR/PyKYG8cGH3F9EP/hTbDTUA1iPmoAGfrE3S56VT y7tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PDQt0K+4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a170902ac8800b00151e09a4e0fsi7056292plr.43.2022.03.08.09.15.51; Tue, 08 Mar 2022 09:16:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PDQt0K+4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241449AbiCHDNZ (ORCPT + 99 others); Mon, 7 Mar 2022 22:13:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240534AbiCHDNY (ORCPT ); Mon, 7 Mar 2022 22:13:24 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7EB81160; Mon, 7 Mar 2022 19:12:27 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id c11so2845093pgu.11; Mon, 07 Mar 2022 19:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=T4Ldh9wP6NrK55uA0+WDFo63kUJzzU3JlOSL2h2P1mk=; b=PDQt0K+4JI0d9CJfngLON56gnSZBseP33imtVIA1IINB0GjO2bpqdMaSsP5N3ge9vT pJLJsCWuKCEEzA44XZTqDlySXahQgCh1cvuaN+0QPWMoi7GBKgIqL6I9h1Dvf+ZDFUM9 ImTTZ1DI+ipqKDy5PBhdQ24EaPsM0MYsCZbwgJGFDfMUqdZ+fpqwAyMlG8oWtP2xUVxs yoh+AIU8IuAkgnpBBEWPhr10WHVZiZqpbbulzPHytr+HhiN30FOEkbvMAI7gxRzM8Ip4 xIQNTAh9n9JIiua9cU0aApWEiHmZWBpNc6hklNCsKnJsCmNGYRacdL+4Vgcebh4v6edN qy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=T4Ldh9wP6NrK55uA0+WDFo63kUJzzU3JlOSL2h2P1mk=; b=MgF/gCMIRSKnMLIZawHhIv+c3cLKRmuP70KB5pELH9/TV5b1d8fv8rQoPgtJjwjP7N mfRxg63IUwJC/02G4J1VtV7M34QY4fBi69kkTXzZjOAXK/Q/ES6dk/kZN8FAA/NwrwkH MUqIeNB7mJR+H5ZoEnrPa7mNecpkQYpbt5NYQYs61MRPaay4mAVMAw8kQges0gZAazGE xnYIABntUdGrqaYFNtCfuICpVYplnyahCtMXReu42U9PSYUXBo69RuC/PEtcjIUIy1WT cWcf1Yo9LkMpuvm50722b5ku26svjfSFmTQtNKvuPQSMTfE3x8otG03RBzZkIgH5iB3c d3DA== X-Gm-Message-State: AOAM53021HJa8AtMYBh9biFuujt80neY0eafzPayTZloZe7MZLXCWD/x Kv2OYqgE+kBRmQBKyhlZZLY= X-Received: by 2002:a63:e60:0:b0:374:6620:f372 with SMTP id 32-20020a630e60000000b003746620f372mr12423978pgo.557.1646709147212; Mon, 07 Mar 2022 19:12:27 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id bi29-20020a056a00311d00b004f6fa51e70dsm5445580pfb.196.2022.03.07.19.12.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 19:12:26 -0800 (PST) From: Miaoqian Lin To: Andy Gross , Bjorn Andersson , Mathieu Poirier , Rohit kumar , Sibi Sankar , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] remoteproc: qcom: Fix missing of_node_put in adsp_alloc_memory_region Date: Tue, 8 Mar 2022 03:12:19 +0000 Message-Id: <20220308031219.4718-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: dc160e449122 ("remoteproc: qcom: Introduce Non-PAS ADSP PIL driver") Signed-off-by: Miaoqian Lin --- drivers/remoteproc/qcom_q6v5_adsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c index 098362e6e233..7c02bc132247 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -408,6 +408,7 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp) } ret = of_address_to_resource(node, 0, &r); + of_node_put(node); if (ret) return ret; -- 2.17.1