Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Mar 2022 16:16:19 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Alifer Moraes <alifer.m@variscite.com>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, eran.m@variscite.com,
        festevam@gmail.com, lgirdwood@gmail.com,
        linuxppc-dev@lists.ozlabs.org, nicoleotsuka@gmail.com,
        patches@opensource.cirrus.com, perex@perex.cz,
        pierluigi.p@variscite.com, robh+dt@kernel.org,
        shengjiu.wang@gmail.com, tiwai@suse.com, Xiubo.Lee@gmail.com
Subject: Re: [PATCH 3/4] ASoC: wm8904: extend device tree support
Message-ID: <YiYv08yef4eIbAXz@sirena.org.uk>
References: <20220307141041.27538-1-alifer.m@variscite.com>
 <20220307141041.27538-3-alifer.m@variscite.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="9yotZ5uYT3fHlEJd"
Content-Disposition: inline
In-Reply-To: <20220307141041.27538-3-alifer.m@variscite.com>
Precedence: bulk


--9yotZ5uYT3fHlEJd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Mar 07, 2022 at 11:10:40AM -0300, Alifer Moraes wrote:

> +  - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property
> +
> +  - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC)
> +    The list must be (4 x num-drc-cfgs) entries long.
> +    If absent or incomplete, DRC is disabled.

What is the purpose of having num-drc-cfgs?  We can tell how large
drc-cfg-regs is so it just seems redundant.

> +  - num-retune-mobile-cfgs: Number of retune modes available from
> +    retune-mobile-cfg-regs property

Same here.

--9yotZ5uYT3fHlEJd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmImL9IACgkQJNaLcl1U
h9D0nQf/e94yrWlNJbnJEWkZM5yQ9NWqCSnHkn9vGfNqeP08qmHuPx5rKMPsJlQE
U3iaSMsrPstH1JbpQM4gp9uh+Fg6VvM5/qWyJo1MgSaaMV90p9JUzhnyWGx4JiHq
/i7xUGfwLOBdC3jP7IxCeDnXlTfgdp/4XgTTzjlS1iOnQbnFUCV1LBCFf4KF02/5
F74oQX80r26mdT9BlqXSM9FpuiVJq3E7Ckzo6ilYR1u5C8MCtzZmR0LGnb3mihWs
f46WBAlRgZqIWd56ISFJlOyCuM8oXNikquhN20NGRraagoxbvQQeC7zvBIDAMuZE
YK+1RvyQrlT86QdGrRg9lBdvKY+14w==
=gOHh
-----END PGP SIGNATURE-----

--9yotZ5uYT3fHlEJd--