Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965323AbXBUBxH (ORCPT ); Tue, 20 Feb 2007 20:53:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964841AbXBUBwo (ORCPT ); Tue, 20 Feb 2007 20:52:44 -0500 Received: from ns.suse.de ([195.135.220.2]:42953 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965126AbXBUBwb (ORCPT ); Tue, 20 Feb 2007 20:52:31 -0500 Date: Tue, 20 Feb 2007 17:51:09 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Grant Likely , Mauro Carvalho Chehab Subject: [patch 14/18] V4L: Fix quickcam communicator driver for big endian architectures Message-ID: <20070221015109.GO3684@kroah.com> References: <20070221014413.282048309@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="V4L-Fix-quickcam-communicator-driver-for-big-endian-architectures.patch" In-Reply-To: <20070221014927.GA3684@kroah.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 59 -stable review patch. If anyone has any objections, please let us know. ------------------ From: Grant Likely Host endianess does not affect the order that pixel rgb data comes in from the quickcam (the values are bytes, not words or longs). The driver is erroniously swapping the order of rgb values for big endian machines. This patch is needed get the Quickcam communicator working on big endian machines (tested on powerpc) (cherry picked from commit c6d704c8c4453f05717ba88792f70f8babf95268) Signed-off-by: Grant Likely Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Michael Krufky Signed-off-by: Greg Kroah-Hartman --- drivers/media/video/usbvideo/quickcam_messenger.h | 14 -------------- 1 file changed, 14 deletions(-) --- linux-2.6.18.7.orig/drivers/media/video/usbvideo/quickcam_messenger.h +++ linux-2.6.18.7/drivers/media/video/usbvideo/quickcam_messenger.h @@ -35,27 +35,13 @@ struct rgb { }; struct bayL0 { -#ifdef __BIG_ENDIAN - u8 r; - u8 g; -#elif __LITTLE_ENDIAN u8 g; u8 r; -#else -#error not byte order defined -#endif }; struct bayL1 { -#ifdef __BIG_ENDIAN - u8 g; - u8 b; -#elif __LITTLE_ENDIAN u8 b; u8 g; -#else -#error not byte order defined -#endif }; struct cam_size { -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/