Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 8 Mar 2022 16:10:58 +0000
From:   Daniel Thompson <daniel.thompson@linaro.org>
To:     Qian Cai <quic_qiancai@quicinc.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] configs/debug: Restore DEBUG_INFO=y for overriding
Message-ID: <20220308161058.zuuze2jvhbiq53xy@maple.lan>
References: <20220308153524.8618-1-quic_qiancai@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220308153524.8618-1-quic_qiancai@quicinc.com>
Precedence: bulk

On Tue, Mar 08, 2022 at 10:35:24AM -0500, Qian Cai wrote:
> Previously, I failed to realize that Kees' patch [1] has not been merged
> into the mainline yet, and dropped DEBUG_INFO=y too eagerly from the
> mainline. As the results, "make debug.config" won't be able to flip
> DEBUG_INFO=n from the existing .config. This should close the gaps of a
> few weeks before Kees' patch is there, and work regardless of their
> merging status anyway.
> 
> [1] https://lore.kernel.org/all/20220125075126.891825-1-keescook@chromium.org/
> 
> Reported-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.


> ---
>  kernel/configs/debug.config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/configs/debug.config b/kernel/configs/debug.config
> index 07df6d93c4df..e8db8d938661 100644
> --- a/kernel/configs/debug.config
> +++ b/kernel/configs/debug.config
> @@ -16,6 +16,7 @@ CONFIG_SYMBOLIC_ERRNAME=y
>  #
>  # Compile-time checks and compiler options
>  #
> +CONFIG_DEBUG_INFO=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  CONFIG_DEBUG_SECTION_MISMATCH=y
>  CONFIG_FRAME_WARN=2048
> -- 
> 2.30.2
>