Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965304AbXBUBye (ORCPT ); Tue, 20 Feb 2007 20:54:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965324AbXBUBxH (ORCPT ); Tue, 20 Feb 2007 20:53:07 -0500 Received: from mail.suse.de ([195.135.220.2]:42969 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965312AbXBUBxB (ORCPT ); Tue, 20 Feb 2007 20:53:01 -0500 Date: Tue, 20 Feb 2007 17:51:37 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org, Andrew Morton Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Jeff Dike , Andi Kleen , user-mode-linux-devel@lists.sourceforge.net, Paolo Blaisorblade Giarrusso Subject: [patch 18/18] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted Message-ID: <20070221015137.GS3684@kroah.com> References: <20070221014413.282048309@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="x86_64-fix-2.6.18-regression-ptrace_oldsetoptions-should-be-accepted.patch" In-Reply-To: <20070221014927.GA3684@kroah.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1681 Lines: 51 -stable review patch. If anyone has any objections, please let us know. ------------------ From: "Paolo 'Blaisorblade' Giarrusso" Also PTRACE_OLDSETOPTIONS should be accepted, as done by kernel/ptrace.c and forced by binary compatibility. UML/32bit breaks because of this - since it is wise enough to use PTRACE_OLDSETOPTIONS to be binary compatible with 2.4 host kernels. Until 2.6.17 (commit f0f2d6536e3515b5b1b7ae97dc8f176860c8c2ce) we had: default: return sys_ptrace(request, pid, addr, data); Instead here we have: case PTRACE_GET_THREAD_AREA: case ...: return sys_ptrace(request, pid, addr, data); default: return -EINVAL; This change was a style change - when a case is added, it must be explicitly tested this way. In this case, not enough testing was done. Cc: Andi Kleen Signed-off-by: Paolo 'Blaisorblade' Giarrusso Signed-off-by: Greg Kroah-Hartman --- arch/x86_64/ia32/ptrace32.c | 1 + 1 file changed, 1 insertion(+) --- linux-2.6.18.7.orig/arch/x86_64/ia32/ptrace32.c +++ linux-2.6.18.7/arch/x86_64/ia32/ptrace32.c @@ -239,6 +239,7 @@ asmlinkage long sys32_ptrace(long reques case PTRACE_SINGLESTEP: case PTRACE_DETACH: case PTRACE_SYSCALL: + case PTRACE_OLDSETOPTIONS: case PTRACE_SETOPTIONS: return sys_ptrace(request, pid, addr, data); -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/