Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3439770pxp; Tue, 8 Mar 2022 14:34:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiUQqutAveFeaH0ofJz4/nskE0gAg8y8lffFy+p67YuBt0Bn0YUALEUQl/pmGR6P3h3fuu X-Received: by 2002:a17:906:b288:b0:6da:825e:a2ee with SMTP id q8-20020a170906b28800b006da825ea2eemr14783471ejz.254.1646778849728; Tue, 08 Mar 2022 14:34:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646778849; cv=none; d=google.com; s=arc-20160816; b=o0iMfVX2gq1dBWXNkEBe5/dCgDVQb5sBP4MvpGsr6tc5NFJn9OjZg1ZSb0UQKPK9R2 n3Uj9Vxuks38j1qoDptTq8bRtWWAoViNe0cTmY9TRhLM8cvCayWTKl2AWCO/ntduvj+t gvy7c4I5qGkPzGFM6QAtQ3Ul+NRCDohJsIujQ6cKhnC/wu47FTZx30A2eQ8cpCDjbfqY FFiWu4UowYKlYn1T0Hx4Lqewfjb8OqlWNI4WgOeQ/WGQ2uhfKB6sm5Sih4uJf4tkY5ym CR9Zj406x/9zvAEnKTLotjJJ2ynFxAAvaCvKnXxxs3NFOeMFqlQZqj6odemBjh8Wne7J cKFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Mx5hLEqn8My0F+yXTcGcX8saGMYANVTYsACmCpFd5d0=; b=iSFCZws/SiPFICgl5smMYCBi0VJItKolOQBCWeArtD7qDHGgQjicGzqjOnBgA0FLXQ CqkV22tmBP32+mTm42cr+P9nlIE7UkTjry+fb+jOOexkmNAdij8Vh6t1yr4vCdGLYt9e n/ZPkseMCt14ctPLQak45FcGGNe0czYNAEaKwkFnaZtyjKM/EuR3MuFfDPxffiCSauS4 412YG/q9kkVc+034yxzRrIi/EmkIpATP9faH/AMzaPcLX/cOMkiTtPddnSZG7QXlSoVG udUhYEf368L1DmqOKnkS026CU/hwvI0lJQUe0nKrH6N1Xg27VjMSe/B/xvHDxpF6IdxT 5hdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LiHV6K7J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he12-20020a1709073d8c00b006da95d08630si94212ejc.84.2022.03.08.14.33.46; Tue, 08 Mar 2022 14:34:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LiHV6K7J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343920AbiCHAJX (ORCPT + 99 others); Mon, 7 Mar 2022 19:09:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343979AbiCHAJU (ORCPT ); Mon, 7 Mar 2022 19:09:20 -0500 Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E35EC12762 for ; Mon, 7 Mar 2022 16:08:24 -0800 (PST) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-2d07ae0b1c0so184007927b3.2 for ; Mon, 07 Mar 2022 16:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mx5hLEqn8My0F+yXTcGcX8saGMYANVTYsACmCpFd5d0=; b=LiHV6K7JBJSMYhKhrKF9W2mHES55ZBn8mEURsw17mfuBV4BSev7POOOhRzd8JKyBKF paBwZnN+QOzLeUc0+g7vXjBOguhMIuEnf1ZzfLj4rTs40Tnk9H0t9vCr5wE3rHn0D+gV EWtZrTqcTGgFWFx7nknKXdOQIhqGEenOZKYB7PKKunlLxXOUMVndrc89oQV6wAgrYTut SjP7NBczzWSbkdpJMULm7WEqLrJoggoPCkrhfB9dXfxHFE80l5050MfAK+EirIfJ0ry2 RulRW9iQLwlKAPRgozIw8dYstsFGH/t5TM5OGhdxL5bZT3gwfFmrXCCO+mzlUHow/h/t Gevw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mx5hLEqn8My0F+yXTcGcX8saGMYANVTYsACmCpFd5d0=; b=fFHBTLYMDJJlprYwsBE68CkY3E1o9A2ivBTIlFde5sb/1GENDBS4yHsCotSlP8KRa5 my014HXI0guLISgS/Bdj1zjBDO2e6Erx/F4EAEJmaKvOdIHYXg/Pdu8LOirKMTHoiUWf K8iTT2IzQvMjhYVqsOkeudFYjyzplVHNNADtOmhYZCqyMakLQCDQDM+w7trHaSBay9OE IXpNYsL5yH34CU/vcCXqMW38jGhMWzLgEvNfCdYP//hZnDpFiLiK6MEbGLliDSridwwq y3j1CqdWfhLywZFSLYCwaKVYN33l2dkI9FQ65dIRjEyxF16oj07FMAoI1BY5By9M1ED7 J+lg== X-Gm-Message-State: AOAM5312oMvO4lyV1vT+sD+RmGzBe98T6qGuC+OQe3WNp3clvRLV2W6K wNSXpNvJdJ9J1dxjQmFoCLB4+fIaFS4ptbJJaRYWKw== X-Received: by 2002:a81:854:0:b0:2db:255b:dd6 with SMTP id 81-20020a810854000000b002db255b0dd6mr11185948ywi.140.1646698103518; Mon, 07 Mar 2022 16:08:23 -0800 (PST) MIME-Version: 1.0 References: <20220307110728.15635-1-linmq006@gmail.com> In-Reply-To: <20220307110728.15635-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 8 Mar 2022 01:08:12 +0100 Message-ID: Subject: Re: [PATCH] hwrng: nomadik: Change clk_disable to clk_disable_unprepare To: Miaoqian Lin Cc: Matt Mackall , Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 7, 2022 at 12:07 PM Miaoqian Lin wrote: > The corresponding API for clk_prepare_enable is clk_disable_unprepare, > other than clk_disable_unprepare. > > Fix this by changing clk_disable to clk_disable_unprepare. > > Fixes: beca35d05cc2 ("hwrng: nomadik - use clk_prepare_enable()") > Signed-off-by: Miaoqian Lin Thanks for fixing this! Reviewed-by: Linus Walleij Yours, Linus Walleij