Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <bfd40073-62ae-e458-a869-b0eb60414632@oracle.com>
Date:   Tue, 8 Mar 2022 11:20:47 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v2 3/3] scsi:libiscsi: teardown iscsi_cls_conn gracefully
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wu Bo <wubo40@huawei.com>, Zhiqiang Liu <liuzhiqiang26@huawei.com>,
        linfeilong@huawei.com
References: <20220309030916.2932316-1-haowenchao@huawei.com>
 <20220309030916.2932316-4-haowenchao@huawei.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20220309030916.2932316-4-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0xCTlg0OEhvYkU4TlBmM2FjcHlHc0lQVkhGb3p2YnZWdW5GdEttQXd6b2xW?=
 =?utf-8?B?UStRK2xJazBacFpVQkFiVEw0WnZrK2Eyckcwb1MyRUpwdlcyUERZUGt3Um42?=
 =?utf-8?B?TmhuRFVhMXIrWWZkRnljVHdNbTlvakdtYjd4eDg3K3h0VnNqWU4rT2xoTFkz?=
 =?utf-8?B?QXRjVWhlOHUzRk1vUkFLK2FHY3RxZzVWeEx0MXBWTWZLL3RXTU1nRUY2UDVy?=
 =?utf-8?B?SytuWXVBQU43SFdWaTl0SGpHMHVLQzFIcnYyL3ZtempQMTlScjdZK3QzSHRm?=
 =?utf-8?B?c0VocHI0b0d6MFBLMnhvUlovSlJWOWtvRStwL21rZlNRTjJ3VVgvRkZtalJu?=
 =?utf-8?B?Y0oyamJCSHJtdkZGQlREVUdVNkEzdHFZcnJRSWdsd1h6NTVwSmhEZjNCc20v?=
 =?utf-8?B?R2lmT2VyQm5lZjNCTkNML3hqZG1vcEZXTm5HdVRwcFlnZEwxMWYvdkRVQWFJ?=
 =?utf-8?B?azRneFdKV3FwbVRsdU5uSzRGemFvalh4dCtoK3BueVFZOHlIWWZLeUxKNE1m?=
 =?utf-8?B?Uks0WVJpVEwvSnlsSm5UNlpqSU1wTitsYU4ybS95VWJRZEFBamJnUWdsdDZy?=
 =?utf-8?B?NDlTbU5rTGxiYVdnc2QzTVI3NHFYc2dEeHZOOU1WczdNb2dmdXBOKzJsKy9n?=
 =?utf-8?B?THpjbDl4TFQvVW5sZEd6Qmordkp6eFR3bndRK3owTkIwcWQyQkZRT3BEYk12?=
 =?utf-8?B?d2kzNzVnY1hBTEFMR25ZV1lhNWlZZTg0TkxuSTJ5MkY5NFAzT3FTZzMvNnlK?=
 =?utf-8?B?eGo2V1NXM1dJRVZvaFlKK0N2UDdKOTcrOFBYb3NNbGJnclNNN2tmM1UxQU1C?=
 =?utf-8?B?L21PYlAyZm5xRW1DdERjdG1qdXlvUVhGaHRMU0hVRmdDNFdMWFM1bzRmZ1h0?=
 =?utf-8?B?NGVZRlZqTGNBNDZ1d1RtcXdxa2czUzFRRjEzT29IeGRyL2I0R1hzNFZ3aUVh?=
 =?utf-8?B?TWxYWG4yTzlSWWNQd2NpL1B4c0hnTXlEcWk4QXRYZzdQYVdBWmhHRnR4clVi?=
 =?utf-8?B?OEpvaWRUbWJwT0N5M0tkK2o1WHA5aTBrTzhvZVZFRDVUUjJWalRmd0JMeW5i?=
 =?utf-8?B?eFB0R0VYR1lHQ3ZYN09sSHFncThLalZjZG9XZ29vejZzbzNSS2dIRTFvSk5y?=
 =?utf-8?B?SFY5eXdYcHlQSVg1c0xPNkxRSWVCUlBrdWQxLzdhQVhyMXZLcDJXS0pwZHNW?=
 =?utf-8?B?UW1uNldWbXJlZkxldC9xRnAzN0lOeFhtRkovVWl6THFpUE5GSDB1SGlQTVRU?=
 =?utf-8?B?STVTOUkwNWdyeWZ3OG9FLzlpb0FuZmVZeFMrRjNEMG9GY21idTR6UkJvU3g3?=
 =?utf-8?B?WlVEamh1RFJWNEg2UDJ3YnN4QVN1Umgzd2g4YUI2VWJjVHlPTGJFa0RpeWx1?=
 =?utf-8?B?REt0NVhlejlpWkVNSjZJZXVZMlFnOGlhUUtOOWZOYlFJeSs1eHZ2bTNkRXBq?=
 =?utf-8?B?RFpsbXJ0dEk4cnBRSXE1WWV3SnNodnV4b1VuMmxCUUV0djhqWkVTRWZzeE1W?=
 =?utf-8?B?WDBGakpoc2VSa2NsSHg0VWI3OVFIUjM0dXdlbVI4aU96cDlvRTZjMjBuWElz?=
 =?utf-8?B?R1R5VkZJYm8zdURrVS8rekVmUklnN1VEL3VRQmNxNEVwVERqRmoxRXBGNFFL?=
 =?utf-8?B?ZFBzTnpNUDZUSXBtTC9ocWlLSFVPbldNWkpabk9IaFV6TFVQV2FCaHNyelM4?=
 =?utf-8?B?RkdzZStEdEdsbXdPS1lWT2grMFpOMXp1cExqckZIa095Tm1iYVJOd0hsU2JQ?=
 =?utf-8?B?UzYwRjhUZkczYVpkSUdGbys2bXYwSmxiNkhZTlFYTFQ3QllJZzhlSVRUYnU3?=
 =?utf-8?B?VUdZa2dwS2VpWGVsTmRWYU5ZM2czcDlCWmJDaFJrYUtKeGU4L2htM25nbmVW?=
 =?utf-8?B?Z0wwMm1ZTllZeWl2YkdLa0UvUlBMN3lQL2pNZkZnTjlleWxkby9pSHJyQkVM?=
 =?utf-8?B?VkxHRHVZU29kTmtGZjgvMlRoWVdoZUhjOC9KVVVJY0FYSTUxRk9WUzVZaDhq?=
 =?utf-8?B?dHdOTHcyWjNzUWtqYUNJZTJnbE1COU1OajhzdnRzUHBMRk9FcEpJNWNwUjNw?=
 =?utf-8?B?YUNZcWhUTUY0ZE11c05uMGwxKzFPY24ySGdVdWN3Ry8yM1ZqNExOUFphU1M4?=
 =?utf-8?B?OEt5NnVsME4zSkJ2N1U2YWs1dFZ0L1ArQ0hPZFg3djY3NWFLY2xFdml2RXlG?=
 =?utf-8?B?dU81RDY1WFZLMVZhdTZVajY2Vk4vNFcxLzZtWm5sQWRrMjlCNC9lQlBZd3l4?=
 =?utf-8?B?U1pVeXhvckNQQThac1JTSFFtcklnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea040348-266c-42ae-d565-08da0127fd04
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 17:20:48.7588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MPciBL5K02uLelMoAuYonBA4wNKVtk5ZLxK84D12ESVtZKS642JrbKrTETgQ5wMUvZ5Xz9WMzbSSJJW1Suodh0hdR3evD43nsd7lXj/Jl2Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3222
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10280 signatures=690848
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0
 suspectscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203080090
X-Proofpoint-ORIG-GUID: y9qDifxzbM0wBvxaz1zWIRXd2IsevSEn
X-Proofpoint-GUID: y9qDifxzbM0wBvxaz1zWIRXd2IsevSEn
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/8/22 9:09 PM, Wenchao Hao wrote:
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index ca724eed4f4d..7b4d998708e7 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -2165,6 +2165,7 @@ static int iscsi_iter_destroy_conn_fn(struct device *dev, void *data)
>  {
>  	if (!iscsi_is_conn_dev(dev))
>  		return 0;
> +	iscsi_remove_conn(iscsi_dev_to_conn(dev));
>  	return iscsi_destroy_conn(iscsi_dev_to_conn(dev));

Just do:

iscsi_remove_conn
iscsi_put_conn
return 0;


>  }
>  
> @@ -2463,7 +2464,7 @@ int iscsi_destroy_conn(struct iscsi_cls_conn *conn)
>  
>  	transport_unregister_device(&conn->dev);
>  	ISCSI_DBG_TRANS_CONN(conn, "Completing conn destruction\n");
> -	device_unregister(&conn->dev);
> +	iscsi_free_conn(conn);
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(iscsi_destroy_conn);