Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <ca174698-3790-7ed8-fbaf-674d547d4b76@oracle.com>
Date:   Tue, 8 Mar 2022 15:34:22 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 0/2] x86/boot: Fix setup_indirect support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, luto@amacapital.net, dave.hansen@linux.intel.com,
        kanth.ghatraju@oracle.com, trenchboot-devel@googlegroups.com,
        Daniel Kiper <daniel.kiper@oracle.com>
References: <1645668456-22036-1-git-send-email-ross.philipson@oracle.com>
 <20220225211730.2oxumw7ixfe7cyoz@tomti.i.net-space.pl>
From:   Ross Philipson <ross.philipson@oracle.com>
In-Reply-To: <20220225211730.2oxumw7ixfe7cyoz@tomti.i.net-space.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXU5cS9tTG1mSjA0QzNIOGswbkdkSnBzNDJkWXRKelc2NDBOZ1Y1eEJKSkFt?=
 =?utf-8?B?emFnM05jaE1jemRVRm9JRVFXbE9EMjR0RllpdXZLUktLNnZsY0JqR3hBTlhi?=
 =?utf-8?B?WGVLQTVFMm1tVjZEc1A0RndOazJ4aStxZGdCQWhkWjJLMzRRNmxNNEFVMWZh?=
 =?utf-8?B?bFYwVFpSV3d3WXpCSUs2b0dlVGdhczBuc0pQOGZFcGg1N1RoRDNQa2VtTWc1?=
 =?utf-8?B?WUVpYzBsVlpJK3pSU3JVamhqa0VpZWFldCs2enBZSlhkdzlPZ1dxVTY2bldy?=
 =?utf-8?B?RlhWRFdvWXRJaG8yaUN5aGFaQVprWXpEdzNLWGdXWUU3Q0FHaDBpNXROdzZT?=
 =?utf-8?B?dTJSSVZGanluWmRJZ01SUnd1SUdXQlNaY09pU1JSSklONEVKZHBsc1NoWU91?=
 =?utf-8?B?VXB3em5vSUp6QXNCcTRuSEx3YWZoajBDa214R0JuNDZ5emVaQnp0Y0h5SHB4?=
 =?utf-8?B?TkxucERhVjFHOFZJTGtHYjZ3Um4rZnlNc1ZkVXJBVkxFKzQzVzFOZXI0OUNZ?=
 =?utf-8?B?RU1zcjN6NU10UHFPZEtrZys2Q0F2OUxXNGFDUVZuYU15d3UwZlIveEkvRDJ3?=
 =?utf-8?B?WVlMaVpRTjJnbEZEWWltckxnaG5rNEVhTjV2bjU0bkVVcmhxTERnRHBmTHlT?=
 =?utf-8?B?bjN3ODZHTW5jV2cxN3QwdksxS0E1eHZ0NUhScjcweGdjT25JOWh1YUZ4a0Mz?=
 =?utf-8?B?TWZTQzYycVlZQ0RMcGpRdVFMZUwwOUNnK3VsaUlXVXRCZXJuWUZYUngzQU5Y?=
 =?utf-8?B?cjZjcjNZTGdPNWpTcmlZYUZ6a1ZlVVBMLzZuVTN5SjIybVY0UjZ5a0lRKzAr?=
 =?utf-8?B?UkxIUXNYUnJXSEt0bWJjNTBYRG80cTcwcWtESEs4UEhFRTJnMFZTd3JYSGlW?=
 =?utf-8?B?Ny9hZng5Rkd2bkhIZXl4QnBjMnd2OHJLbkNMSWVDYmxWLzY1WE9qWlcwUzVW?=
 =?utf-8?B?T1l4cEI0QVRPOURYaDNHTERCSHZuV2xCSFdrQ0h4U29Ic1I5UE9ac0ZveGJx?=
 =?utf-8?B?cFdXcEdvN01ZeGxCeFp0YVlXRTBMKzhiUnhGSmcxRjNpUGZrYkxlRCtFc3l3?=
 =?utf-8?B?cm9VbkJWZjlWWGhQallxQ3paZUhvY0ErK0RSL2owVmg5dGJ1dndSZWNmSFhJ?=
 =?utf-8?B?b1lLeCtIeTBUdldKd1U5ZkNrdGlweE5nZmY0cjdKODBneERlSDlNVEN6VnZG?=
 =?utf-8?B?QUtWQ0dWZjdTUGQwRTVhWGgzcldOSVN4YVAycUdXQ3ZydzRYbExLazc1Rytx?=
 =?utf-8?B?UFFiVTNISXg5ZEk4NEVQaGFsdWlNTGhZTjJ4bDkyajN5QU10VkJzeG1KRlhQ?=
 =?utf-8?B?eHdvZ2VITjNXcXFlNVU5VzE2UDVTbFZkdUovb3NPNGxBNng2bWI2V1BPNlFj?=
 =?utf-8?B?dDd6WHFBSHBZWUlyUGh3dG52NHhBZkxabDFyOXc2aWFBbHdDblcyM05mbWpO?=
 =?utf-8?B?TTFTam8xZmN4TzNKWTZVakhiS003cFZQZ0t3SnNuaitQa2cyejkzOWVMelox?=
 =?utf-8?B?Uzh0SUQyc25yemxMeVJOWnA0VEJWY05qcjFRdkQ5WHhGNGFPMFh3aEpqTCtL?=
 =?utf-8?B?NXByNUhqU0ZNL0VXNTU4aVZPdTFkQVAzZ2ZJLzI0TEZFQkpnQ25FUS9MV0cy?=
 =?utf-8?B?dEpFcDM1cTRXUTJWUDBTYURTY0F6N3FoREdJZTJoRS9xdDJKQXBFRzNjb1VP?=
 =?utf-8?B?OTAzZkZwV0hwQVZucGRkMDdWMVZ4S1RDTloyUTljendYQUx6dzF3d0MzUWFE?=
 =?utf-8?B?WU44djlFM045UEQydjhObE5aL0haalZpOXBFNXo0VncyVmJ3ZTBUU2hXKzRX?=
 =?utf-8?B?enRsWFl0UmszWHRoODZZbmFZcFYvWElrdmhpdlB5S1V5ckJuUDQrRVRKWXNJ?=
 =?utf-8?B?QWU3SzAvUll0czVOQW5oQ1ZmMHJraVdYNG1JZ0c2NkdmWlJ0QmZFbTdIZ0p2?=
 =?utf-8?B?Q1BBblpDYXJlT3pMSWh6TVFBVmpWVzhDaFJGMFZNTGFaOFZqNVZaMFlxb0g4?=
 =?utf-8?B?WEkvZWlZMk9VeGExZHJENkY4bWlxL09XNmFRQnoyczZ5VWJVRzZxdUF2UnFs?=
 =?utf-8?B?T0FmamY2MFRXa0hPcHJybkx5VVM2clRueEFTYk5VNE14bDdPNFZVNndRbSsw?=
 =?utf-8?B?Qy9SbDdZemw0TnhoWEY2S3pZYWVqN3pDSUdzZkdoNzlhTFU3K3dJU3hCVG45?=
 =?utf-8?B?UEpnekE3dENsR3ZVYkRPbGh5V0tKc1h1U0pyOFZmOEJFdEpHVmNhWE1lKzNs?=
 =?utf-8?B?TEZKTGZWUEJEak9tUTB3b0lZUUlKa0Q2MzM3eG1HUDBLeWh5LzRiYXdrVm1E?=
 =?utf-8?Q?/04y15mdWXP3KA5P0T?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e13fa15-1e80-4278-007b-08da01430966
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB3793.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 20:34:26.4087
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ADagEftx1d0+Olk6LtgmiVfJKJLVKZmKPInLdA5kOjzCC9IcRa4Hdh5xLo4GMyUGSnsywQ1HM3evkHPu3nUWVK/duUu2x52LbWMC4ZDt2y0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3913
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10280 signatures=690848
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0
 bulkscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203080105
X-Proofpoint-ORIG-GUID: Xxh5o5NbgP1ZaQUsV5OfptSuFCCmHlvC
X-Proofpoint-GUID: Xxh5o5NbgP1ZaQUsV5OfptSuFCCmHlvC
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/25/22 16:17, Daniel Kiper wrote:
> On Wed, Feb 23, 2022 at 09:07:34PM -0500, Ross Philipson wrote:
>> The setup_indirect support for x86 setup_data was added in November
>> of 2019. Several issues were found in the implementation and these
>> two patches were created to address those issues.
>>
>> These patches were originally posted as part of the larger TrenchBoot
>> patch set but are now being posted separately since they can be merged
>> independently of the TrenchBoot work.
>>
>> Changes in v2:
>>  - Add checks and failure modes for when early_memremap and memremap
>>    fail.
>>  - Fix variable declarations to use reverse fir tree format.
>>  - Use local indirect variable and remove all the inline casts.
>>  - Misc. fixes to the commit messages.
>>
>> Ross Philipson (2):
>>   x86/boot: Fix memremap of setup_indirect structures
>>   x86/boot: Add setup_indirect support in early_memremap_is_setup_data
> 
> For both Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...
> 
> Daniel

Borislav,

Sorry to bug you. I am going on vacation starting next week and I just
wanted to get an idea if v2 looks good for merging in to you? If not I
could probably get a v3 out before I leave.

Thank you,
Ross Philipson