Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Lianjie Zhang <zhanglianjie@uniontech.com>
cc:     Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Veaceslav Falico <vfalico@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] bonding: helper macro __ATTR_RO to make code more clear
In-reply-to: <20220307013333.15826-1-zhanglianjie@uniontech.com>
References: <20220307013333.15826-1-zhanglianjie@uniontech.com>
Comments: In-reply-to Lianjie Zhang <zhanglianjie@uniontech.com>
   message dated "Mon, 07 Mar 2022 09:33:33 +0800."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2940.1646774727.1@famine>
Content-Transfer-Encoding: quoted-printable
Date:   Tue, 08 Mar 2022 13:25:27 -0800
Message-ID: <2941.1646774727@famine>
Precedence: bulk

Lianjie Zhang <zhanglianjie@uniontech.com> wrote:

>From: zhanglianjie <zhanglianjie@uniontech.com>
>
>Delete SLAVE_ATTR macro, use __ATTR_RO replacement,
>make code logic clearer and unified.
>
>Signed-off-by: Lianjie Zhang <zhanglianjie@uniontech.com>
>Reviewed-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	Please do not add tags that individuals do not explicitly
provide.

	Other than the above, the change seems fine.

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	-J

>diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding=
/bond_sysfs_slave.c
>index 6a6cdd0bb258..69b0a3751dff 100644
>--- a/drivers/net/bonding/bond_sysfs_slave.c
>+++ b/drivers/net/bonding/bond_sysfs_slave.c
>@@ -15,14 +15,8 @@ struct slave_attribute {
> 	ssize_t (*show)(struct slave *, char *);
> };
>
>-#define SLAVE_ATTR(_name, _mode, _show)				\
>-const struct slave_attribute slave_attr_##_name =3D {		\
>-	.attr =3D {.name =3D __stringify(_name),			\
>-		 .mode =3D _mode },				\
>-	.show	=3D _show,					\
>-};
> #define SLAVE_ATTR_RO(_name)					\
>-	SLAVE_ATTR(_name, 0444, _name##_show)
>+const struct slave_attribute slave_attr_##_name =3D __ATTR_RO(_name)
>
> static ssize_t state_show(struct slave *slave, char *buf)
> {
>--
>2.20.1

---
	-Jay Vosburgh, jay.vosburgh@canonical.com