Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3481747pxp; Tue, 8 Mar 2022 15:34:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyveolqQhc0aVDa23b0sfShiswjeU6KdiZ4GWVbqmL3P+YUxqVBDnXp4I2wCBVgCfcs4mr X-Received: by 2002:a65:6201:0:b0:369:4a47:aff1 with SMTP id d1-20020a656201000000b003694a47aff1mr16140171pgv.238.1646782473038; Tue, 08 Mar 2022 15:34:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646782473; cv=none; d=google.com; s=arc-20160816; b=yfWHzCyLQELrDwUByFtn9tWCV/WqNNT2fFEdAY3ZcqhaH4rAkKQyTO6M83XHW/A0RU taao/DUdf3A4EA1/PhHoR5ajXSaXWt959jXLFsdO/FtrjrK7UEfxSyccF2zSAjU9+uG9 1/zjsWShMNpALFvOeB9LoFQ65TEJ76e556DfwYaYNGXjPCl84FkJ0VdZUK5DPCK3229O sHM0Mpd6XiEQvBFfZjEAvmQV0gPwQM4YWy9Gb5G1DWW0a1hC78Kg2Fz84ipnC7mRbwTr dtbOMnIVLx5BbqcbgoUHe3tcKQ2P0Ft/2evJTqGRQ+ZCHa8BSzT49LFxtIFDaUiH+j2k Mo/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=1O/m30lOLCShHOY1A8XX2vgIfOwS0B8Jqovd6Acndzs=; b=pzVlffa0Xkc27nC7mbQv2AkkxAWyE11kMpTCsUAWHE8DAPLhBtzX6ILoMn14fjk1Ox 3RwKveRorepLRt6gDdKwxAej+uh7UeZR+5lpgvrTgsBNWGwRDD+QplBXBNxi5rX4NOWh qLxACuBGRBTH8srARm2pqVbPCob4C2k6HFbQYzFf6g76iR6NFSjEpzxNQswOkxZuVf73 5mJDcMC6wIotWBrLAUvae6b8TTPLIgtby+WCZzS8mjwAFLexwQ9RBoVk0TYQXCt1hLAz MvArNPgxhiPXO9M/K1Ip7VGcEXiVOlJvGoc9FX2tgzu0CTjBv2liCr55q0LRGz5Y55Dk Gowg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=W4XYVgxL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id z7-20020a17090ab10700b001bd14e03043si3457058pjq.27.2022.03.08.15.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 15:34:33 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=W4XYVgxL; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 011346E78E; Tue, 8 Mar 2022 15:22:07 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344641AbiCHHiC (ORCPT + 99 others); Tue, 8 Mar 2022 02:38:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240331AbiCHHht (ORCPT ); Tue, 8 Mar 2022 02:37:49 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B3393DDCD; Mon, 7 Mar 2022 23:36:54 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id v1-20020a17090a088100b001bf25f97c6eso1596573pjc.0; Mon, 07 Mar 2022 23:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=1O/m30lOLCShHOY1A8XX2vgIfOwS0B8Jqovd6Acndzs=; b=W4XYVgxLwKHbbUQ+aUBXJkPLsPX3JtkXREow6Fiba+HR/WyIpmoenvdlRHXOGdyUO6 iqdFWgg5AiBZknmMYegY6mCSnol7mAf9NawWMrF12d1slobd7IKeWE2iXFXiEjRokKby 2bM/qznnZfqlJjWds/F+0rKHVuskGSCRk3T/dbU5/N99LvtR8SgScZldqy/Nb+n06fz9 ttSp7ZIx8JGBCSyKuNERnTP1wIry/uypK466WekRBDus/1uOBy2GG8gvqqOYukl/qF9D O6XoeV/Cd5TgSZbDxCNYG3wTlxUhl5K3QNvbHGUi0bYh7T+aSNR3H2TGHqYobZvuvgmx 8ltA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1O/m30lOLCShHOY1A8XX2vgIfOwS0B8Jqovd6Acndzs=; b=LvCGNAuQFIm20YUOwVHWUuaJhx9ajumgJOIo9SU6jmiZdaHWilu2S77PiZLEtdMKeA PHSp2sjZ0tI+Uey8uLRd40Aan3Piu/QmkS8JdpgGtSwH0vXDmgfjQXLPcygDRbg7EOje 242ercDJJ8P0eMnU/Yky7jukm8DIMfc1SNLU2XqQaRNF0fdaIikbw5n3b8ejsNheX8S/ xkWTVWvhB8UfIEeIgduK/tSc2Kc2Ls2DCK1x0BYM4qIeDjH6svUZr0X8Sou4TczTwOJP yq5Rpl0Vl0tYVHTSpCrqP77KRCDUVMrzFeYkGbE1ndXt6ugKbZzyoqfH4sG7G8hqeg0R Jk3Q== X-Gm-Message-State: AOAM530uSdS+ap1BlLHdf+0XFS20uYgXpBVS++hrrZTZigT8w45lMrEL uUp00fHnbUXLOWj6w1RtS4A= X-Received: by 2002:a17:90b:a41:b0:1bf:72b5:ae95 with SMTP id gw1-20020a17090b0a4100b001bf72b5ae95mr3277128pjb.110.1646725013502; Mon, 07 Mar 2022 23:36:53 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id ot13-20020a17090b3b4d00b001bf0b8a1ee7sm1800849pjb.11.2022.03.07.23.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 23:36:53 -0800 (PST) From: Miaoqian Lin To: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] soc: qcom: smsm: Fix missing of_node_put() in smsm_parse_ipc Date: Tue, 8 Mar 2022 07:36:48 +0000 Message-Id: <20220308073648.24634-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: c97c4090ff72 ("soc: qcom: smsm: Add driver for Qualcomm SMSM") Signed-off-by: Miaoqian Lin --- drivers/soc/qcom/smsm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c index ef15d014c03a..9df9bba242f3 100644 --- a/drivers/soc/qcom/smsm.c +++ b/drivers/soc/qcom/smsm.c @@ -374,6 +374,7 @@ static int smsm_parse_ipc(struct qcom_smsm *smsm, unsigned host_id) return 0; host->ipc_regmap = syscon_node_to_regmap(syscon); + of_node_put(syscon); if (IS_ERR(host->ipc_regmap)) return PTR_ERR(host->ipc_regmap); -- 2.17.1