Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 8 Mar 2022 23:30:00 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <UNGLinuxDriver@microchip.com>, <davem@davemloft.net>,
        <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: lan966x: Improve the CPU TX bitrate.
Message-ID: <20220308223000.vwdc6tk6wa53x64c@soft-dev3-1.localhost>
References: <20220308165727.4088656-1-horatiu.vultur@microchip.com>
 <YifMSUA/uZoPnpf1@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <YifMSUA/uZoPnpf1@lunn.ch>
Precedence: bulk

The 03/08/2022 22:36, Andrew Lunn wrote:
> 
> >  static int lan966x_port_inj_ready(struct lan966x *lan966x, u8 grp)
> >  {
> > -     u32 val;
> > +     unsigned long time = jiffies + usecs_to_jiffies(READL_TIMEOUT_US);
> > +     int ret = 0;
> >
> > -     return readx_poll_timeout_atomic(lan966x_port_inj_status, lan966x, val,
> > -                                      QS_INJ_STATUS_FIFO_RDY_GET(val) & BIT(grp),
> > -                                      READL_SLEEP_US, READL_TIMEOUT_US);
> > +     while (!(lan_rd(lan966x, QS_INJ_STATUS) &
> > +              QS_INJ_STATUS_FIFO_RDY_SET(BIT(grp)))) {
> > +             if (time_after(jiffies, time)) {
> > +                     ret = -ETIMEDOUT;
> > +                     break;
> > +             }
> 
> Did you try setting READL_SLEEP_US to 0? readx_poll_timeout_atomic()
> explicitly supports that.

I have tried but it didn't improve. It was the same as before.

> 
>     Andrew

-- 
/Horatiu