Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3496074pxp; Tue, 8 Mar 2022 15:57:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYPeSiNeOFwTeSdWim0MSlzgbh0ickM58AQLUbmApBcnUpa39g8tghn1rTKBQE+min3XLy X-Received: by 2002:a63:4543:0:b0:374:87b6:c9f5 with SMTP id u3-20020a634543000000b0037487b6c9f5mr16239262pgk.302.1646783836441; Tue, 08 Mar 2022 15:57:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646783836; cv=none; d=google.com; s=arc-20160816; b=jVbamarAmsyRcY6LwgrOwXMssQNPbvOSuC7QTazxpWsBBUMIHdcS6h4ctN6agJyIhE 0KlPqhscToBZdkXqBg34ppXoJ51xMLqo95Z3d0DKksKFY38Gvryjg87KXs0Ga6RJq67s 6quCN7de0AhIvfMJ0aNJ91G+0LernRsioExyDNMOjvzzYaBOYJEvf2/KrCZFBD7w+msZ vphlTAv285WiEOVICgt5DasBz77jDVMeWjqmgXWe0cjcA9m3Kk4Vl6N8VpHR3pl8Ug2p JUOTkrOw12Hrvc0vrYlmVS+NuuA7qur2y7va45I57vP+Rex8Gnk6EBtOPKLves58Ugv/ L5+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i7AoCPZjX8EcXcmu8+pXmdmkFDbCvm0vHt0f5l1KUJE=; b=dFq8slwIshaRdnm/Mad4tcla5dxG2vOhkv+9K7AhQuUGpWv/4tQgrVx+sO3rMAQe2+ Uk/Y9BRh0wrhuzdC8TxoJtzJVGCLQMzVRFa1U6kS+KiX1u1atB3Ln6w44SPu+7SsWcjL H8Gr10kAKIRSfyQ9/2cd8q4BrENyefztQlb5vMPG6sWL1pzBtJVDZSIX1DWPQxnrUPqN A/r1QzfWYSeoHtU1EQ6jtmmMUvbb7vLu93ke4Xs8w25a4KmbgmLBGGJ/o6tJvLCU+V6A 9StAb1qf8THrrx7LdwNdwV0vVlAOqLB1d31ShCidcI8S4/cEPJqinqW/YcBR9QcjgEjn 1vTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=EfDvoJU4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b6-20020a170902e94600b001516cec04adsi379530pll.248.2022.03.08.15.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 15:57:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=EfDvoJU4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4B85BAA01D; Tue, 8 Mar 2022 15:33:29 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344786AbiCHVWJ (ORCPT + 99 others); Tue, 8 Mar 2022 16:22:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234333AbiCHVWI (ORCPT ); Tue, 8 Mar 2022 16:22:08 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 920094C791; Tue, 8 Mar 2022 13:21:09 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id AAAE760002; Tue, 8 Mar 2022 21:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646774468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i7AoCPZjX8EcXcmu8+pXmdmkFDbCvm0vHt0f5l1KUJE=; b=EfDvoJU4KgnmtozSgKvLajcx77V1MmRGLq+Lp993CBYaxypHAapvgIPojbiXMf5kd9wFwy 1dp9zItaWM3zaHQh2OkVBwX8mBnR6WMZgsk8ju1QUNe7sVqWEoB0Qsv/E8eHpfpP6nG7ZH a5q0KQrNQvRwAKOpLpVNE2mG5kdZMIRLK3QdwUsfSPNBrJkFvPE8sDWb0Xa54SdWLZxD+/ edkASdwKhi2YCqq/jB56/zbrqgct1hJVGYNcJkxpG6LSuposnbJRxu3HFDzHxS8ZNgNdie fHzGnmRmOL0bhBjeWHIh4aCe7CXssjsWRtOsIeRAVwhaJiPSwpry1jGzifpc8w== From: Alexandre Belloni To: Chen-Yu Tsai , Andre Przywara , Jernej Skrabec , Maxime Ripard Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Samuel Holland , Rob Herring , Icenowy Zheng , Ondrej Jirman , Alessandro Zummo Subject: Re: (subset) [PATCH v10 03/18] rtc: sun6i: Fix time overflow handling Date: Tue, 8 Mar 2022 22:21:05 +0100 Message-Id: <164677445867.88674.16740426287923298243.b4-ty@bootlin.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220211122643.1343315-4-andre.przywara@arm.com> References: <20220211122643.1343315-1-andre.przywara@arm.com> <20220211122643.1343315-4-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Feb 2022 12:26:28 +0000, Andre Przywara wrote: > Using "unsigned long" for UNIX timestamps is never a good idea, and > comparing the value of such a variable against U32_MAX does not do > anything useful on 32-bit systems. > > Use the proper time64_t type when dealing with timestamps, and avoid > cutting down the time range unnecessarily. This also fixes the flawed > check for the alarm time being too far into the future. > > [...] Applied, thanks! [03/18] rtc: sun6i: Fix time overflow handling commit: 25c9815569cefd4f719c6c1266fe897e57642278 Best regards, -- Alexandre Belloni