Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3505550pxp; Tue, 8 Mar 2022 16:10:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJxKE2HsaB5kxYvYVK5NTSfoqWhbMgxfw2K4Q5+632+kxZItfYIiGR4MEV2KojqE4cgq3TJ/ X-Received: by 2002:a17:90b:4d8a:b0:1be:f63c:3dcc with SMTP id oj10-20020a17090b4d8a00b001bef63c3dccmr7465032pjb.133.1646784613075; Tue, 08 Mar 2022 16:10:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646784613; cv=none; d=google.com; s=arc-20160816; b=sFDy2pmtfYWzQwQd5oCUd2Tp98HQszfM7khWkkQagouX2YpBst8fscUTH7vvYu+hUN zIt41DkOslHOiXs+Zd01kvxWdbze9mf/8RpLrHlOgR7374MSbEXOUgorZRWxwmjdHchS k2dEa0+jhrqlQqp/Uk//hkn/L+sbPaR0rABLUOXtb7vYzICItJCkAahXTnz5XdNzM8Aq kmhwURaxy3s9hOBbuCJT5dnAXsXQjbbkEnWV9upAZtJQzWAZgh4VzbgB/jDHGCd9MLhe bRaPBtUzo9n+xlvmosqnd5Iy+t0K1rp6u0uaLL8hD6UTD+xzK0epQhNEmHNJUsnnUIXf yg0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=8wk0VED41Ez1MxTB1nfutzKsZHWBacVjnOCWnWpZFtU=; b=vCk0cWnb/byu2lJCqgGbuDQ32/p5M6Wj2ftj3dE7m4Op24bVb8D+Je3DvnX9VA18o0 99Ul2PWnLqLxhzDth3cMi7u0tvIJv5v4WUcQCringR0KLhnDgsHJIwAAE+HNh6wVMsy8 RE4kAn9wKWtwOIri10InFd56a9ymmR+zs39gpyot5lV/2BNJiALmYYk4W6n45Y+S9Cy0 P7ZsaqmQAOm6YcaVZj7vtfeaOLbGqZbYUejPq3oqKpBWCRX06iURd9jfeUBjLz7lXaTf uYM6nTDE7Tk//XJQH+MenGLyvNZsH9gUbvKlcCI07wYNOQmSyCFaDAfV045Uey5Hp3U5 TxUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tW64Ce1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m7-20020a656a07000000b00378ac5ba948si436785pgu.81.2022.03.08.16.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 16:10:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tW64Ce1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 96780EC5CD; Tue, 8 Mar 2022 15:40:09 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348684AbiCHRYt (ORCPT + 99 others); Tue, 8 Mar 2022 12:24:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349283AbiCHRW5 (ORCPT ); Tue, 8 Mar 2022 12:22:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5DE754BF2 for ; Tue, 8 Mar 2022 09:21:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E9EA161256 for ; Tue, 8 Mar 2022 17:21:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C297C340EB; Tue, 8 Mar 2022 17:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646760063; bh=VXtXZwmTg2CbEhaflPUS8x55Hns993/Kt31uJMvMLc8=; h=From:To:In-Reply-To:References:Subject:Date:From; b=tW64Ce1U/EXWJOzttKG02pKqy8yiAZ70nH7BuHMz+MNAdF4xKAk9EreguqHoWCcRM cjwQqF3L4KsOt+qTMEQCwZHJKe2t+FhbZoaQ7fYpHuydx9MDYwf1NN0aaP2ymzJNV8 3Ij3yHlCb9vnWoC2lSpDTQIgrVNGiZ1Z9WaJ8XY2VvziCg8VEqSwZ3JHbPlXW8s9LL tjHJa3rfNX8GmTa34F07Dej2TMTcWG75LyNtEGt5FL+8GxDv3FjqwptnClpjgtxUds TphFgFT8MywsNP4ofWThY1I9VFfw6XAOKV1ONQTUheu8WCHrh/Zkfx9cv6mUZ6QdDl 3kwuI5Kcm61Ng== From: Mark Brown To: Matthias Brugger , Tzung-Bi Shih , Jaroslav Kysela , alsa-devel@alsa-project.org, Jiaxin Yu , Takashi Iwai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Liam Girdwood , Miaoqian Lin , linux-mediatek@lists.infradead.org In-Reply-To: <20220308015224.23585-1-linmq006@gmail.com> References: <20220308015224.23585-1-linmq006@gmail.com> Subject: Re: [PATCH] ASoC: mediatek: mt8192-mt6359: Fix error handling in mt8192_mt6359_dev_probe Message-Id: <164676006096.54315.8478351478662604607.b4-ty@kernel.org> Date: Tue, 08 Mar 2022 17:21:00 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2022 01:52:22 +0000, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > This function only calls of_node_put() in the regular path. > And it will cause refcount leak in error paths. > Fix this by calling of_node_put() in error handling too. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: mediatek: mt8192-mt6359: Fix error handling in mt8192_mt6359_dev_probe commit: e45ac7831ff3e2934d58cce319c17c8ec763c95c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark