Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: multipart/mixed; boundary="------------0kTuiRdFeR90XioQw3UoZwvE"
Message-ID: <ef9d2a7e-932b-9389-ce4c-82b9d74952c8@gmail.com>
Date:   Tue, 8 Mar 2022 21:12:28 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [syzbot] KASAN: use-after-free Read in port100_send_complete
Content-Language: en-US
To:     syzbot <syzbot+16bcb127fb73baeecb14@syzkaller.appspotmail.com>,
        krzysztof.kozlowski@canonical.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
References: <000000000000cb6dd805d9b8cbb8@google.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <000000000000cb6dd805d9b8cbb8@google.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------0kTuiRdFeR90XioQw3UoZwvE
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 3/8/22 21:03, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    38f80f42147f MAINTAINERS: Remove dead patchwork link
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=14b0d321700000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=542b2708133cc492
> dashboard link: https://syzkaller.appspot.com/bug?extid=16bcb127fb73baeecb14
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=14a63d21700000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17d21be1700000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+16bcb127fb73baeecb14@syzkaller.appspotmail.com
> 
> port100 5-1:0.0: NFC: Urb failure (status -71)
> ==================================================================
> BUG: KASAN: use-after-free in port100_send_complete+0x16e/0x1a0 drivers/nfc/port100.c:935
> Read of size 1 at addr ffff88801bb59540 by task ksoftirqd/2/26

We need to kill urbs on disconnect, since urbs callbacks they may access 
freed memory

#syz test
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master


With regards,
Pavel Skripkin
--------------0kTuiRdFeR90XioQw3UoZwvE
Content-Type: text/plain; charset=UTF-8; name="ph"
Content-Disposition: attachment; filename="ph"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmZjL3BvcnQxMDAuYyBiL2RyaXZlcnMvbmZjL3BvcnQx
MDAuYwppbmRleCBkN2RiMWEwZTZiZTEuLjAwZDhlYTZkY2I1ZCAxMDA2NDQKLS0tIGEvZHJp
dmVycy9uZmMvcG9ydDEwMC5jCisrKyBiL2RyaXZlcnMvbmZjL3BvcnQxMDAuYwpAQCAtMTYx
Miw3ICsxNjEyLDkgQEAgc3RhdGljIGludCBwb3J0MTAwX3Byb2JlKHN0cnVjdCB1c2JfaW50
ZXJmYWNlICppbnRlcmZhY2UsCiAJbmZjX2RpZ2l0YWxfZnJlZV9kZXZpY2UoZGV2LT5uZmNf
ZGlnaXRhbF9kZXYpOwogCiBlcnJvcjoKKwl1c2Jfa2lsbF91cmIoZGV2LT5pbl91cmIpOwog
CXVzYl9mcmVlX3VyYihkZXYtPmluX3VyYik7CisJdXNiX2tpbGxfdXJiKGRldi0+b3V0X3Vy
Yik7CiAJdXNiX2ZyZWVfdXJiKGRldi0+b3V0X3VyYik7CiAJdXNiX3B1dF9kZXYoZGV2LT51
ZGV2KTsKIAo=

--------------0kTuiRdFeR90XioQw3UoZwvE--