Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <e4499a17-0278-5d16-f225-82217fb4f866@oracle.com>
Date:   Tue, 8 Mar 2022 11:24:48 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v2 3/3] scsi:libiscsi: teardown iscsi_cls_conn gracefully
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wu Bo <wubo40@huawei.com>, Zhiqiang Liu <liuzhiqiang26@huawei.com>,
        linfeilong@huawei.com
References: <20220309030916.2932316-1-haowenchao@huawei.com>
 <20220309030916.2932316-4-haowenchao@huawei.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20220309030916.2932316-4-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXlpOURQRyt5c0VKakdlSTBLd2l6U2lDOHVldlE5cFhQVjIxekFMMDFWYWl0?=
 =?utf-8?B?NGV0NjhrWXdKOWg1T2t2L1FwTXdlaDZYVDVJUzhEMHA5dUdlZ1NGRUxIYm1m?=
 =?utf-8?B?QUdjWjlGRnBZOGlTTEM2aGJHV0QwdzZaMGhyWnFFZEZyOFA2REEzNTkySGJL?=
 =?utf-8?B?RGtlazdDR2JDWURCVk5EWXlXMWY2RjY5bmh5NXpmTjB1ZHV1YUpKbm4rb3R3?=
 =?utf-8?B?WHhxbHJHV1ZuZ3FMY3JTVDhJdG9xY0hkVGpTSVR0dGpGeVl3V1NlLzdKc0hN?=
 =?utf-8?B?NWVyckdNTDdsSFBCdURnN0c5WGsrOHlHK1dmc1VFUTBoZXZvNHlKcS80RXZp?=
 =?utf-8?B?TWEvblVEdjlzMCt1U1kvQ2hwanZEKzJxNE5KTEhJZXhyV000b2VWaHNkNEVa?=
 =?utf-8?B?NjlmYXVKcHNFenY5NloxMXNJN2hIOGNadndSUHNxUzhHcHVBSjYrQ2syZFJZ?=
 =?utf-8?B?dEZ4bWVXTkRyMjBKWnQzRWE3Y2toTDlscmRYRUFvbkpnM2l3R1U2UDhaTXd1?=
 =?utf-8?B?WWVzTEg1K1hzdUNwWnk3RkZEZDBKOFd0aVR1ZjZwYWV1ZE5nbVlUcFpwZkty?=
 =?utf-8?B?Z2R0U1l4NUVoNVBjYXozWkJEZElkSEkvTDRDckNOSi9qZHM3YXV5dWZxZElz?=
 =?utf-8?B?KzlwOGgrd0NpMmcxQzQ5UzdxRUJuY0tIWHlEUFFWbVoxbWx5a09GcHlzWXcr?=
 =?utf-8?B?UFBLUjJTV2QyVTlqQ3Arc0ZpMkJUdS9jNCtsSi90UGlIQzFEdUtKSVJmcDA0?=
 =?utf-8?B?SDMzT1Z6VEM4RWtIc0M0WnBZeENma3hhVW1CSjhlUWFvSmt0MTRiMkFkMWhl?=
 =?utf-8?B?TXRyNFVmcko2S1BDSkhtYkhvMHMrYm1yMFVqanVYNzV3bks0ZEVPZko4a1BJ?=
 =?utf-8?B?bWpVYlptNE5mUEJab21FQldLbjl4ZXpOUFZPZnVVQldQYlQ1aU5sM1JBZ092?=
 =?utf-8?B?U1dHZUQxUlM5UXhtOVVzaXZGbEtVa2REOFZCS05xd1ZEUzU5TzFXb3dyMzNO?=
 =?utf-8?B?VjJaeTA2TjBxWG1SUWdjMXRya3VWRTQ1RFJ0bTJRa3o5ZzJRaFJPRkhqcmIx?=
 =?utf-8?B?UTkxNzF0b3RhTVpaVytlc3NvWHRhcGNlL0tXUzIzbkJFMGtRMW1xNVRpcVVT?=
 =?utf-8?B?Z2ZFQ0hkcjNDRlBOVDhrSHV4OTE4NWFUd0RMTEVUaXZCUXlLbDcxek1xa2VI?=
 =?utf-8?B?SjFXYjQ2SWE0bDZxOWF2R3J5L2lvTTBlbi9IbTNPZEZENEVkUEpRSmY5K3FQ?=
 =?utf-8?B?ZmxEci9iZUZQb0hMR1VLSHM4Z0NqOEYyRFFSaFBXSnVNeTdvdEp6NmppcjVj?=
 =?utf-8?B?YUJ4S3g0NFZWUGpIOEpYZWFvSUsyVGh2TWp5eHBhbmdJRUZRSDFtOHI2R012?=
 =?utf-8?B?cE1pRUhCZitnRnpQallQU2Y5QXVsRWE1SEFtQWVlN1RGb0lpZkhkRWxubGQ0?=
 =?utf-8?B?SHY4d0loWFVkRFdKQ1BTQ0dwc2JYaGxzeHhNOUNqK2NRYThSbnNrYjJPeWY3?=
 =?utf-8?B?MzRndHZ1Y2pTQkUzTUZyOWZ4VG8wMXYwdW5Ieks3ajRVendXWDhtT3BXdDlp?=
 =?utf-8?B?RnpQd0VBbmVOMHRtUUlkeDB0SmRWQW1jSzBXVm1WVTlDMXhsVTZIWnpOR21Y?=
 =?utf-8?B?RlUzcytYeld3NVBUMVIrQzJSZitHaDNaeStRVmhiZlQ2YXo0Y0UwVnZld0wr?=
 =?utf-8?B?TWh6VEN6b1kySVZnWTdSY1RlQUd2aGc2WXZhaFcvYVVlUDc0dDREd2FjRkpV?=
 =?utf-8?B?MUl0ZjlPZEE4SW5qUjY3d0VzYTh6TUtuZXNCbVd5eTRQUGxrS0xYWDlDV3dq?=
 =?utf-8?B?bW04YTZkSjVDMndBOXVvb1VFVWtnRTA5cnNtUmFKd3g3V0U4R1prUFNVQzkr?=
 =?utf-8?B?NTJtK1Avd2VVZThJRUFiSytHM0NmN2NNZTF5eDN6RExjUWlGK2RRYmNPUVpE?=
 =?utf-8?B?OWpTeGQ0WTNSaFNoUk9IemlyWUE2TGF6QUI5aVJiUkJlaC9kY29yQ1E2WW5z?=
 =?utf-8?B?NmJLdTJqN3N1c0pjY01iN0VaR3Q5WXpKdysyc0cvMXhTL2M5UzZhWE9LNjdV?=
 =?utf-8?B?SDJQSGI4N3N1ZnNHY0ZqUEljKzdUcXUzN1BmUk1jeGJLakxuVzJJOUZxVzU4?=
 =?utf-8?B?Q1dUUE03alZsRmVwcE9BRU1kRlFBS1htSkp3WSt3bExXaitzN1NRMlVPZXNW?=
 =?utf-8?B?eGxOM0V1akRzNTNObVpCZXlpWjBsOVZlNUlGMWx4ZVZCdmQ3Q0xoZFp3Z2lJ?=
 =?utf-8?B?TVF5WEQyMmNacFF0LzRGaWV0MDF3PT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c330e603-761b-4898-592a-08da01288d51
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 17:24:50.8522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yuOV/YTrfeM3ELxmajOrsez/rWFIJT5ugJ5Sjk5tjsgJ6rCpBo9m19vn30nSXYhSQxyK+wf192KLAJyPexAJQXdCCrlU+a0M2KzWF8wJuGo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4064
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10280 signatures=690848
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0
 suspectscore=0 bulkscore=0 mlxlogscore=836 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203080090
X-Proofpoint-GUID: J8fOavkFQEIzGeQyz32AvKvqD_gBN8cl
X-Proofpoint-ORIG-GUID: J8fOavkFQEIzGeQyz32AvKvqD_gBN8cl
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/8/22 9:09 PM, Wenchao Hao wrote:
> @@ -3143,8 +3145,6 @@ void iscsi_conn_teardown(struct iscsi_cls_conn *cls_conn)
>  	mutex_unlock(&session->eh_mutex);
>  
>  	iscsi_destroy_conn(cls_conn);

This should then be a iscsi_put_conn.

So basically it balances out.

iscsi_alloc_conn requires iscsi_put_conn. The put releases what is
done in the alloc. The put on the parent is done in the release though.

iscsi_add_conn requires iscsi_remove_conn. The remove undoes what
was done in the add

We don't want a iscsi_destroy_conn which does a iscsi_free_conn
because it makes it confusing.