Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3531575pxp; Tue, 8 Mar 2022 16:46:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJzUsPPaQw3IMmiqm9ijUncEVQri7hq5KrQ7ami4kjT4TrnzpjfqJYsFJX8we8w3bmBjCj6Z X-Received: by 2002:a05:6a00:2402:b0:4e1:3df2:5373 with SMTP id z2-20020a056a00240200b004e13df25373mr20743043pfh.40.1646786804266; Tue, 08 Mar 2022 16:46:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646786804; cv=none; d=google.com; s=arc-20160816; b=VnPVPmfCmjJWa6hxystmwfMiOedjvPLnUnT1l/yDg4t9lAIoblmY068RDsQTv7LSwo uoDdUSScPui4B9ofFMeJHY4dBCdnlXAefTKqTNNotqFGaf82bLGQjbqX5ehZLMawJsqY /Bj1HtsnzUt/3sU13gCxkdZr0+6VHbZauTp+AXc7h5kwXE0l6Wz15meXidIHtZqQmdzA wVdqo3yhr+ElPC2tX6VyNs3GxIPvxz+//1pQ86pCZnKaJYuT//lmlc38uJ69IkdCqBZi IiMkdYgFlamB1o4BJV6CBts/C2y4OZ3kyMUBRbQi3wJW6EmSR8XMp9EdEoHg1Rbn/Oh/ XRTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ar15UUDK0Uj3i4vSimMBwYtNvLRx//2YEMokZ7LBbRI=; b=atjMudtfHemnDVLJ1LCxF+t1y5YIn0+9+9hnJmXWpcwSDvgibzmMgXlBGHB8ow59yG 4R9ItbibtjR/FCrK+xfA/psDnGCppOdrAKODXE2msLu99pHuV9i/z6hI7ylU9rGmoN7B G8yyAD64coFFSmz2YyB7IhKsGY3AMDqkOCM1/C3sWEqN+j7tk4DGhmDuHhDg75jnEN0E 4zsy/hTaknRiFNN9hgdDqv0pnLuaPGoiMhlJ6f/DzsauYH3A9YDFnRWDTkSnIzUkKX3s 3vkvgNoRrNjgd+zzIdMaW5TlzLO2ZDoTr81Ng1dW1Rkl1n5WdiQKXe0yeCueGvpmiVC9 aWig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=CGdSBasx; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 8-20020a630008000000b003801180a0c6si358351pga.849.2022.03.08.16.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 16:46:44 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=CGdSBasx; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BFAD813A1D3; Tue, 8 Mar 2022 15:58:56 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348045AbiCHQjy (ORCPT + 99 others); Tue, 8 Mar 2022 11:39:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245549AbiCHQjw (ORCPT ); Tue, 8 Mar 2022 11:39:52 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0793A5132A; Tue, 8 Mar 2022 08:38:54 -0800 (PST) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0CA0460014; Tue, 8 Mar 2022 16:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646757533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ar15UUDK0Uj3i4vSimMBwYtNvLRx//2YEMokZ7LBbRI=; b=CGdSBasxLK8ws6pqdxTtNm/Kj+xIGifjs3ojexJj4p0PM2gMol1iA3t+MpBM7d36pfyMOL a7C51irNJnLm3wAYQlnvcj4TPomMCRdASX4AXZ1OymKm+YUX/2Gn4UDbsjA3on71s9vi9I yDhVWPZ1/MjxwcHlpayeH7P7Qmcx1JIiGeQgoByXGcpFhdm+/pCupQZsEi3hAwLGhk72y2 k8UOTwnz2j8FB7GLi/y2gKj0TqI/XlVlEIscNe+FSiqXRRFz0zlMM4e7/kR6WdZSDioFqp A8+kcCixoKuwhJC1osJNcN7KIEOeG1vOwlR4WTpWDHGobNXqkXGnxxG79gHtHA== From: Alexandre Belloni To: linux-kernel@vger.kernel.org, =?UTF-8?q?Mateusz=20Jo=C5=84czyk?= , linux-rtc@vger.kernel.org Cc: Alexandre Belloni , Thomas Gleixner , stable@vger.kernel.org, Alessandro Zummo Subject: Re: [PATCH] rtc-mc146818-lib: fix locking in mc146818_set_time Date: Tue, 8 Mar 2022 17:38:52 +0100 Message-Id: <164675751806.57812.5024159758490370034.b4-ty@bootlin.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220220090403.153928-1-mat.jonczyk@o2.pl> References: <20220220090403.153928-1-mat.jonczyk@o2.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Feb 2022 10:04:03 +0100, Mateusz Jończyk wrote: > In mc146818_set_time(), CMOS_READ(RTC_CONTROL) was performed without the > rtc_lock taken, which is required for CMOS accesses. Fix this. > > Nothing in kernel modifies RTC_DM_BINARY, so a separate critical section > is allowed here. > > > [...] Applied, thanks! [1/1] rtc-mc146818-lib: fix locking in mc146818_set_time commit: c63cdb340a7e0bd3734f9f8e27f082a054b45887 Best regards, -- Alexandre Belloni