Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3533751pxp; Tue, 8 Mar 2022 16:49:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJysNLKW1Ua1U+5YT4Foam6a/0ZMzBELNtaChVSP6NNZwbBjk/C7C0BD6nvZOIa/IqOLqFui X-Received: by 2002:a17:90b:1d04:b0:1bf:48f7:7e73 with SMTP id on4-20020a17090b1d0400b001bf48f77e73mr7576513pjb.31.1646786995677; Tue, 08 Mar 2022 16:49:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646786995; cv=none; d=google.com; s=arc-20160816; b=q32aBUKztr34HslwUNc3lN3mVtXDUMzJa7FTdVVZypzSynshFMYrGOtqks6jFr1upx WeYlZGoPciDnfsOL0jLRBAnd/LMkdC0+vY513Fmvf9acBUzxXCrphVxByZU03K/4JxBL Pd7wrelypwn2vB8a6QavjYh0XX9eEa8MeJdiktO2S50J3VFbBlxlONQ/JyZi2rKglVb5 4V0kfNanRpjUp2zZNcgeUfIIb2GY4E0ZM8pyUyT9YV/rc5M75qwJ1AtSLZu+4IX5S/mQ F8djExUPFgNju7ANnY/0CwjoUbgEyCKYQoRLNV0FZuiJ/VbnAuIq5aBliDpQPbEJsLdW Nl1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NhX5SlYl7BXLmMZAasTyx4ByzRymbQLodzBvBVJqn84=; b=tOPMRBAeCfQrzJmY11Dla7BINLNo3FOY2kjAWj1UoqeZ6wZzBpPOZUaFVSxN0vkKu0 asfPKYyqwDWszNJVM2YrQ7FW0aGVdG2gu2DuK7fSo+sQOkSFNavw/gDjoOMY1RJocNsI hElmw8zAf67dCziZxRxq6OBwOcCQA0dBCACynY/qKsR1isCfKfz5ByWNOp5Rmc9bGN7g ZM2JB85jMPyZ/2lzqGXbR13EwHqTdoqN6ZIfxlWmAKT1dp5mOSGBE2HvcF6uIlz1kQah 1RtOEILv4d5JdUe3FWcADM15Ir3s8kZCXOKldzmyp/4NqM1t+Nom/6FdkTlWAueFpeCl YRzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YFKkSZN5; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d1-20020a170902854100b0014fb63d5d9fsi432055plo.73.2022.03.08.16.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 16:49:55 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YFKkSZN5; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9F37B14A20C; Tue, 8 Mar 2022 16:02:22 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344055AbiCHALc (ORCPT + 99 others); Mon, 7 Mar 2022 19:11:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241125AbiCHAL1 (ORCPT ); Mon, 7 Mar 2022 19:11:27 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4096F1CFDE for ; Mon, 7 Mar 2022 16:10:18 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id q11so15499649pln.11 for ; Mon, 07 Mar 2022 16:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NhX5SlYl7BXLmMZAasTyx4ByzRymbQLodzBvBVJqn84=; b=YFKkSZN5IsoC+uHTyxgHguq+/wJgkUo4bsSgIDnrz0qlLwM6zV1HBalJ2kha3O/owJ LJmHd4tfW2regTgvT0rLqWpbvn9pJ/Vv0B6JBEy4/AEB+LvnKAtudJkxXyD8mO+wmytX PcqNKd+sH5JSzBCBpRfrOAwrGbAL4obRvkteQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NhX5SlYl7BXLmMZAasTyx4ByzRymbQLodzBvBVJqn84=; b=aH+E5G29Vn5lQuscVCo6Jx1VqwhUoIJqJDHZ6doTIXwXzptQkJRULvM1NjeKJCBCKU 1e76Qbpi5iVllN8+gk7pClA3ATpSTtDFQTB6+YwM4C1ZT1ZUdCaC5TFvoyaoZ80fgkiA 4abwcZyAQza4MFWtU00aSVeRBYDmf7HF88RF3sYv+ZbAGC/tM9uqq4NUJ5Yb5zdPIfG9 qCkWuq2QWJq47ttlXZ6OjSXMZFJxUTCQq3XbIQblmUK2iFsDjRBz/172iXa6gE53TUMb 5XVlspmiZhsyklNYeQHDmWgtKNCXBPrxD59n+mgXvY3nBEoTkAX9z7bk3r6u/eYIALRF Wizw== X-Gm-Message-State: AOAM533Sp61O8jKc432RgtLaeox8Cy0+r/FFT/ZJF5M/b2egGzK5SCuO 4oYOFcFbciJAVpPqG4IfRScZCw== X-Received: by 2002:a17:902:cf02:b0:14d:54cf:9a6a with SMTP id i2-20020a170902cf0200b0014d54cf9a6amr14320856plg.137.1646698217819; Mon, 07 Mar 2022 16:10:17 -0800 (PST) Received: from localhost ([2620:15c:202:201:e551:44dc:2842:57f1]) by smtp.gmail.com with UTF8SMTPSA id ic6-20020a17090b414600b001bf691499e4sm463733pjb.33.2022.03.07.16.10.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 16:10:17 -0800 (PST) From: Brian Norris To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring Cc: Lin Huang , Heiko Stuebner , Derek Basehore , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Brian Norris Subject: [PATCH v3 06/15] PM / devfreq: rk3399_dmc: Drop undocumented ondemand DT props Date: Mon, 7 Mar 2022 16:09:36 -0800 Message-Id: <20220307160918.v3.6.I4bd77eb751d5bfce8346bfed576bcacb28e4550f@changeid> X-Mailer: git-send-email 2.35.1.616.g0bdcbb4464-goog In-Reply-To: <20220308000945.706701-1-briannorris@chromium.org> References: <20220308000945.706701-1-briannorris@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These properties are: * undocumented * directly representing software properties, not hardware properties * unused (no in-tree users, yet; this IP block has so far only been used in downstream kernels) Let's just stick the values that downstream users have been using directly in the driver and call it a day. Signed-off-by: Brian Norris --- (no changes since v1) drivers/devfreq/rk3399_dmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 293857ebfd75..e982862f6ac2 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -430,10 +430,8 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) goto err_edev; } - of_property_read_u32(np, "upthreshold", - &data->ondemand_data.upthreshold); - of_property_read_u32(np, "downdifferential", - &data->ondemand_data.downdifferential); + data->ondemand_data.upthreshold = 25; + data->ondemand_data.downdifferential = 15; data->rate = clk_get_rate(data->dmc_clk); -- 2.35.1.616.g0bdcbb4464-goog