Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 7 Mar 2022 20:16:33 -0600
From:   Chris Morgan <macromorgan@hotmail.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Lee Jones <lee.jones@linaro.org>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Wei Yongjun <weiyongjun1@huawei.com>,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Colin Ian King <colin.king@intel.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rk817: Fix missing clk_disable_unprepare() in
 rk817_platform_probe
Message-ID: <SN6PR06MB534299BEE805BE9B6AFE7C3CA5099@SN6PR06MB5342.namprd06.prod.outlook.com>
References: <20220307090146.4104-1-linmq006@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220307090146.4104-1-linmq006@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c5ef12b8-9e3f-4e36-b1d3-08da00a9ab7c
X-MS-TrafficTypeDiagnostic: DM6PR06MB6089:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rOJZHZPzespSmELf/anBpwp7y1U39J/beej7/xTjiTnP6HwCDVxPx/mUhENuWL3Fb4yN58bkahWcgpPTIivjq0i2xSZIWAApikTxWxEFP1BbJ6XQg/3dOgShEcv0rWpMRq6Cp2RpexaXxxdqmboNcJ7zrhThWssMxXyoefY+C+5MLgso5zozSAqSF6D72sA00D0AV1gBdrTDs5qevWKJV4DESA8jnGyHqAyJ98CEffqvKYYYHP0qARKp40cDDkktoWtqg314iV/1MvphLucgR6BlRoE9cb7iGcNXTHdLu0s7+L8K47af0woNsomOKVnNqjFR252+g6HDwVoONfNhxX/lvdcDxUzCIdp9x+YK5fPcE9b76lYJHkVXO9c4w/14eRuTKwiXICp8IBUTSdr+PR84PLMCtNU4jlJHDLU4+fxp/HuAXqLlvgtpL5gzYAg5PR/V20ZQvaHOUJ9IzS/BX9qCZab9D82/ShS0cpx6KS5FtGrxfUgqNzCapS4T7in+RSyBIJhOnbQx91DBT1JDMg6lqH2ZSexyqz3aEMLGTfd4znqhrCWuoRNNjXqhPr4OVTTWGKI0iOXk+MhlUlwfNA==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wj1TImxKsxSONpu5gwKdEjB+OVGPGBGakzRRN3yu0sUKgJprWnnod0vxKCXF?=
 =?us-ascii?Q?CwI2aoE95Y1Eryc72qOdC0gJexckbY2NuDBO+LQBwV4+l8pgkbraysBHaSmW?=
 =?us-ascii?Q?dhpKORv0oZu4zJ+jt0PTmlZSeVRJxhYJ6LUG84CiH2obJPVOAp9QrVSgSmW8?=
 =?us-ascii?Q?T4KG+wnMjjT73nXYHG2WOUdwmDxh/MNpy/mAy7tVs9tDaQYXBqLbsCRkRtxQ?=
 =?us-ascii?Q?ML3c1rAHrN+tECdzds52BrRK55ZIPbqRuklRdUrCd427PVScoKI5N9iCa6it?=
 =?us-ascii?Q?L/8cAwtcQd6eBnCCIjI4/ve3gwCrR/0W1QTFqIYl26IkTBTde9QsZT8xPpVp?=
 =?us-ascii?Q?QvpynuqDvrBEuF5E9xG5R9xgDr+WKZ7vIOQjUPJg+wYWBhat3cb5cg8vHPTm?=
 =?us-ascii?Q?1UVNRBJEKfOAL3G94Z0yKumecLkTwwRGTnH+n5NjxmyHZZcE/7yeLLQeLAjS?=
 =?us-ascii?Q?gJim/8HpMRRn18R/5baA0EmVFmCQ9NFJMCyjAFLOau/EzshrTqzeEdoGgNll?=
 =?us-ascii?Q?g6G68A9ZFnUvPTDckeCu8pIG62/6I8C4JP1y7Rv3zvQR82Qc87LBw4TqC3DO?=
 =?us-ascii?Q?7eO4sOTLvzDzdzR+4YE/L/zAOa/vxdzShU5XYYb2Y90yTxwlQX5tO+Iw9mZp?=
 =?us-ascii?Q?7B/TGFevPqorvq5y7XdZkXZNah5Zf0gsjrupPKlHzW4d+cPRLQgX4KpfX91A?=
 =?us-ascii?Q?BFyOdhzFrQR0XOCxQB0O15udfxcDkGQhXGUC3Q7wiTlMeJ/CobaNK+PswoZy?=
 =?us-ascii?Q?3BWi/pdmFDDHLj8tOZ/pi2XcQiRAIRr0pdJG7PEQv4EUSAhwA0vXC26ETqmj?=
 =?us-ascii?Q?SnLELMs/fxIjDK6szVJwndLRh3bCrxsQxsCFJ4x4z6lBT89CXUdnbM2nfubw?=
 =?us-ascii?Q?Jocb77QDWXdVHfysiFO6uTbuI3cW0WtFkcPg9WM3KcDz1mI/SMBNNKQ+aOhe?=
 =?us-ascii?Q?zCSBmuX0NX7vYhcWQiDJpg=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: c5ef12b8-9e3f-4e36-b1d3-08da00a9ab7c
X-MS-Exchange-CrossTenant-AuthSource: SN6PR06MB5342.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2022 02:16:36.0082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB6089
X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FORGED_HOTMAIL_RCVD2,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 07, 2022 at 09:01:30AM +0000, Miaoqian Lin wrote:
> Fix the missing clk_disable_unprepare() before return
> from rk817_platform_probe() in the error handling case.
> 
> Fixes: 0d6a04da9b25 ("ASoC: Add Rockchip rk817 audio CODEC support")

Tested-by: Chris Morgan <macromorgan@hotmail.com>

> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  sound/soc/codecs/rk817_codec.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/rk817_codec.c b/sound/soc/codecs/rk817_codec.c
> index 03f24edfe4f6..8fffe378618d 100644
> --- a/sound/soc/codecs/rk817_codec.c
> +++ b/sound/soc/codecs/rk817_codec.c
> @@ -508,12 +508,14 @@ static int rk817_platform_probe(struct platform_device *pdev)
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "%s() register codec error %d\n",
>  			__func__, ret);
> -		goto err_;
> +		goto err_clk;
>  	}
>  
>  	return 0;
> -err_:
>  
> +err_clk:
> +	clk_disable_unprepare(rk817_codec_data->mclk);
> +err_:
>  	return ret;
>  }
>  
> -- 
> 2.17.1
>