Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 8 Mar 2022 16:44:29 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     hammer hsieh <hammerh0314@gmail.com>
Cc:     linux-pwm@vger.kernel.org, wells.lu@sunplus.com,
        devicetree@vger.kernel.org,
        "hammer.hsieh" <hammer.hsieh@sunplus.com>,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        thierry.reding@gmail.com, kernel@pengutronix.de,
        lee.jones@linaro.org
Subject: Re: [PATCH v2 2/2] pwm:sunplus-pwm:Add Sunplus SoC PWM Driver
Message-ID: <20220308154429.ztv3l42euu2hf3ye@pengutronix.de>
References: <1646374812-2988-1-git-send-email-hammerh0314@gmail.com>
 <1646374812-2988-3-git-send-email-hammerh0314@gmail.com>
 <20220304185702.i6csx2r3mokfmr6o@pengutronix.de>
 <CAOX-t56cycXMga_grJcpmSG68ve5-RuTsbtaEQi9Ui0A+5uhSg@mail.gmail.com>
 <20220307131018.6wrdsiixmgdtnodt@pengutronix.de>
 <CAOX-t56F2u_1=tA4N4Wvicw-e9J4ksN__J70QZtjZwJRjgesUQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6f3hgpz5jb2dmeu5"
Content-Disposition: inline
In-Reply-To: <CAOX-t56F2u_1=tA4N4Wvicw-e9J4ksN__J70QZtjZwJRjgesUQ@mail.gmail.com>
Precedence: bulk


--6f3hgpz5jb2dmeu5
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Mar 08, 2022 at 08:03:55PM +0800, hammer hsieh wrote:
> > IMHO yes. (Though the most likely error -ENOMEM, in this case no error
> > message should be emitted.)
> >
>=20
>  ok, will add error message like below.
>         if (ret < 0) {
>                 dev_err(dev, "failed to release clock: %d\n", ret);
>                 return ret;
>         }
> or should i modify like
>         if (ret < 0) {
>                 dev_err(dev, "failed to release clock: %d\n", ret);
>                 return ERR_PTR(ret);
>         }
> i didn't find reference code for it, not sure which one is better?

It depends if you return a pointer or an int. Also please make use of
%pe instead of %d for error codes to make it easier to understand.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--6f3hgpz5jb2dmeu5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmInedoACgkQwfwUeK3K
7AkJKQgAhvEhvRse9Q9dBf2kr2xCcHcFD66QcDDAt8vq4hxZNJPKwmx19iZRE+En
TbbFIYldZshOH3eQvl6C9eEGtO5xiW3MKWgWRxjy0dngINIO3UqyxmmwnlY4FgWF
69sWMjvx0yB3zw14/zU+UgPsc7j03yb8DwpLGFWCgKgzzLb1n+nCLrupYe33Ph1n
BJWMD2Y97/GYlH4Q8OKsO3IyYr6qkoNB4jYVupb40JHI046EBjWQ1u2xUxGsuKcn
cCylifL66UXWsVs8Cl6n9hpiwg0jKM04H1Jwqz99ak2hz2OKcrbYGjdPtxYL3LzN
VIVavWS6prPerd+iJD+vDMd2B4fm7A==
=4RJz
-----END PGP SIGNATURE-----

--6f3hgpz5jb2dmeu5--