Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3572842pxp; Tue, 8 Mar 2022 17:48:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJybeFRPnhsiypojdR/BChkJfB/J6kKVgRH4rTly94DvG9O9L1kOxW3fxl5w5F0aVqXjKU0A X-Received: by 2002:a17:90b:4d05:b0:1bf:7d65:f1f7 with SMTP id mw5-20020a17090b4d0500b001bf7d65f1f7mr7922393pjb.108.1646790481137; Tue, 08 Mar 2022 17:48:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646790481; cv=none; d=google.com; s=arc-20160816; b=d9BLTfe7yfBgPUjyvvnlKsv6RXQaOUHBifsh+MXl/v0XGc9Qq170tads5HwMB2FX+5 vtzI+6Z1p6ZyCw1jlJGIkk+ovu7ap0WvEUqZg8u7jnJo53X0RR3gdfDw8YcuoU1fG/C8 Z6sJDJP0ljyUQfUQ1TiZiiA+57tdvTSZmizKVaed9Zd1mJwVRKTJXWg5guWy9UvpYFVM /QRL2w3uJ9g/7e1Kpdi/KT3oZT3YD/xg7irutvWtsdjtqYHl651FpRPx2g9vI9zyZSKt 8gW48OBNRZTxVSS0VkOxcrTOBH+p6+AmiZSQpMReztMJm60cGiF4SJl/QSG322v0Imbe G/+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=yWhY8qlsdz7JCpSZpDlipoozq4SQyuAAucvDJGO5X2A=; b=jWII/+djjBDHWlmF64V8zxx8smu4I8VMXuyta0KRqvRaq9EwmRCmVWMurR6kimKPzl JhBHP2eWbuRXVHpDxCqmasovszkJhe8vXbXi9Z5v/rXWdKzgPtmwULeGKIjlWiWAyDZj fKo+d08CRbkaFV6FFScl2EvqD74PlJ8pcTGcbwd0qEePaPrKPz/q9uGBewZ5/ZmSD5T7 ALAOlbIR8XLhiB9SbhaAMXNazH02/E9UQ+kQomWvw+hdKmz/823JSROIJrmzVqkBnWc6 o5t2Sovg6Er1PHkeytq5smooicIT8zMuVZ/qyVlEOlVUOvStdEb3vpYPtyk66S7w2WoD I2dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I18vN8/I"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id 4-20020a630c44000000b003739f49a7e9si507188pgm.488.2022.03.08.17.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 17:48:01 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I18vN8/I"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 556151D0370; Tue, 8 Mar 2022 16:24:55 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350227AbiCHVEm (ORCPT + 99 others); Tue, 8 Mar 2022 16:04:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343684AbiCHVEl (ORCPT ); Tue, 8 Mar 2022 16:04:41 -0500 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6175647067 for ; Tue, 8 Mar 2022 13:03:42 -0800 (PST) Received: by mail-qt1-x832.google.com with SMTP id s6so249094qtc.4 for ; Tue, 08 Mar 2022 13:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yWhY8qlsdz7JCpSZpDlipoozq4SQyuAAucvDJGO5X2A=; b=I18vN8/IGEzuef44T7UgjcAGV/5fB8EmlgFJQNIRCsZvpnXLXns+WsL3tlcx5x3Sa7 +EbPcoWiByB4/+7WqmKvv+JHeQDuLq1xTe83ek4BHXiWHrfM5pmZJyc06+SoudkVM7E9 SCYmq+1SCmnIoSI1yIa4dYQ2Y8nFz+7z6zsu9kqb1ygxFXjg91duNvBVMunZ0YrW6Nl2 Cby3t19bnzEOkLdkKDXVJLufP1M8N8qcr2Ppt6s5DHCb+QY6yjchRWl4FUAJC0xU5XqW tOSjDLYSMrSAhMDXF1tErKpGWljGB1tldoWc3aSuy4ZPwAjLgOE14hj5T9XM89bg6Li4 B2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yWhY8qlsdz7JCpSZpDlipoozq4SQyuAAucvDJGO5X2A=; b=Z3NXcry/Omt24dBpMvUwKNss7t3tBrSczqTQtcG7AZhWuoM706pqgqpEOKOCXzb235 ELleg8SNKDQWZpK0zyoGwMOZxGJFBtegd4+v8ShO0PvEUPoG2481cZC0I7NM4IpOiicd LonMJs3pPJOas1slyelR+LgCYQeFoEalCL4qikX+2iMONejC/keHVf5pCIhgThRhAYEQ 4kQUhHvlgcZsRc0SExdi2ndeMcvDirLUgSvwXmyZjLr//VkVDVDALRE+oOgO8jakW5lK jOPJWh9bZJS0nWAkzfA2L2VmP+mVcUa4Vl10goE03SKWriHt8K+rUHEI7ibVxyBF0HF6 D46g== X-Gm-Message-State: AOAM533ssj6z9OACJHNDoo+RJKUsuyiDK5frS43vZ/+dOJbJhkxjXqUR baH3nViKMmlu2sOGxCBZ282UrW6/30Qj8OXPiUvC3A== X-Received: by 2002:a05:622a:170d:b0:2e0:7148:ec14 with SMTP id h13-20020a05622a170d00b002e07148ec14mr3907614qtk.62.1646773421537; Tue, 08 Mar 2022 13:03:41 -0800 (PST) MIME-Version: 1.0 References: <20220308184844.1121029-1-robdclark@gmail.com> In-Reply-To: <20220308184844.1121029-1-robdclark@gmail.com> From: Dmitry Baryshkov Date: Wed, 9 Mar 2022 00:03:30 +0300 Message-ID: Subject: Re: [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support (v2) To: Rob Clark Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Linux Kernel Functional Testing , Anders Roxell , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2022 at 21:48, Rob Clark wrote: > > From: Rob Clark > > Avoid going down devfreq paths on devices where devfreq is not > initialized. > > v2: Change has_devfreq() logic [Dmitry] > > Reported-by: Linux Kernel Functional Testing > Reported-by: Anders Roxell > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 30 ++++++++++++++++++++++----- > 1 file changed, 25 insertions(+), 5 deletions(-) > -- With best wishes Dmitry