Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Tue, 8 Mar 2022 20:28:26 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Lianjie Zhang <zhanglianjie@uniontech.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] cpufreq: unify the show() and store() styles of
 attr
Message-ID: <20220308145826.2s4gc2m3feqvgajl@vireshk-i7>
References: <20220308140917.56923-1-zhanglianjie@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220308140917.56923-1-zhanglianjie@uniontech.com>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 08-03-22, 22:09, Lianjie Zhang wrote:
> From: zhanglianjie <zhanglianjie@uniontech.com>
> 
> Usually /sys directory under the file, the corresponding Attribute
> contains .show and .store, and their naming style is filename_show() and
> filename_store(). But all naming style in 'cpufreq' is show_filename()
> and store_filename(), resulting in __ATTR_RW() and __ATTR_RO() macros
> cannot be used to simplify code, So need to change naming style.

I haven't received the other patch.

Since you are going to resend anyway, I think you can merge both the patches and
instead of the "Unify" part, just mention that you want to reuse the __ATTR_XX()
macros, and so renaming is being done.

-- 
viresh