Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3581306pxp; Tue, 8 Mar 2022 18:01:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxafDytYJ8yT/x30Y3np/ermmGLDb6OFB9Aejc+c4ejrdJJ6jJSGYortSqpbV2hzF98wRmA X-Received: by 2002:a17:90a:1d04:b0:1bc:98ca:5e6f with SMTP id c4-20020a17090a1d0400b001bc98ca5e6fmr7989237pjd.32.1646791281053; Tue, 08 Mar 2022 18:01:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646791281; cv=none; d=google.com; s=arc-20160816; b=uz2izBlitLF1R4rhsNNlUaTo9dJu9jBVexXnb/DP71I4m9LQpyDKZbyz648/gqT8Wz gWnMe59MXJhxHt/aM1w+3uFmbboTNdWoFBR/IXhk7hu3WIpQMtimraIDtbzbUi2IhuTS WNeDDCpElCBq+2UqMNOAY8zuy/MUS7EIy/RlJ+mAEgDdGZyAn3qB7R+jLWYrtq62AvSh UUT8dTbEWqM2mijizUiIBb8XtskwJu1V43seZO1fADnPPCMnRyikJ2m+GE4cXuA1QTqg HVlDEvFTEXffI6sY4Cqc92EuROD1nQsvsgc06fjNUyUYj5wAYwQVN2rXQiGHhyKtXCIh pgBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AjPBz4hPKZNi0+K77wDlgarahEsq3zjFXjg3hyEPz84=; b=Ztwg2HFD3AT71iytHk0fMe3qy4sXkF++clda88sHb2tX9f+zJiVOj9L/hiGXYafeCf vHs8+oqfH91d+CgtVHc6HSspOIsol0hMNDtbCBr9LFef2rh7sZw3E4FMkyBscUTiextS GNY9EQ5vgqe3eX2NnfZV/2CsKlePSQ25toU7c//GcBFFJFBRzd0C9JSKftXUwrvCNrVG gY8i8xv2dWjikk5i++cyax2DkFklXiJm8qB9ccEuVOscsYgDmNTmv8Kwih2+nb3O49Z+ wKiZZKfml/cNlWeWzdalBCUTTeijblWUD1hwr2k2UtosDWOUgkJE+MuoHE8+uDbkHYc5 pxeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=a5sFEHSL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j17-20020a056a00235100b004e012338c8csi544325pfj.274.2022.03.08.18.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 18:01:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=a5sFEHSL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B33C122B974; Tue, 8 Mar 2022 16:34:56 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241025AbiCHI2f (ORCPT + 99 others); Tue, 8 Mar 2022 03:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238415AbiCHI2d (ORCPT ); Tue, 8 Mar 2022 03:28:33 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B455E635B; Tue, 8 Mar 2022 00:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646728057; x=1678264057; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7uv8Q1w8wsO9w5Wl3dOSyGo5iztKnC91d7tEWyKbVmo=; b=a5sFEHSLp0ksCXl/lD/UuGGLhCMtQX4ItOsg0IYf7OW9iJxm+wvQRYny /oQlNYmMNaVryI1w6wTDIa+AHWGhnD7K4hlyJsAUQoXYfNZmLUWZM/oUH GPKQ8nwwKLCRZJiJSjMCncsKxF/EmCnjS2vLftSZ1Eofdm2v+xR8SBCMz 0VCwdWWTSepfyWAGGN7OfAt8uEU+cog869gYKtMmpJHJuqpoNR2e2CfGD r573A4ZcEY7SeEijYFDw+D4cMMlpXrVgQQ15vKPvcNG25G6yaG9a0chEr OMr44BvxrxJAtyw1CN2aP5qOVkSigzTth8Eu03bMOIsQRc3STeBLcwEZz w==; X-IronPort-AV: E=Sophos;i="5.90,163,1643698800"; d="scan'208";a="148433672" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Mar 2022 01:27:32 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 8 Mar 2022 01:27:30 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 8 Mar 2022 01:27:30 -0700 Date: Tue, 8 Mar 2022 09:30:23 +0100 From: Horatiu Vultur To: Michael Walle CC: , , , , Subject: Re: [PATCH v2 1/2] pinctrl: ocelot: Fix the pincfg resource. Message-ID: <20220308083023.frr7qz2xga2tas5r@soft-dev3-1.localhost> References: <20220304144432.3397621-2-horatiu.vultur@microchip.com> <20220307124501.3487932-1-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20220307124501.3487932-1-michael@walle.cc> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 03/07/2022 13:45, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > The pincfg resources are in the second memory resource. But the driver > > still tries to access the first memory resource to get the pincfg. This > > is wrong therefore fix to access the second memory resource. > > > > Reviewed-by: Colin Foster > > Fixes: ad96111e658a95 ("pinctrl: ocelot: combine get resource and ioremap into single call") > > Signed-off-by: Horatiu Vultur > > There is already this patch pending, which does exactly > the same: > https://lore.kernel.org/linux-gpio/20220216082020.981797-1-michael@walle.cc/ Sorry, I have missed your patch. Should I resend this series where I will drop this patch? What is the correct approach? > > FWIW, there is also this one: > https://lore.kernel.org/linux-gpio/20220216122727.1005041-1-michael@walle.cc/ > > -michael -- /Horatiu