Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <fd560bc9-cb0b-0f7d-9a60-76735bc55c5e@intel.com>
Date:   Mon, 7 Mar 2022 09:13:48 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH] x86/sgx: Enable PROT_EXEC for EAUG'd pages
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Dave Hansen <dave.hansen@linux.intel.com>,
        Nathaniel McCallum <nathaniel@profian.com>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
References: <20220307153504.198112-1-jarkko@kernel.org>
 <YiYseF3aKI70x3d8@iki.fi> <YiYuH95wps+yHDk1@iki.fi>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <YiYuH95wps+yHDk1@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VklqNVM0UU9leC9KTEdyeDRJdUhxV2xlM3o4a3NnR3REdlF1b0ZrUXZZb2c2?=
 =?utf-8?B?TTNJSDR5K0NGU1Zob2JHTXBRMXhuYVg4NEdRYkl6QkNHQWR5V1I2aWlkUHY1?=
 =?utf-8?B?Qy9RRGk1amJ1VVNvYm1JMGVXWWJXeFQxT1F5ZTRPR1hkMDdnVERybEFNRXQ0?=
 =?utf-8?B?ZWQwMGZDcFN0MkRpSkd1ZHJYak4waS8zZkZ6ekRoakVncXZaMGpyZHZadHB6?=
 =?utf-8?B?dGI1ck9QTzJaZzBPNXBsUG5Gam0wKzFTN1RIQ1JIdld0VkpnSVRFNU51SWc0?=
 =?utf-8?B?TzNuc3hsd1FUeXpubGthTHhWTEJoQ3NHdWxGUkRvOG54eDVYT2NMd1VZeFg0?=
 =?utf-8?B?L3h0UnhDTTRnZUJHZXhDOE0rQmdmNUxOc0JhVFpsWUV5TGZWQmlDUGI1OVh6?=
 =?utf-8?B?azYrWjRJNTBqb2pzWXlmRDVHK3BHWHBPb2N1NjJxZnd4Q3JYeG1FdW9iNUlq?=
 =?utf-8?B?MzJ1MDdqSytEa1hrVU4vVkc3UVE4SmVyck14Y0IvSndOYmY0bldmUm11K2JN?=
 =?utf-8?B?VE1CUnlLb0h4Zk02MkVJSG10UWJsWTcwak1IbmFzTDZUOHNYR0o1NDBBTjBQ?=
 =?utf-8?B?bnFnNlh1OEpWRDVzTkZneGp4U3ExNlBDNzd4dTl5dzJsbDdJL3JRVWhua0pm?=
 =?utf-8?B?UzdBcFNPU0lSWU9HUnBPL3VTS0kxaFZxSDEzVlF6YVpuUlJRd1hrSEMyekJa?=
 =?utf-8?B?V253YmhJODh2NWFUbU03K1BtN3NicG80NUJnRHlUaEVac0NXY2ovc2ZSQm5p?=
 =?utf-8?B?VzJrcHpTM2FGSjY3VURIVVRtQmJONCsyUWVWeGxNcnZ2K09uWWh3SGNFK09U?=
 =?utf-8?B?OW5xOFliSVZ6S29zalNCczRWbkZZUUlBSFJUeVFZbUpQU1VLMVZGOEdpMWVh?=
 =?utf-8?B?MFdhRyszZjdEWVdiVXZyMFdqeVZsblMvTnlEQW1KY0c0Zlk2Yi9Zcko1aE5V?=
 =?utf-8?B?UC9HWnM5WVZLaW5IWTZDcmQ3TnN5c2lUTzhzOWc5eVE3eU9yL0ZTYU5maFBE?=
 =?utf-8?B?K1JYbWdQbnpxSjdhYVp0K3ljMFhmOXpmRkhLYW5RaUh3eWtjNEhxQ2d5UnQw?=
 =?utf-8?B?UXhLWXYyMWZWVFhlM0NMSWg1eDRCbWVYeUdqNVg5aEJXVHBDOGw2ZytYZWpH?=
 =?utf-8?B?Z3hGVnhBcmVLZitOdXdIcnhBbFF1RDRnaldkRlBRZHlkOE1zbjdVT0xUcVFL?=
 =?utf-8?B?NUlSZHBCaUFlRGpUQktYaGZ1TzdQR3Q0bUNheUpzTzRJN0RFdFg0WDBpeUxR?=
 =?utf-8?B?ZklnVTc0TEdxNyt5YjNJT1RscDBUMTA1N0JZejJOUnhCOG9ic0JzNm93dnVN?=
 =?utf-8?B?STZmQWp2OXBtZUo4T1JMVkx6elFJNjhlMWNpNFZmWGthMTNGUHMyL0t2SmJY?=
 =?utf-8?B?cnZxc0tXc0JLWWNCdTVBa1dtZWFyWXkrVDY0aTZ5S1NnMHBmd09jVE9LNzdj?=
 =?utf-8?B?S2pJbk5YZ1Y1enRUNzRhMzdyekt2Q2tYSnlnTFVKeFZtVXRpcUlYSy8yOEdn?=
 =?utf-8?B?T3o2Vk5iL2VqZW1vcStMVkwvRjgzMWExV0VKRFRNbkdIaS9DUFBPQitkQ3Zi?=
 =?utf-8?B?K2FLM2tjUXR6QmJWajFGbk5SSDh0VEhXQkpxcEhZMnQweXoyZC8xTEFIL0sz?=
 =?utf-8?B?MHB2TExqZDUxQTVqTDc2b1Y4QkdKMTFZR2tHNTk5TjNCNGpBWm9ReThRVHNG?=
 =?utf-8?B?YXR1Y2VJcmhRVXRKeUN0RkMxNEpJQWRQMERLQjRQZFpuakZ2ZGJObGdVNWlH?=
 =?utf-8?B?WVdJWDNHeVl0dkpjb0FYM1ZLUTl2WUYrY1ozUG0wUWZIdFMwOGVKL0tFdkFK?=
 =?utf-8?B?NWNHUjlnaVlMc2tQKzNJSmZQUXRGa0VUeElRd0tEeVFUMlR2aGh4WVNJZHlT?=
 =?utf-8?B?V1ZLbFdkSmZKNjg4elB5SlZKakJoWjZTMTJpa0ZXejFFSzljZkoyTi9XeGg4?=
 =?utf-8?B?UVBqME1wdnNzRldDNTdrT1MyRHpwUTBUZkFNYi9XQW5WZW1NdjhlSG9taFRB?=
 =?utf-8?B?U2hJWk9hbGdqZlZYV214SXhtRC95TTU0cEdhWnlHTy93WGVlREtPaXorWWFY?=
 =?utf-8?B?eUxEbmNKWi9OQ0hwN2FIcWV2VmxWeFl3S2xyakFkdVlQOTNiRUdTZS9VNzFy?=
 =?utf-8?B?ZlMvUmc5bVhqSnpGSWtVQ205UXBCa04xU0dDbGtSQ0tkQnVyeFVLZjZ4MzNw?=
 =?utf-8?B?bS9VNWY2MldkNlhtWUZpSlIxaEZVK3EzWUtueDBYZWxWOEpXaUNra1FISWZD?=
 =?utf-8?B?ZnkzRkJ6eEZ6ZHZZMkFoK0d5UXhnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d98aa188-70b9-4cb7-db9d-08da005ddab0
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2022 17:13:52.9996
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mXkIjrtpGvhv09Db8qgiqx6GxyJ0JQrT+XjXtOTuICooAFGs7Eis7HNT4jn/KwIc1or8ClLWhTuyYH1kJbS7/G21/83O/Clr/AK9ZK/RTFo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3118
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 3/7/2022 8:09 AM, Jarkko Sakkinen wrote:
> On Mon, Mar 07, 2022 at 06:02:03PM +0200, Jarkko Sakkinen wrote:
>> On Mon, Mar 07, 2022 at 05:35:04PM +0200, Jarkko Sakkinen wrote:
>>> vm_max_permissions was created to control the pre-initialization content
>>> that contributes to MRSIGNATURE. It was never meant to be as a limit to
>>> dynamically added pages.
>>>
>>> E.g. static content could be used as a hook for LSM's to decide whether
>>> certain signature is qualified for EINIT. Dynamic content has nothing to
>>> do with that. The current mechanisms only add to the complexity on how
>>> to control PTE and EPCM permissions, and do not add anything else than
>>> obfuscity to security side of things.

Linux has mechanisms to enforce what can be executed. For example, with SELinux
a process can be required to have PROCESS__EXECHEAP or PROCESS__EXECSTACK 
before it can be allowed to execute writable memory.

A few SGX runtimes enables unmodified executables to be run within SGX enclaves.

Does a change like this not enable executables prevented by existing 
security mechanisms to circumvent such restrictions by running within
a SGX enclave?

>>> Thus add PROT_EXEC to the permissions assigned by the #PF handler.
>>>
>>> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>>> ---
>>>  arch/x86/kernel/cpu/sgx/encl.c | 9 ++++-----
>>>  1 file changed, 4 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/x86/kernel/cpu/sgx/encl.c b/arch/x86/kernel/cpu/sgx/encl.c
>>> index 79e39bd99c09..0256918b2c2f 100644
>>> --- a/arch/x86/kernel/cpu/sgx/encl.c
>>> +++ b/arch/x86/kernel/cpu/sgx/encl.c
>>> @@ -160,12 +160,11 @@ static vm_fault_t sgx_encl_eaug_page(struct vm_area_struct *vma,
>>>  	encl_page->encl = encl;
>>>  
>>>  	/*
>>> -	 * Adding a regular page that is architecturally allowed to only
>>> -	 * be created with RW permissions.
>>> -	 * TBD: Interface with user space policy to support max permissions
>>> -	 * of RWX.
>>> +	 * Dynamic pages do not contribute to MRSIGNATURE, i.e. they are
>>> +	 * controlled only by PTE and EPCM permissions. Thus, the no limit
>>> +	 * is set here.
>>>  	 */
>>> -	prot = PROT_READ | PROT_WRITE;
>>> +	prot = PROT_READ | PROT_WRITE | PROT_EXEC;
>>>  	encl_page->vm_run_prot_bits = calc_vm_prot_bits(prot, 0);
>>>  	encl_page->vm_max_prot_bits = encl_page->vm_run_prot_bits;
>>>  
>>> -- 
>>> 2.35.1
>>>
>>
>> This is really a show stopper. I think here's a logical mistake on for what
>> purpose vm_max_prot_bits are used for. They are meant for the static and
>> also signed content of the enclave.
>>
>> These changes in the patch set that are related to vm_max_prot_bits only
>> messes up what already exists, and make incredibly hard to implement
>> anything decent on top of SGX2 features.
> 
> I.e. once signed content has passed EINIT ioctl, and whatever checks
> there are now or in future (e.g. LSM hooks), the system has accepted
> the enclave behaviour, and it includes also the use of EACCEPT opcode.
> 
> It's the exec or no-exec decision point. The thing that these patches
> do is making an obfuscated mess of all this. When EINIT has passed,
> it has been decided that the enclave can do its workload. Let's not
> throw stick in front of it, and make everyones life misserable.

A common use for these dynamically added pages is to increase the heap
and stack. Always allowing PTEs of RWX on these pages irrespective
whether it will be used for heap, stack, or relocatable code does
not match with how the kernel manages protections.

As I said before I am not comfortable with such a change and cannot
sign off on this. I would defer to the maintainers to choose the
direction.

Reinette