Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3585734pxp; Tue, 8 Mar 2022 18:07:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgz/uDuGt4pqh+5BNW80HeC++aRoYj1ESio9roxB0nLqHCkGuxGzWOMUAckMhTy006kR8L X-Received: by 2002:a17:903:1246:b0:151:94d9:eeb2 with SMTP id u6-20020a170903124600b0015194d9eeb2mr20052035plh.165.1646791657430; Tue, 08 Mar 2022 18:07:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646791657; cv=none; d=google.com; s=arc-20160816; b=eCNe6n/h77tbJ7V1DbF79ZYeWBpHxriXRzhVP2yByqKlgaaT0JqDHRRbBXt4h/rDYR cVrfxhrFq7l6twVLNWn/jjmaJPN3VjPlZ9Y6xvks7uBAyo3gmaEMwnbsA5vuNA2Izkhp UnD3oVs+sSWqR/YFdzIIWQEUpk8KePUSxfHGXM8gW1CmXpBeLNmxgrz4EO5hux69GjSU 3o2frQOxwM1bB9UxuduzJMJo1k/0oYsv6hN5QLZ0iRvbOG5DTgnmNvh1YbWl97+hVblq az5QVXaWkcumGmAylqvYjrqBscDJmYCtMIBfJxEdWj720X8o7gQhFVZl5pEnpCRSW4Rw aVuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4AMo7a+1jYhUbTd5eXCuX2jQ4/Cx5HSKuDlGnN/Zuvc=; b=UZRkFHh5sHND0Cy7UVpcFOnuwkJa6/vXiMMDaXtxzJLoqjd/Mz6fT4G8vvhPYn5Y/Z l31ABPn8nu2Ayw+Agv4fHORiWddWQ3P9IxABhZH/YIqwHTtCq07zwuNzQwVHxmUURUIv 1e/Ch/5OprES8qQICZ9JfpfTNSBygnx9fuWxLQahegCafplg6Qtmf6Ny+5sJGLR7pdvf hR+bXxMLWbAk7usPgPWvl1ol/9kViYdPKvQlw3IwITVCuRaIydLEM2dYnNPaeCIye6Ka NHkqV1yeqCz4qn3d+EySfrsresiMbzmJU9TbCDemHX01teSOzijQdIa8GLAZaQTQqI8S QzCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=j8zjA6LQ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d9-20020a631d09000000b0037562967a7fsi522932pgd.160.2022.03.08.18.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 18:07:37 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=j8zjA6LQ; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B2F55255FB3; Tue, 8 Mar 2022 16:39:02 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238193AbiCHNQl (ORCPT + 99 others); Tue, 8 Mar 2022 08:16:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiCHNQk (ORCPT ); Tue, 8 Mar 2022 08:16:40 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE5B28E20; Tue, 8 Mar 2022 05:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4AMo7a+1jYhUbTd5eXCuX2jQ4/Cx5HSKuDlGnN/Zuvc=; b=j8zjA6LQrLmR/0SSpgvvXDpFpZ XXUplKADfDcwPXoPqfWxYyyKVNd81HyV5gPQG6Grb9n91cu4j3mq1cu1y2s+MOXlaKAnPch9ITD1I ur3+4UYRTIJHEVhGCgRPvxdyi466bFAMkiTcxbPoc40FsG7IXTuAqFsZUlt5vRwx1T54=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nRZgI-009naD-7D; Tue, 08 Mar 2022 14:15:14 +0100 Date: Tue, 8 Mar 2022 14:15:14 +0100 From: Andrew Lunn To: Miaoqian Lin Cc: "David S. Miller" , Jakub Kicinski , Michal Simek , Arnd Bergmann , Michael Walle , Lad Prabhakar , YueHaibing , John Linn , Grant Likely , Sadanand Mutyala , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ethernet: Fix error handling in xemaclite_of_probe Message-ID: References: <20220308024751.2320-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220308024751.2320-1-linmq006@gmail.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 08, 2022 at 02:47:49AM +0000, Miaoqian Lin wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. Calling of_node_put() to avoid the > refcount leak. As the remove function do. > > Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support") > Signed-off-by: Miaoqian Lin Reviewed-by: Andrew Lunn Andrew