Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp3585881pxp; Tue, 8 Mar 2022 18:07:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHTpEON0p8PrGslU+WpY3MnYgv+C6ULRboyjCVn4GoUb56xu0BoiPsU+WlvIpS2iPzHOq4 X-Received: by 2002:a17:902:e889:b0:151:a56d:eb8f with SMTP id w9-20020a170902e88900b00151a56deb8fmr20261174plg.142.1646791669070; Tue, 08 Mar 2022 18:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646791669; cv=none; d=google.com; s=arc-20160816; b=RJb3NaEan3BFizqYXjzCkSKBCoVs5//KsKVtl3mLdnfZzua4Zhdt4Xs43g+TPdAuN0 ObpMAOxKyWkeU5LI4y1UVm4MVfQfnmEqi2MKFw54J1bkQyyxUoYWTOUrwi0eKsHHaoP8 x1QVExYhecIQYD9P8joIW49TBDdY4Y5rbIYVZIKpy98vyND+V9nbXhC2fTGtImax9z+k coMjEJpm5MvoIODmoF/HMN1bt5hNpltyqibZfrSsNumDLoGYnMQ6TlWokO92OiKgNZO2 gnZGa1BnSZYyasAKZ+H+H5C+r7GrjH+AgbJy+SC0GQMPOkaqIDTdxahkIttpVj/aBnTs +lRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=sVMgvE0p/kz+zNZmeAzhX3KYnUwwfx3nSs+4oOserOk=; b=uqdua9e1dVoopzSgPOymCOvomWrqKUKutyF0Vluxshj0rCYGOWqNh+VexFJyPgvrXi pCqs/AucLVpveXkMI/13Af8shzTGWfmbkabK8qU9dmhH4ulkOwTexnsAxR0ffGtBm5Pe FzzqeCdGuBBESzEooZNgTL96aOw7Alv5COb/gyHTBvJw73uV3zm96FcQ2CBy2vwUFXAU FxrXN2ER4imWATlC6uAZ0kqJd12Gnmq+fRV3Pe33DaEYUZUKkMES4zG0d2M2+ZslllOk WVT220ESXlSFwYvniXeUdA1K/Hcp7S2CPFXE615YZgfpwqL9LUfSXiMyf0doWcZcnO0I s2wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EvLSWYVI; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id u33-20020a631421000000b003651426b169si518949pgl.348.2022.03.08.18.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 18:07:49 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EvLSWYVI; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 78291254AA0; Tue, 8 Mar 2022 16:38:48 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349128AbiCHRZB (ORCPT + 99 others); Tue, 8 Mar 2022 12:25:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349502AbiCHRXP (ORCPT ); Tue, 8 Mar 2022 12:23:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB40556439 for ; Tue, 8 Mar 2022 09:21:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 32D38B81BA6 for ; Tue, 8 Mar 2022 17:21:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10F08C340EB; Tue, 8 Mar 2022 17:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646760074; bh=YzDVRHHe4KzIf6sXoA5Jjdffip2Zv92DuhYkKW62tqo=; h=From:To:In-Reply-To:References:Subject:Date:From; b=EvLSWYVIL9zy84zHJXvJHR6qwowDJYxdmUl1KmGK8Zl+1Ve1KT11oG6GYDPPD+YZ3 CPgSdPx2EGvltyY6moIgaWk1gj7GSBAjVi/eFlPXTN52ec2wTKfjWutVsMNPD5kDe1 1Xf0eDyS5dQG3ALvR6VLhciHatZPRUf6LTaWgPhKBg+1eyJqBwyat7c55d2A0l7iUG wtgNwE5psvgV9Xfz3sFCrsT4iPTYqg5vpz3+J5qweW86JR8q+XlLufld5CrD5Gka1x kgr4NC7xLVOoTOQMYvcRXjixWJJ4vvM22r9jOFHXUSteeAPnr6UX6cs5xkq1GhwnaS YfFzsx0/VG5cQ== From: Mark Brown To: Kuninori Morimoto , Jaroslav Kysela , alsa-devel@alsa-project.org, Miaoqian Lin , Sascha Hauer , Takashi Iwai , Liam Girdwood , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shawn Guo , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam In-Reply-To: <20220308020146.26496-1-linmq006@gmail.com> References: <20220308020146.26496-1-linmq006@gmail.com> Subject: Re: [PATCH] ASoC: mxs: Fix error handling in mxs_sgtl5000_probe Message-Id: <164676007157.54315.10226994232050384296.b4-ty@kernel.org> Date: Tue, 08 Mar 2022 17:21:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2022 02:01:44 +0000, Miaoqian Lin wrote: > This function only calls of_node_put() in the regular path. > And it will cause refcount leak in error paths. > For example, when codec_np is NULL, saif_np[0] and saif_np[1] > are not NULL, it will cause leaks. > > of_node_put() will check if the node pointer is NULL, so we can > call it directly to release the refcount of regular pointers. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: mxs: Fix error handling in mxs_sgtl5000_probe commit: 6ae0a4d8fec551ec581d620f0eb1fe31f755551c All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark