Date: Wed, 21 Feb 2007 13:12:59 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Suleiman Souhlal <ssouhlal@FreeBSD.org>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Don't change transfer speed while requests are in
 flight
Message-ID: <20070221131259.3817762d@lxorguk.ukuu.org.uk>
In-Reply-To: <20070221012112.GB1777@freefall.freebsd.org>
References: <20070221012112.GB1777@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 547
Lines: 13

> +	 * If we are in an interrupt, it should be safe to issue
> +	 * SETFEATURES manually, since there shouldn't be any requests in
> +	 * flight.

There may be error recovery going on from a timeout on another processor.
I don't see how your code protects against that (and the old code is
broken too)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/